Re: [PATCH v3 0/4] add i2c support for mt8192

From: Matthias Brugger <matthias.bgg@gmail.com>
To: wsa@the-dreams.de, Qii Wang <qii.wang@mediatek.com>,
	robh+dt@kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	srv_heupstream@mediatek.com
Subject: Re: [PATCH v3 0/4] add i2c support for mt8192
Date: Thu, 6 Aug 2020 08:30:25 +0200	[thread overview]
Message-ID: <249df8b3-6125-6ebd-2835-ab703f05b85a@gmail.com> (raw)
In-Reply-To: <20200805214242.GA2182@kunai>

On 05/08/2020 23:42, wsa@the-dreams.de wrote:
> On Wed, Aug 05, 2020 at 06:52:18PM +0800, Qii Wang wrote:
>> This series are based on 5.8-rc1 and we provide four i2c patches
>> to support mt8192 SoC.
>>
>> Main changes compared to v2:
>> --delete unused I2C_DMA_4G_MODE
>>
>> Main changes compared to v1:
>> --modify the commit with access more than 8GB dram
>> --add Reviewed-by and Acked-by from Yingjoe, Matthias and Rob
>>
>> Qii Wang (4):
>>    i2c: mediatek: Add apdma sync in i2c driver
>>    i2c: mediatek: Add access to more than 8GB dram in i2c driver
>>    dt-bindings: i2c: update bindings for MT8192 SoC
>>    i2c: mediatek: Add i2c compatible for MediaTek MT8192
>>
>>   .../devicetree/bindings/i2c/i2c-mt65xx.txt         |  1 +
> 
> Applied to for-next, thanks!
> 
> Sidenote: I get these warnings when compiling the driver:
> 
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_low_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_high_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_sta_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'max_hd_dat_ns' not described in 'i2c_spec_values'
> drivers/i2c/busses/i2c-mt65xx.c:267: warning: Function parameter or member 'min_su_dat_ns' not described in 'i2c_spec_values'
> 
> Is someone interested to fix these?
> 

I just send a fix for that.

Regards,
Matthias