From: Coly Li <colyli@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Richard Weinberger <richard@nod.at>,
Jan Kara <jack@suse.com>,
linux-block@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 19/20] bcache: remove a superflous lookup_bdev all
Date: Wed, 18 Nov 2020 17:55:38 +0800 [thread overview]
Message-ID: <24c818c2-6aba-098c-0c73-0a5081175c06@suse.de> (raw)
In-Reply-To: <X7TlIzxJPfa2p+Da@kroah.com>
On 11/18/20 5:10 PM, Greg KH wrote:
> On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote:
>> On 11/18/20 4:47 PM, Christoph Hellwig wrote:
>>> Don't bother to call lookup_bdev for just a slightly different error
>>> message without any functional change.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>ist
>>
>> Hi Christoph,
>>
>> NACK. This removing error message is frequently triggered and observed,
>> and distinct a busy device and an already registered device is important
>> (the first one is critical error and second one is not).
>>
>> Remove such error message will be a functional regression.
>
> What normal operation causes this error message to be emitted? And what
> can a user do with it?
When there was bug and the caching or backing device was not
unregistered successfully, people could see "device busy"; and if it was
because the device registered again, it could be "already registered".
Without the different message, people may think the device is always
busy but indeed it isn't.
he motivation of the patch is OK to me, but we need to make the logical
consistent, otherwise we will have similar bug report for bogus warning
dmesg from bcache users in soon future.
Coly Li
WARNING: multiple messages have this Message-ID (diff)
From: Coly Li <colyli@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Richard Weinberger <richard@nod.at>,
Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
linux-mm@kvack.org, Jan Kara <jack@suse.com>,
Tejun Heo <tj@kernel.org>,
xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 19/20] bcache: remove a superflous lookup_bdev all
Date: Wed, 18 Nov 2020 17:55:38 +0800 [thread overview]
Message-ID: <24c818c2-6aba-098c-0c73-0a5081175c06@suse.de> (raw)
In-Reply-To: <X7TlIzxJPfa2p+Da@kroah.com>
On 11/18/20 5:10 PM, Greg KH wrote:
> On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote:
>> On 11/18/20 4:47 PM, Christoph Hellwig wrote:
>>> Don't bother to call lookup_bdev for just a slightly different error
>>> message without any functional change.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>ist
>>
>> Hi Christoph,
>>
>> NACK. This removing error message is frequently triggered and observed,
>> and distinct a busy device and an already registered device is important
>> (the first one is critical error and second one is not).
>>
>> Remove such error message will be a functional regression.
>
> What normal operation causes this error message to be emitted? And what
> can a user do with it?
When there was bug and the caching or backing device was not
unregistered successfully, people could see "device busy"; and if it was
because the device registered again, it could be "already registered".
Without the different message, people may think the device is always
busy but indeed it isn't.
he motivation of the patch is OK to me, but we need to make the logical
consistent, otherwise we will have similar bug report for bogus warning
dmesg from bcache users in soon future.
Coly Li
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Coly Li <colyli@suse.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Richard Weinberger <richard@nod.at>,
Josef Bacik <josef@toxicpanda.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
linux-mm@kvack.org, Jan Kara <jack@suse.com>,
Tejun Heo <tj@kernel.org>,
xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [PATCH 19/20] bcache: remove a superflous lookup_bdev all
Date: Wed, 18 Nov 2020 17:55:38 +0800 [thread overview]
Message-ID: <24c818c2-6aba-098c-0c73-0a5081175c06@suse.de> (raw)
In-Reply-To: <X7TlIzxJPfa2p+Da@kroah.com>
On 11/18/20 5:10 PM, Greg KH wrote:
> On Wed, Nov 18, 2020 at 04:54:51PM +0800, Coly Li wrote:
>> On 11/18/20 4:47 PM, Christoph Hellwig wrote:
>>> Don't bother to call lookup_bdev for just a slightly different error
>>> message without any functional change.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>ist
>>
>> Hi Christoph,
>>
>> NACK. This removing error message is frequently triggered and observed,
>> and distinct a busy device and an already registered device is important
>> (the first one is critical error and second one is not).
>>
>> Remove such error message will be a functional regression.
>
> What normal operation causes this error message to be emitted? And what
> can a user do with it?
When there was bug and the caching or backing device was not
unregistered successfully, people could see "device busy"; and if it was
because the device registered again, it could be "already registered".
Without the different message, people may think the device is always
busy but indeed it isn't.
he motivation of the patch is OK to me, but we need to make the logical
consistent, otherwise we will have similar bug report for bogus warning
dmesg from bcache users in soon future.
Coly Li
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-11-18 9:55 UTC|newest]
Thread overview: 237+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 8:47 merge struct block_device and struct hd_struct Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 8:47 ` [PATCH 01/20] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:09 ` Jan Kara
2020-11-18 14:09 ` [dm-devel] " Jan Kara
2020-11-18 14:09 ` Jan Kara
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-19 8:37 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-24 12:26 ` Tejun Heo
2020-11-24 12:26 ` [dm-devel] " Tejun Heo
2020-11-24 12:26 ` Tejun Heo
2020-11-18 8:47 ` [PATCH 02/20] block: remove a duplicate __disk_get_part prototype Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:10 ` Jan Kara
2020-11-18 14:10 ` [dm-devel] " Jan Kara
2020-11-18 14:10 ` Jan Kara
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-19 8:37 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 03/20] block: add a bdev_kobj helper Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:18 ` Jan Kara
2020-11-18 14:18 ` [dm-devel] " Jan Kara
2020-11-18 14:18 ` Jan Kara
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-19 8:37 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 04/20] block: use disk_part_iter_exit in disk_part_iter_next Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:19 ` Jan Kara
2020-11-18 14:19 ` [dm-devel] " Jan Kara
2020-11-18 14:19 ` Jan Kara
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-19 8:37 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:37 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 05/20] block: use put_device in put_disk Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:20 ` Jan Kara
2020-11-18 14:20 ` [dm-devel] " Jan Kara
2020-11-18 14:20 ` Jan Kara
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-19 8:38 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 06/20] block: change the hash used for looking up block devices Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:22 ` Jan Kara
2020-11-18 14:22 ` [dm-devel] " Jan Kara
2020-11-18 14:22 ` Jan Kara
2020-11-18 8:47 ` [PATCH 07/20] init: refactor name_to_dev_t Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:37 ` Jan Kara
2020-11-18 14:37 ` [dm-devel] " Jan Kara
2020-11-18 14:37 ` Jan Kara
2020-11-19 7:52 ` Christoph Hellwig
2020-11-19 7:52 ` [dm-devel] " Christoph Hellwig
2020-11-19 7:52 ` Christoph Hellwig
2020-11-19 8:25 ` Jan Kara
2020-11-19 8:25 ` [dm-devel] " Jan Kara
2020-11-19 8:25 ` Jan Kara
2020-11-20 8:49 ` Christoph Hellwig
2020-11-20 8:49 ` [dm-devel] " Christoph Hellwig
2020-11-20 8:49 ` Christoph Hellwig
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-19 8:38 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 08/20] init: refactor devt_from_partuuid Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:41 ` Jan Kara
2020-11-18 14:41 ` [dm-devel] " Jan Kara
2020-11-18 14:41 ` Jan Kara
2020-11-18 8:47 ` [PATCH 09/20] init: cleanup match_dev_by_uuid and match_dev_by_label Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:42 ` Jan Kara
2020-11-18 14:42 ` [dm-devel] " Jan Kara
2020-11-18 14:42 ` Jan Kara
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-19 8:38 ` [dm-devel] " Johannes Thumshirn
2020-11-19 8:38 ` Johannes Thumshirn
2020-11-18 8:47 ` [PATCH 10/20] block: refactor __blkdev_put Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 14:46 ` Jan Kara
2020-11-18 14:46 ` [dm-devel] " Jan Kara
2020-11-18 14:46 ` Jan Kara
2020-11-18 8:47 ` [PATCH 11/20] block: reference struct block_device from struct hd_struct Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 9:41 ` Jan Kara
2020-11-19 9:41 ` [dm-devel] " Jan Kara
2020-11-19 9:41 ` Jan Kara
2020-11-20 8:56 ` Christoph Hellwig
2020-11-20 8:56 ` [dm-devel] " Christoph Hellwig
2020-11-20 8:56 ` Christoph Hellwig
2020-11-24 16:59 ` Tejun Heo
2020-11-24 16:59 ` [dm-devel] " Tejun Heo
2020-11-24 16:59 ` Tejun Heo
2020-11-25 11:40 ` Jan Kara
2020-11-25 11:40 ` [dm-devel] " Jan Kara
2020-11-25 11:40 ` Jan Kara
2020-11-25 12:09 ` Tejun Heo
2020-11-25 12:09 ` [dm-devel] " Tejun Heo
2020-11-25 12:09 ` Tejun Heo
2020-11-18 8:47 ` [PATCH 12/20] block: simplify the block device claiming interface Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 10:07 ` Jan Kara
2020-11-19 10:07 ` [dm-devel] " Jan Kara
2020-11-19 10:07 ` Jan Kara
2020-11-18 8:47 ` [PATCH 13/20] block: remove ->bd_contains Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 10:32 ` Jan Kara
2020-11-19 10:32 ` [dm-devel] " Jan Kara
2020-11-19 10:32 ` Jan Kara
2020-11-20 9:01 ` Christoph Hellwig
2020-11-20 9:01 ` [dm-devel] " Christoph Hellwig
2020-11-20 9:01 ` Christoph Hellwig
2020-11-18 8:47 ` [PATCH 14/20] block: remove the nr_sects field in struct hd_struct Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 12:05 ` Jan Kara
2020-11-19 12:05 ` [dm-devel] " Jan Kara
2020-11-19 12:05 ` Jan Kara
2020-11-20 9:08 ` Christoph Hellwig
2020-11-20 9:08 ` [dm-devel] " Christoph Hellwig
2020-11-20 9:08 ` Christoph Hellwig
2020-11-20 11:21 ` Jan Kara
2020-11-20 11:21 ` [dm-devel] " Jan Kara
2020-11-20 11:21 ` Jan Kara
2020-11-20 15:32 ` Christoph Hellwig
2020-11-20 15:32 ` [dm-devel] " Christoph Hellwig
2020-11-20 15:32 ` Christoph Hellwig
2020-11-20 15:59 ` Matthew Wilcox
2020-11-20 15:59 ` [dm-devel] " Matthew Wilcox
2020-11-20 15:59 ` Matthew Wilcox
2020-11-20 16:01 ` Christoph Hellwig
2020-11-20 16:01 ` [dm-devel] " Christoph Hellwig
2020-11-20 16:01 ` Christoph Hellwig
2020-11-20 20:05 ` Jan Kara
2020-11-20 20:05 ` [dm-devel] " Jan Kara
2020-11-20 20:05 ` Jan Kara
2020-11-21 16:24 ` Christoph Hellwig
2020-11-21 16:24 ` [dm-devel] " Christoph Hellwig
2020-11-21 16:24 ` Christoph Hellwig
2020-11-18 8:47 ` [PATCH 15/20] block: merge struct block_device and " Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 14:39 ` Jan Kara
2020-11-19 14:39 ` [dm-devel] " Jan Kara
2020-11-19 14:39 ` Jan Kara
2020-11-20 9:15 ` Christoph Hellwig
2020-11-20 9:15 ` [dm-devel] " Christoph Hellwig
2020-11-20 9:15 ` Christoph Hellwig
2020-11-20 10:53 ` Jan Kara
2020-11-20 10:53 ` [dm-devel] " Jan Kara
2020-11-20 10:53 ` Jan Kara
2020-11-18 8:47 ` [PATCH 16/20] block: stop using bdget_disk for partition 0 Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 14:43 ` Jan Kara
2020-11-19 14:43 ` [dm-devel] " Jan Kara
2020-11-19 14:43 ` Jan Kara
2020-11-18 8:47 ` [PATCH 17/20] filemap: consistently use ->f_mapping over ->i_mapping Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 14:53 ` Jan Kara
2020-11-19 14:53 ` [dm-devel] " Jan Kara
2020-11-19 14:53 ` Jan Kara
2020-11-19 15:13 ` Matthew Wilcox
2020-11-19 15:13 ` [dm-devel] " Matthew Wilcox
2020-11-19 15:13 ` Matthew Wilcox
2020-11-20 9:17 ` Christoph Hellwig
2020-11-20 9:17 ` [dm-devel] " Christoph Hellwig
2020-11-20 9:17 ` Christoph Hellwig
2020-11-18 8:47 ` [PATCH 18/20] fs: remove get_super_thawed and get_super_exclusive_thawed Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-19 14:59 ` Jan Kara
2020-11-19 14:59 ` [dm-devel] " Jan Kara
2020-11-19 14:59 ` Jan Kara
2020-11-18 8:47 ` [PATCH 19/20] bcache: remove a superflous lookup_bdev all Christoph Hellwig
2020-11-18 8:47 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:47 ` Christoph Hellwig
2020-11-18 8:54 ` Coly Li
2020-11-18 8:54 ` [dm-devel] " Coly Li
2020-11-18 8:54 ` Coly Li
2020-11-18 9:10 ` Greg KH
2020-11-18 9:10 ` [dm-devel] " Greg KH
2020-11-18 9:10 ` Greg KH
2020-11-18 9:55 ` Coly Li [this message]
2020-11-18 9:55 ` [dm-devel] " Coly Li
2020-11-18 9:55 ` Coly Li
2020-11-18 16:24 ` Christoph Hellwig
2020-11-18 16:24 ` [dm-devel] " Christoph Hellwig
2020-11-18 16:24 ` Christoph Hellwig
2020-11-18 8:48 ` [PATCH 20/20] block: remove i_bdev Christoph Hellwig
2020-11-18 8:48 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:48 ` Christoph Hellwig
2020-11-18 8:56 ` merge struct block_device and struct hd_struct Jan Beulich
2020-11-18 8:56 ` [dm-devel] " Jan Beulich
2020-11-18 8:56 ` Jan Beulich
2020-11-18 8:58 ` Christoph Hellwig
2020-11-18 8:58 ` [dm-devel] " Christoph Hellwig
2020-11-18 8:58 ` Christoph Hellwig
2020-11-18 9:04 ` Jan Beulich
2020-11-18 9:04 ` [dm-devel] " Jan Beulich
2020-11-18 9:04 ` Jan Beulich
2020-11-18 9:08 ` Christoph Hellwig
2020-11-18 9:08 ` [dm-devel] " Christoph Hellwig
2020-11-18 9:08 ` Christoph Hellwig
2020-11-18 9:09 ` Greg KH
2020-11-18 9:09 ` [dm-devel] " Greg KH
2020-11-18 9:09 ` Greg KH
2020-11-18 9:23 ` Jan Beulich
2020-11-18 9:23 ` [dm-devel] " Jan Beulich
2020-11-18 9:23 ` Jan Beulich
2020-11-18 9:32 ` Greg KH
2020-11-18 9:32 ` [dm-devel] " Greg KH
2020-11-18 9:32 ` Greg KH
2020-11-18 12:50 ` Matthew Wilcox
2020-11-18 12:50 ` [dm-devel] " Matthew Wilcox
2020-11-18 12:50 ` Matthew Wilcox
2020-11-18 9:13 ` Greg KH
2020-11-18 9:13 ` [dm-devel] " Greg KH
2020-11-18 9:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24c818c2-6aba-098c-0c73-0a5081175c06@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=josef@toxicpanda.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.