From: Colin Ian King <colin.king@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init
Date: Wed, 30 Jan 2019 09:34:35 +0000 [thread overview]
Message-ID: <25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com> (raw)
In-Reply-To: <20190130103250.4080a3b3@xps13>
On 30/01/2019 09:32, Miquel Raynal wrote:
> Hi Liang, Colin,
>
> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49
> +0800:
>
>> Hi Colin,
>>
>> On 2019/1/29 18:57, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The call to meson_chip_buffer_init is not assigning ret, however, ret
>>> is being checked for failure. Fix this by adding in the missing assignment.
>>>
>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index e858d58d97b0..b9c543d1054c 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
>>> dev_err(nfc->dev, "16bits bus width not supported");
>>> return -EINVAL;
>>> }
>>> - meson_chip_buffer_init(nand);
>>> + ret = meson_chip_buffer_init(nand);
>>
>> Looks good to me:
>>
>> Acked-by: Liang Yang <liang.yang@amlogic.com>
>
> This is nand/next material, so if you don't mind I would like to squash
> the two fixes you sent into the original commit inserting the driver.
Sure, ok with me, squashing them makes sense.
Colin
>
>
> Thanks,
> Miquèl
>
WARNING: multiple messages have this Message-ID (diff)
From: Colin Ian King <colin.king@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_
Date: Wed, 30 Jan 2019 09:34:35 +0000 [thread overview]
Message-ID: <25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com> (raw)
In-Reply-To: <20190130103250.4080a3b3@xps13>
On 30/01/2019 09:32, Miquel Raynal wrote:
> Hi Liang, Colin,
>
> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49
> +0800:
>
>> Hi Colin,
>>
>> On 2019/1/29 18:57, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The call to meson_chip_buffer_init is not assigning ret, however, ret
>>> is being checked for failure. Fix this by adding in the missing assignment.
>>>
>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index e858d58d97b0..b9c543d1054c 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
>>> dev_err(nfc->dev, "16bits bus width not supported");
>>> return -EINVAL;
>>> }
>>> - meson_chip_buffer_init(nand);
>>> + ret = meson_chip_buffer_init(nand);
>>
>> Looks good to me:
>>
>> Acked-by: Liang Yang <liang.yang@amlogic.com>
>
> This is nand/next material, so if you don't mind I would like to squash
> the two fixes you sent into the original commit inserting the driver.
Sure, ok with me, squashing them makes sense.
Colin
>
>
> Thanks,
> Miquèl
>
WARNING: multiple messages have this Message-ID (diff)
From: Colin Ian King <colin.king@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init
Date: Wed, 30 Jan 2019 09:34:35 +0000 [thread overview]
Message-ID: <25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com> (raw)
In-Reply-To: <20190130103250.4080a3b3@xps13>
On 30/01/2019 09:32, Miquel Raynal wrote:
> Hi Liang, Colin,
>
> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49
> +0800:
>
>> Hi Colin,
>>
>> On 2019/1/29 18:57, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The call to meson_chip_buffer_init is not assigning ret, however, ret
>>> is being checked for failure. Fix this by adding in the missing assignment.
>>>
>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index e858d58d97b0..b9c543d1054c 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
>>> dev_err(nfc->dev, "16bits bus width not supported");
>>> return -EINVAL;
>>> }
>>> - meson_chip_buffer_init(nand);
>>> + ret = meson_chip_buffer_init(nand);
>>
>> Looks good to me:
>>
>> Acked-by: Liang Yang <liang.yang@amlogic.com>
>
> This is nand/next material, so if you don't mind I would like to squash
> the two fixes you sent into the original commit inserting the driver.
Sure, ok with me, squashing them makes sense.
Colin
>
>
> Thanks,
> Miquèl
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Colin Ian King <colin.king@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init
Date: Wed, 30 Jan 2019 09:34:35 +0000 [thread overview]
Message-ID: <25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com> (raw)
In-Reply-To: <20190130103250.4080a3b3@xps13>
On 30/01/2019 09:32, Miquel Raynal wrote:
> Hi Liang, Colin,
>
> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49
> +0800:
>
>> Hi Colin,
>>
>> On 2019/1/29 18:57, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The call to meson_chip_buffer_init is not assigning ret, however, ret
>>> is being checked for failure. Fix this by adding in the missing assignment.
>>>
>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index e858d58d97b0..b9c543d1054c 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
>>> dev_err(nfc->dev, "16bits bus width not supported");
>>> return -EINVAL;
>>> }
>>> - meson_chip_buffer_init(nand);
>>> + ret = meson_chip_buffer_init(nand);
>>
>> Looks good to me:
>>
>> Acked-by: Liang Yang <liang.yang@amlogic.com>
>
> This is nand/next material, so if you don't mind I would like to squash
> the two fixes you sent into the original commit inserting the driver.
Sure, ok with me, squashing them makes sense.
Colin
>
>
> Thanks,
> Miquèl
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Colin Ian King <colin.king@canonical.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Liang Yang <liang.yang@amlogic.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init
Date: Wed, 30 Jan 2019 09:34:35 +0000 [thread overview]
Message-ID: <25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com> (raw)
In-Reply-To: <20190130103250.4080a3b3@xps13>
On 30/01/2019 09:32, Miquel Raynal wrote:
> Hi Liang, Colin,
>
> Liang Yang <liang.yang@amlogic.com> wrote on Wed, 30 Jan 2019 17:26:49
> +0800:
>
>> Hi Colin,
>>
>> On 2019/1/29 18:57, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The call to meson_chip_buffer_init is not assigning ret, however, ret
>>> is being checked for failure. Fix this by adding in the missing assignment.
>>>
>>> Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> drivers/mtd/nand/raw/meson_nand.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
>>> index e858d58d97b0..b9c543d1054c 100644
>>> --- a/drivers/mtd/nand/raw/meson_nand.c
>>> +++ b/drivers/mtd/nand/raw/meson_nand.c
>>> @@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
>>> dev_err(nfc->dev, "16bits bus width not supported");
>>> return -EINVAL;
>>> }
>>> - meson_chip_buffer_init(nand);
>>> + ret = meson_chip_buffer_init(nand);
>>
>> Looks good to me:
>>
>> Acked-by: Liang Yang <liang.yang@amlogic.com>
>
> This is nand/next material, so if you don't mind I would like to squash
> the two fixes you sent into the original commit inserting the driver.
Sure, ok with me, squashing them makes sense.
Colin
>
>
> Thanks,
> Miquèl
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-30 9:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 10:57 [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin King
2019-01-29 10:57 ` Colin King
2019-01-29 10:57 ` Colin King
2019-01-29 10:57 ` Colin King
2019-01-30 5:20 ` Liang Yang
2019-01-30 5:20 ` Liang Yang
2019-01-30 5:20 ` Liang Yang
2019-01-30 5:20 ` Liang Yang
2019-01-30 5:20 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Liang Yang
2019-01-30 9:26 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Liang Yang
2019-01-30 9:26 ` Liang Yang
2019-01-30 9:26 ` Liang Yang
2019-01-30 9:26 ` Liang Yang
2019-01-30 9:26 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Liang Yang
2019-01-30 9:32 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Miquel Raynal
2019-01-30 9:32 ` Miquel Raynal
2019-01-30 9:32 ` Miquel Raynal
2019-01-30 9:32 ` Miquel Raynal
2019-01-30 9:32 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Miquel Raynal
2019-01-30 9:34 ` Colin Ian King [this message]
2019-01-30 9:34 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Colin Ian King
2019-01-30 9:34 ` Colin Ian King
2019-01-30 9:34 ` Colin Ian King
2019-01-30 9:34 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Colin Ian King
2019-01-30 9:43 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Liang Yang
2019-01-30 9:43 ` Liang Yang
2019-01-30 9:43 ` Liang Yang
2019-01-30 9:43 ` Liang Yang
2019-01-30 9:43 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Liang Yang
2019-02-05 19:05 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init Miquel Raynal
2019-02-05 19:05 ` Miquel Raynal
2019-02-05 19:05 ` Miquel Raynal
2019-02-05 19:05 ` Miquel Raynal
2019-02-05 19:05 ` [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_ Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25109367-14bc-90b1-f0a9-ad65aac46bf8@canonical.com \
--to=colin.king@canonical.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.