From: Heiko Stuebner <heiko@sntech.de>
To: Frank Wang <frank.wang@rock-chips.com>
Cc: robh+dt@kernel.org, ulf.hansson@linaro.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
charles.chen@rock-chips.com, kevan.lan@rock-chips.com,
huangtao@rock-chips.com, finley.xiao@rock-chips.com,
david.wu@rock-chips.com, shawn.lin@rock-chips.com,
wmc@rock-chips.com
Subject: Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228
Date: Thu, 15 Jun 2017 17:10:38 +0200 [thread overview]
Message-ID: <2537345.MJmYY2BcSn@phil> (raw)
In-Reply-To: <1497511396-23308-1-git-send-email-frank.wang@rock-chips.com>
Hi Frank,
Am Donnerstag, 15. Juni 2017, 15:23:16 CEST schrieb Frank Wang:
> From: Finley Xiao <finley.xiao@rock-chips.com>
>
> Add a efuse node in the device tree for the rk3228 SoC.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index c2a78f4..dad195e 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -314,6 +314,23 @@
> status = "disabled";
> };
>
> + efuse: efuse@11040000 {
> + compatible = "rockchip,rk322x-efuse";
was this binding included already? Simply because compatibles should
not contain placeholders, so rockchip,rk3228-efuse please - same for
the driver side.
Heiko
> + reg = <0x11040000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + clocks = <&cru PCLK_EFUSE_256>;
> + clock-names = "pclk_efuse";
> +
> + /* Data cells */
> + efuse_id: id@7 {
> + reg = <0x7 0x10>;
> + };
> + cpu_leakage: cpu_leakage@17 {
> + reg = <0x17 0x1>;
> + };
> + };
> +
> i2c0: i2c@11050000 {
> compatible = "rockchip,rk3228-i2c";
> reg = <0x11050000 0x1000>;
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
charles.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
kevan.lan-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
wmc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228
Date: Thu, 15 Jun 2017 17:10:38 +0200 [thread overview]
Message-ID: <2537345.MJmYY2BcSn@phil> (raw)
In-Reply-To: <1497511396-23308-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Frank,
Am Donnerstag, 15. Juni 2017, 15:23:16 CEST schrieb Frank Wang:
> From: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Add a efuse node in the device tree for the rk3228 SoC.
>
> Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index c2a78f4..dad195e 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -314,6 +314,23 @@
> status = "disabled";
> };
>
> + efuse: efuse@11040000 {
> + compatible = "rockchip,rk322x-efuse";
was this binding included already? Simply because compatibles should
not contain placeholders, so rockchip,rk3228-efuse please - same for
the driver side.
Heiko
> + reg = <0x11040000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + clocks = <&cru PCLK_EFUSE_256>;
> + clock-names = "pclk_efuse";
> +
> + /* Data cells */
> + efuse_id: id@7 {
> + reg = <0x7 0x10>;
> + };
> + cpu_leakage: cpu_leakage@17 {
> + reg = <0x17 0x1>;
> + };
> + };
> +
> i2c0: i2c@11050000 {
> compatible = "rockchip,rk3228-i2c";
> reg = <0x11050000 0x1000>;
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228
Date: Thu, 15 Jun 2017 17:10:38 +0200 [thread overview]
Message-ID: <2537345.MJmYY2BcSn@phil> (raw)
In-Reply-To: <1497511396-23308-1-git-send-email-frank.wang@rock-chips.com>
Hi Frank,
Am Donnerstag, 15. Juni 2017, 15:23:16 CEST schrieb Frank Wang:
> From: Finley Xiao <finley.xiao@rock-chips.com>
>
> Add a efuse node in the device tree for the rk3228 SoC.
>
> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index c2a78f4..dad195e 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -314,6 +314,23 @@
> status = "disabled";
> };
>
> + efuse: efuse at 11040000 {
> + compatible = "rockchip,rk322x-efuse";
was this binding included already? Simply because compatibles should
not contain placeholders, so rockchip,rk3228-efuse please - same for
the driver side.
Heiko
> + reg = <0x11040000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + clocks = <&cru PCLK_EFUSE_256>;
> + clock-names = "pclk_efuse";
> +
> + /* Data cells */
> + efuse_id: id at 7 {
> + reg = <0x7 0x10>;
> + };
> + cpu_leakage: cpu_leakage at 17 {
> + reg = <0x17 0x1>;
> + };
> + };
> +
> i2c0: i2c at 11050000 {
> compatible = "rockchip,rk3228-i2c";
> reg = <0x11050000 0x1000>;
>
next prev parent reply other threads:[~2017-06-15 15:11 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 7:16 [PATCH 0/6] add some device nodes support for rk322x SoC Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-15 7:16 ` [PATCH 1/6] ARM: dts: rockchip: add basic dtsi file for RK3229 SoC Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-17 18:12 ` Heiko Stuebner
2017-06-17 18:12 ` Heiko Stuebner
2017-06-19 10:34 ` Frank Wang
2017-06-19 10:34 ` Frank Wang
2017-06-19 12:30 ` Heiko Stübner
2017-06-19 12:30 ` Heiko Stübner
2017-06-20 7:13 ` Frank Wang
2017-06-20 7:13 ` Frank Wang
2017-06-20 7:13 ` Frank Wang
2017-06-20 10:48 ` Heiko Stübner
2017-06-20 10:48 ` Heiko Stübner
2017-06-20 10:48 ` Heiko Stübner
2017-06-21 4:11 ` Jacob Chen
2017-06-21 7:05 ` Huang, Tao
2017-06-21 7:29 ` Huang, Tao
2017-06-21 7:29 ` Huang, Tao
2017-06-21 7:29 ` Huang, Tao
2017-06-21 8:55 ` Heiko Stübner
2017-06-21 8:55 ` Heiko Stübner
2017-06-15 7:16 ` [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228 Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-15 7:51 ` Heiko Stübner
2017-06-15 7:51 ` Heiko Stübner
2017-06-15 7:16 ` [PATCH 3/6] ARM: dts: rockchip: fix compatible string for eMMC node of rk3228 SoC Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-15 7:16 ` [PATCH 4/6] ARM: dts: rockchip: add sdmmc and sdio nodes for " Frank Wang
2017-06-15 7:16 ` Frank Wang
2017-06-15 7:21 ` [PATCH 5/6] ARM: dts: rockchip: Add io-domain node for rk3228 Frank Wang
2017-06-15 7:21 ` Frank Wang
2017-06-15 7:23 ` [PATCH 6/6] ARM: dts: rockchip: add efuse device " Frank Wang
2017-06-15 7:23 ` Frank Wang
2017-06-15 7:23 ` Frank Wang
2017-06-15 15:10 ` Heiko Stuebner [this message]
2017-06-15 15:10 ` Heiko Stuebner
2017-06-15 15:10 ` Heiko Stuebner
2017-06-16 9:24 ` Frank Wang
2017-06-16 9:24 ` Frank Wang
2017-06-16 9:24 ` Frank Wang
2017-06-16 9:35 ` Heiko Stübner
2017-06-16 9:35 ` Heiko Stübner
2017-06-16 9:35 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2537345.MJmYY2BcSn@phil \
--to=heiko@sntech.de \
--cc=charles.chen@rock-chips.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=finley.xiao@rock-chips.com \
--cc=frank.wang@rock-chips.com \
--cc=huangtao@rock-chips.com \
--cc=kevan.lan@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wmc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.