From: Niklas Cassel <niklas.cassel@axis.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jingoo Han <jingoohan1@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>, <linux-arm-kernel@axis.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>, <nsekhar@ti.com>
Subject: Re: [PATCH 2/4] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops
Date: Mon, 20 Feb 2017 09:32:35 +0100 [thread overview]
Message-ID: <2636ef0f-78e1-b38a-5864-c53a645e7073@axis.com> (raw)
In-Reply-To: <1487251752-12478-3-git-send-email-kishon@ti.com>
Hello Kishon!
It's nice to see that you are improving the dwc framework+drivers.
pcie-artpec6.c has the same quirk as dra7xx,
see define ARTPEC6_CPU_TO_BUS_ADDR.
I could create a patch, but I guess it would make more sense
if it's part of this series.
Keep up the good work!
Regards,
Niklas
On 02/16/2017 02:29 PM, Kishon Vijay Abraham I wrote:
> Populate cpu_addr_fixup ops to extract the least 28 bits of the
> corresponding cpu address.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0984baf..07c45ec 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -88,6 +88,11 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
> writel(value, pcie->base + offset);
> }
>
> +static u64 dra7xx_pcie_cpu_addr_fixup(u64 pci_addr)
> +{
> + return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
> +}
> +
> static int dra7xx_pcie_link_up(struct dw_pcie *pci)
> {
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
> @@ -152,11 +157,6 @@ static void dra7xx_pcie_host_init(struct pcie_port *pp)
> struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
>
> - pp->io_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->mem_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg0_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg1_base &= DRA7XX_CPU_TO_BUS_ADDR;
> -
> dw_pcie_setup_rc(pp);
>
> dra7xx_pcie_establish_link(dra7xx);
> @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> }
>
> static const struct dw_pcie_ops dw_pcie_ops = {
> + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup,
> .link_up = dra7xx_pcie_link_up,
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <niklas.cassel@axis.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jingoo Han <jingoohan1@gmail.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@axis.com
Cc: Joao Pinto <Joao.Pinto@synopsys.com>, nsekhar@ti.com
Subject: Re: [PATCH 2/4] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops
Date: Mon, 20 Feb 2017 09:32:35 +0100 [thread overview]
Message-ID: <2636ef0f-78e1-b38a-5864-c53a645e7073@axis.com> (raw)
In-Reply-To: <1487251752-12478-3-git-send-email-kishon@ti.com>
Hello Kishon!
It's nice to see that you are improving the dwc framework+drivers.
pcie-artpec6.c has the same quirk as dra7xx,
see define ARTPEC6_CPU_TO_BUS_ADDR.
I could create a patch, but I guess it would make more sense
if it's part of this series.
Keep up the good work!
Regards,
Niklas
On 02/16/2017 02:29 PM, Kishon Vijay Abraham I wrote:
> Populate cpu_addr_fixup ops to extract the least 28 bits of the
> corresponding cpu address.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0984baf..07c45ec 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -88,6 +88,11 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
> writel(value, pcie->base + offset);
> }
>
> +static u64 dra7xx_pcie_cpu_addr_fixup(u64 pci_addr)
> +{
> + return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
> +}
> +
> static int dra7xx_pcie_link_up(struct dw_pcie *pci)
> {
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
> @@ -152,11 +157,6 @@ static void dra7xx_pcie_host_init(struct pcie_port *pp)
> struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
>
> - pp->io_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->mem_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg0_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg1_base &= DRA7XX_CPU_TO_BUS_ADDR;
> -
> dw_pcie_setup_rc(pp);
>
> dra7xx_pcie_establish_link(dra7xx);
> @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> }
>
> static const struct dw_pcie_ops dw_pcie_ops = {
> + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup,
> .link_up = dra7xx_pcie_link_up,
> };
>
WARNING: multiple messages have this Message-ID (diff)
From: niklas.cassel@axis.com (Niklas Cassel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops
Date: Mon, 20 Feb 2017 09:32:35 +0100 [thread overview]
Message-ID: <2636ef0f-78e1-b38a-5864-c53a645e7073@axis.com> (raw)
In-Reply-To: <1487251752-12478-3-git-send-email-kishon@ti.com>
Hello Kishon!
It's nice to see that you are improving the dwc framework+drivers.
pcie-artpec6.c has the same quirk as dra7xx,
see define ARTPEC6_CPU_TO_BUS_ADDR.
I could create a patch, but I guess it would make more sense
if it's part of this series.
Keep up the good work!
Regards,
Niklas
On 02/16/2017 02:29 PM, Kishon Vijay Abraham I wrote:
> Populate cpu_addr_fixup ops to extract the least 28 bits of the
> corresponding cpu address.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/dwc/pci-dra7xx.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0984baf..07c45ec 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -88,6 +88,11 @@ static inline void dra7xx_pcie_writel(struct dra7xx_pcie *pcie, u32 offset,
> writel(value, pcie->base + offset);
> }
>
> +static u64 dra7xx_pcie_cpu_addr_fixup(u64 pci_addr)
> +{
> + return pci_addr & DRA7XX_CPU_TO_BUS_ADDR;
> +}
> +
> static int dra7xx_pcie_link_up(struct dw_pcie *pci)
> {
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
> @@ -152,11 +157,6 @@ static void dra7xx_pcie_host_init(struct pcie_port *pp)
> struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
> struct dra7xx_pcie *dra7xx = to_dra7xx_pcie(pci);
>
> - pp->io_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->mem_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg0_base &= DRA7XX_CPU_TO_BUS_ADDR;
> - pp->cfg1_base &= DRA7XX_CPU_TO_BUS_ADDR;
> -
> dw_pcie_setup_rc(pp);
>
> dra7xx_pcie_establish_link(dra7xx);
> @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> }
>
> static const struct dw_pcie_ops dw_pcie_ops = {
> + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup,
> .link_up = dra7xx_pcie_link_up,
> };
>
next prev parent reply other threads:[~2017-02-20 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 13:29 [PATCH 0/4] PCI: dwc: cleanup designware driver Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` [PATCH 1/4] PCI: dwc: designware: Add new *ops* for cpu addr fixup Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` [PATCH 2/4] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-20 8:32 ` Niklas Cassel [this message]
2017-02-20 8:32 ` Niklas Cassel
2017-02-20 8:32 ` Niklas Cassel
2017-02-16 13:29 ` [PATCH 3/4] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` [PATCH 4/4] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
2017-02-16 13:29 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2636ef0f-78e1-b38a-5864-c53a645e7073@axis.com \
--to=niklas.cassel@axis.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.