Re: [PATCH v4 0/7] Add support to the mmsys driver to be a reset controller

From: Matthias Brugger <matthias.bgg@gmail.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	linux-kernel@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org, eizan@chromium.org,
	kernel@collabora.com, drinkcat@chromium.org,
	jitao.shi@mediatek.com, chunkuang.hu@kernel.org,
	hsinyi@chromium.org, Crystal Guo <crystal.guo@mediatek.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Fabien Parent <fparent@baylibre.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 0/7] Add support to the mmsys driver to be a reset controller
Date: Fri, 8 Oct 2021 15:16:43 +0200	[thread overview]
Message-ID: <266143bd-6135-adf6-8a80-537f9d6ea3ff@gmail.com> (raw)
In-Reply-To: <20210930083150.3317003-1-enric.balletbo@collabora.com>

On 30/09/2021 10:31, Enric Balletbo i Serra wrote:
> Dear all,
> 
> The following patchset is a reimplementation of the patch sent by Jitao
> Shi [1] some time ago. As suggested by Chun-Kuang Hu, this time the
> reset is done using the reset API, where the mmsys driver is the reset
> controller and the mtk_dsi driver is the reset consumer.
> 
> Note that the first patch is kind of unrelated change, it's just a
> cleanup but is needed if you want to apply all the following patches
> cleanly.
> 
> This patchset is important in order to have the DSI panel working on some
> kukui MT8183 Chromebooks (i.e Lenovo IdeaPad Duet). Without it, you just
> get a black screen.
> 

Patch 1-5 pushed to v5.15-next/dts64
Patch 6-7 pushed to v5.15-next/soc

Thanks!
Matthias

> Best regards,
>    Enric
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20210420132614.150242-4-jitao.shi@mediatek.com/
> 
> 
> Changes in v4:
> - Remove unnused variable as pointed by Hsin-Yi
> 
> Changes in v3:
> - Based on top of the patch that converts mmsys to schema
> - Fix typo in the commit description
> 
> Changes in v2:
> - Fix build test ERROR Reported-by: kernel test robot <lkp@intel.com>
> - Added a new patch to describe the dsi reset optional property.
> 
> Enric Balletbo i Serra (7):
>    arm64: dts: mediatek: Move reset controller constants into common
>      location
>    dt-bindings: mediatek: Add #reset-cells to mmsys system controller
>    dt-bindings: display: mediatek: add dsi reset optional property
>    arm64: dts: mt8173: Add the mmsys reset bit to reset the dsi0
>    arm64: dts: mt8183: Add the mmsys reset bit to reset the dsi0
>    soc: mediatek: mmsys: Add reset controller support
>    drm/mediatek: mtk_dsi: Reset the dsi0 hardware
> 
>   .../bindings/arm/mediatek/mediatek,mmsys.yaml |  4 ++
>   .../display/mediatek/mediatek,dsi.txt         |  6 ++
>   arch/arm64/boot/dts/mediatek/mt8173.dtsi      |  2 +
>   arch/arm64/boot/dts/mediatek/mt8183.dtsi      |  5 +-
>   drivers/gpu/drm/mediatek/mtk_dsi.c            |  5 +-
>   drivers/soc/mediatek/mtk-mmsys.c              | 68 +++++++++++++++++++
>   drivers/soc/mediatek/mtk-mmsys.h              |  2 +
>   drivers/watchdog/mtk_wdt.c                    |  6 +-
>   .../mt2712-resets.h                           |  0
>   include/dt-bindings/reset/mt8173-resets.h     |  2 +
>   .../mt8183-resets.h                           |  3 +
>   .../mt8192-resets.h                           |  0
>   12 files changed, 97 insertions(+), 6 deletions(-)
>   rename include/dt-bindings/{reset-controller => reset}/mt2712-resets.h (100%)
>   rename include/dt-bindings/{reset-controller => reset}/mt8183-resets.h (98%)
>   rename include/dt-bindings/{reset-controller => reset}/mt8192-resets.h (100%)
> 