From: Marc Zyngier <maz@kernel.org>
To: Keqian Zhu <zhukeqian1@huawei.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Steven Price <steven.price@arm.com>,
Andrew Jones <drjones@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: Simplify and fix count reader code logic
Date: Mon, 17 Aug 2020 13:52:11 +0100 [thread overview]
Message-ID: <267c5f9151c39fd2dcd0ce0b09d96545@kernel.org> (raw)
In-Reply-To: <20200817122415.6568-2-zhukeqian1@huawei.com>
On 2020-08-17 13:24, Keqian Zhu wrote:
> In commit 0ea415390cd3 (clocksource/arm_arch_timer: Use
> arch_timer_read_counter
> to access stable counters), we separate stable and normal count reader.
> Actually
> the stable reader can correctly lead us to normal reader if we has no
> workaround.
Resulting in an unnecessary overhead on non-broken systems that can run
without CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND. Not happening.
> Besides, in erratum_set_next_event_tval_generic(), we use normal
> reader, it is
> obviously wrong, so just revert this commit to solve this problem by
> the way.
If you want to fix something, post a patch that does exactly that.
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Keqian Zhu <zhukeqian1@huawei.com>
Cc: kvm@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: Simplify and fix count reader code logic
Date: Mon, 17 Aug 2020 13:52:11 +0100 [thread overview]
Message-ID: <267c5f9151c39fd2dcd0ce0b09d96545@kernel.org> (raw)
In-Reply-To: <20200817122415.6568-2-zhukeqian1@huawei.com>
On 2020-08-17 13:24, Keqian Zhu wrote:
> In commit 0ea415390cd3 (clocksource/arm_arch_timer: Use
> arch_timer_read_counter
> to access stable counters), we separate stable and normal count reader.
> Actually
> the stable reader can correctly lead us to normal reader if we has no
> workaround.
Resulting in an unnecessary overhead on non-broken systems that can run
without CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND. Not happening.
> Besides, in erratum_set_next_event_tval_generic(), we use normal
> reader, it is
> obviously wrong, so just revert this commit to solve this problem by
> the way.
If you want to fix something, post a patch that does exactly that.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Keqian Zhu <zhukeqian1@huawei.com>
Cc: Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>,
James Morse <james.morse@arm.com>,
wanghaibin.wang@huawei.com, Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clocksource: arm_arch_timer: Simplify and fix count reader code logic
Date: Mon, 17 Aug 2020 13:52:11 +0100 [thread overview]
Message-ID: <267c5f9151c39fd2dcd0ce0b09d96545@kernel.org> (raw)
In-Reply-To: <20200817122415.6568-2-zhukeqian1@huawei.com>
On 2020-08-17 13:24, Keqian Zhu wrote:
> In commit 0ea415390cd3 (clocksource/arm_arch_timer: Use
> arch_timer_read_counter
> to access stable counters), we separate stable and normal count reader.
> Actually
> the stable reader can correctly lead us to normal reader if we has no
> workaround.
Resulting in an unnecessary overhead on non-broken systems that can run
without CONFIG_ARM_ARCH_TIMER_OOL_WORKAROUND. Not happening.
> Besides, in erratum_set_next_event_tval_generic(), we use normal
> reader, it is
> obviously wrong, so just revert this commit to solve this problem by
> the way.
If you want to fix something, post a patch that does exactly that.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-17 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 12:24 [PATCH 0/2] clocksource: arm_arch_timer: Some fixes and code adjustment Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:24 ` [PATCH 1/2] clocksource: arm_arch_timer: Simplify and fix count reader code logic Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:52 ` Marc Zyngier [this message]
2020-08-17 12:52 ` Marc Zyngier
2020-08-17 12:52 ` Marc Zyngier
2020-08-18 1:40 ` zhukeqian
2020-08-18 1:40 ` zhukeqian
2020-08-18 1:40 ` zhukeqian
2020-08-17 12:24 ` [PATCH 2/2] clocksource: arm_arch_timer: Correct fault programming of CNTKCTL_EL1.EVNTI Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:24 ` Keqian Zhu
2020-08-17 12:56 ` Marc Zyngier
2020-08-17 12:56 ` Marc Zyngier
2020-08-17 12:56 ` Marc Zyngier
2020-08-18 1:42 ` zhukeqian
2020-08-18 1:42 ` zhukeqian
2020-08-18 1:42 ` zhukeqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267c5f9151c39fd2dcd0ce0b09d96545@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.