From: Keerthy <j-keerthy@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linus.walleij@linaro.org>, <grygorii.strashko@ti.com>,
<t-kristo@ti.com>, <Russ.Dill@ti.com>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<ssantosh@kernel.org>, <haojian.zhuang@linaro.org>,
<linux-arm-kernel@lists.infradead.org>, <d-gerlach@ti.com>,
Russ Dill <Russ.Dill@gmail.com>
Subject: Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.
Date: Fri, 13 Apr 2018 11:46:04 +0530 [thread overview]
Message-ID: <26b80d50-efe1-196a-85b0-4ab22f9bda1c@ti.com> (raw)
In-Reply-To: <20180412141639.GV5700@atomide.com>
On Thursday 12 April 2018 07:46 PM, Tony Lindgren wrote:
> Hi,
>
> * Keerthy <j-keerthy@ti.com> [180412 03:56]:
>> From: Russ Dill <Russ.Dill@gmail.com>
>>
>> This adds a pair of context save/restore functions to save/restore the
>> state of a set of pinctrl registers. This simplifies some of the AM33XX
>> PM code as some of the pinctrl registers are lost when the per power
>> domain loses power. The pincrtl code can perform the necessary
>> save/restore.
>
> So where's the patch adding callers to this code?
This series was to get all the additional save/restores needed for the
rtc+ddr mode. Caller patch is in the main patch that implements that
mode that i will be posting once the ground is set.
Based on enable_off_mode being set this function was called only for
rtc+ddr mode.
>
> If this cannot be done from regular driver suspend/resume calls,
> this probably should be done from cpu_pm notifiers CPU_PM_ENTER and
> CPU_PM_EXIT. We should also do the same for GPIO BTW.
I will look into that. Thanks for suggestion.
>
> BTW, the subject line is wrong here, it should be "pinctrl" :)
Oops yes that should be pinctrl.
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <j-keerthy@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linus.walleij@linaro.org, grygorii.strashko@ti.com,
t-kristo@ti.com, Russ.Dill@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, ssantosh@kernel.org,
haojian.zhuang@linaro.org, linux-arm-kernel@lists.infradead.org,
d-gerlach@ti.com, Russ Dill <Russ.Dill@gmail.com>
Subject: Re: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.
Date: Fri, 13 Apr 2018 11:46:04 +0530 [thread overview]
Message-ID: <26b80d50-efe1-196a-85b0-4ab22f9bda1c@ti.com> (raw)
In-Reply-To: <20180412141639.GV5700@atomide.com>
On Thursday 12 April 2018 07:46 PM, Tony Lindgren wrote:
> Hi,
>
> * Keerthy <j-keerthy@ti.com> [180412 03:56]:
>> From: Russ Dill <Russ.Dill@gmail.com>
>>
>> This adds a pair of context save/restore functions to save/restore the
>> state of a set of pinctrl registers. This simplifies some of the AM33XX
>> PM code as some of the pinctrl registers are lost when the per power
>> domain loses power. The pincrtl code can perform the necessary
>> save/restore.
>
> So where's the patch adding callers to this code?
This series was to get all the additional save/restores needed for the
rtc+ddr mode. Caller patch is in the main patch that implements that
mode that i will be posting once the ground is set.
Based on enable_off_mode being set this function was called only for
rtc+ddr mode.
>
> If this cannot be done from regular driver suspend/resume calls,
> this probably should be done from cpu_pm notifiers CPU_PM_ENTER and
> CPU_PM_EXIT. We should also do the same for GPIO BTW.
I will look into that. Thanks for suggestion.
>
> BTW, the subject line is wrong here, it should be "pinctrl" :)
Oops yes that should be pinctrl.
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: j-keerthy@ti.com (Keerthy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context.
Date: Fri, 13 Apr 2018 11:46:04 +0530 [thread overview]
Message-ID: <26b80d50-efe1-196a-85b0-4ab22f9bda1c@ti.com> (raw)
In-Reply-To: <20180412141639.GV5700@atomide.com>
On Thursday 12 April 2018 07:46 PM, Tony Lindgren wrote:
> Hi,
>
> * Keerthy <j-keerthy@ti.com> [180412 03:56]:
>> From: Russ Dill <Russ.Dill@gmail.com>
>>
>> This adds a pair of context save/restore functions to save/restore the
>> state of a set of pinctrl registers. This simplifies some of the AM33XX
>> PM code as some of the pinctrl registers are lost when the per power
>> domain loses power. The pincrtl code can perform the necessary
>> save/restore.
>
> So where's the patch adding callers to this code?
This series was to get all the additional save/restores needed for the
rtc+ddr mode. Caller patch is in the main patch that implements that
mode that i will be posting once the ground is set.
Based on enable_off_mode being set this function was called only for
rtc+ddr mode.
>
> If this cannot be done from regular driver suspend/resume calls,
> this probably should be done from cpu_pm notifiers CPU_PM_ENTER and
> CPU_PM_EXIT. We should also do the same for GPIO BTW.
I will look into that. Thanks for suggestion.
>
> BTW, the subject line is wrong here, it should be "pinctrl" :)
Oops yes that should be pinctrl.
>
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2018-04-13 6:16 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 3:53 [PATCH 00/14] arm: OMAP: AM437X: Save restores patches for rtc mode with DDR In self-refresh Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 16:44 ` santosh.shilimkar
2018-04-12 16:44 ` santosh.shilimkar at oracle.com
2018-04-12 16:44 ` santosh.shilimkar
2018-04-16 10:20 ` Keerthy
2018-04-16 10:20 ` Keerthy
2018-04-16 10:20 ` Keerthy
2018-04-16 10:29 ` Keerthy
2018-04-16 10:29 ` Keerthy
2018-04-16 10:29 ` Keerthy
2018-05-23 8:47 ` Keerthy
2018-05-23 8:47 ` Keerthy
2018-05-23 8:47 ` Keerthy
2018-05-23 16:42 ` Santosh Shilimkar
2018-05-23 16:42 ` Santosh Shilimkar
2018-04-12 3:53 ` [PATCH 02/14] ARM: OMAP2: Add functions to save and restore clockdomain context en-masse Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 03/14] ARM: OMAP2+: omap_hwmod: Introduce HWMOD_NEEDS_REIDLE Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:34 ` Tony Lindgren
2018-04-12 14:34 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 04/14] ARM: OMAP2: Add functions to save and restore omap hwmod context en-masse Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 05/14] ARM: OMAP2: Add functions to save and restore powerdomain context Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:37 ` Tony Lindgren
2018-04-12 14:37 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 06/14] ARM: AM33XX: Add functions to save/restore am33xx control registers Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 07/14] ARM: AM43XX: Add functions to save/restore am43xx " Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 08/14] ARM: OMAP2: Add functions to save and restore pinctrl context Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:16 ` Tony Lindgren
2018-04-12 14:16 ` Tony Lindgren
2018-04-13 6:16 ` Keerthy [this message]
2018-04-13 6:16 ` Keerthy
2018-04-13 6:16 ` Keerthy
2018-04-12 3:53 ` [PATCH 09/14] ARM: OMAP2: Drop the concept of certain power domains not being able to lose context Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 10/14] gpio: omap: Drop the concept of gpio banks " Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:22 ` Tony Lindgren
2018-04-12 14:22 ` Tony Lindgren
2018-04-12 20:10 ` Grygorii Strashko
2018-04-12 20:10 ` Grygorii Strashko
2018-04-12 20:10 ` Grygorii Strashko
2018-04-12 3:53 ` [PATCH 11/14] gpio: omap: Restore power_mode configuration at resume time Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:39 ` Tony Lindgren
2018-04-12 14:39 ` Tony Lindgren
2018-04-12 20:02 ` Grygorii Strashko
2018-04-12 20:02 ` Grygorii Strashko
2018-04-12 20:02 ` Grygorii Strashko
2018-04-12 3:53 ` [PATCH 12/14] OMAP: CLK: CLKSRC: Add suspend resume hooks Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 14:27 ` Tony Lindgren
2018-04-12 14:27 ` Tony Lindgren
2018-05-22 7:57 ` Keerthy
2018-05-22 7:57 ` Keerthy
2018-05-22 7:57 ` Keerthy
2018-05-22 13:39 ` Tony Lindgren
2018-05-22 13:39 ` Tony Lindgren
2018-04-12 3:53 ` [PATCH 13/14] ARM: hwmod: RTC: Don't assume lock/unlock will be called with irq enabled Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` [PATCH 14/14] ARM: OMAP2+: prm44xx: Introduce context save/restore for am43 PRCM IO Keerthy
2018-04-12 3:53 ` Keerthy
2018-04-12 3:53 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26b80d50-efe1-196a-85b0-4ab22f9bda1c@ti.com \
--to=j-keerthy@ti.com \
--cc=Russ.Dill@gmail.com \
--cc=Russ.Dill@ti.com \
--cc=d-gerlach@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.