Re: [PATCH v6 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.li@nxp.com>, Rob Herring <robh@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers
Date: Fri, 8 Mar 2024 22:15:45 +0100	[thread overview]
Message-ID: <2749c144-4606-49c5-a9e1-3b9547e5978a@linaro.org> (raw)
In-Reply-To: <ZetmXE4YooDYJgSM@lizhi-Precision-Tower-5810>

On 08/03/2024 20:26, Frank Li wrote:
> On Fri, Mar 08, 2024 at 02:11:34PM -0500, Frank Li wrote:
>> On Fri, Mar 08, 2024 at 02:01:29PM -0500, Frank Li wrote:
>>> On Fri, Mar 08, 2024 at 12:11:03PM -0600, Rob Herring wrote:
>>>> On Fri, Mar 08, 2024 at 10:30:51AM -0500, Frank Li wrote:
>>>>> fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
>>>>> have 1 interrupt.
>>>>>
>>>>> Increase max interrupt number to 2 and add restriction for platforms except
>>>>> i.MX8QXP and i.MX8QM.
>>>>>
>>>>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>>> ---
>>>>>  .../devicetree/bindings/sound/fsl,spdif.yaml        | 21 ++++++++++++++++++++-
>>>>>  1 file changed, 20 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
>>>>> index 56f8c0c8afdea..a242f68f99f18 100644
>>>>> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
>>>>> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
>>>>> @@ -31,7 +31,11 @@ properties:
>>>>>      maxItems: 1
>>>>>  
>>>>>    interrupts:
>>>>> -    maxItems: 1
>>>>> +    minItems: 1
>>>>> +    maxItems: 2
>>>>> +    items:
>>>>> +      - description: Combined or receive interrupt
>>>>> +      - description: Transmit interrupt
>>>>
>>>> Test your patches please because this will have warnings. Or, you can 
>>>> put in *exactly* what I provided because this is not it.
>>>>
>>>> If you continue to just toss crap at us at the rate you are, the DT 
>>>> maintainers will either just start ignoring your patches or require some 
>>>> trusted review by another NXP colleague first (offhand, not sure who 
>>>> that would be which is part of the problem).
>>>
>>> Sorry, I run wrong command to check another dtb file. So have not catch
>>> this problem.
>>
>> Strange when I run second time, spdif warning disappeared.
>>
>> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  CHECK_DTBS=y freescale/imx8dxl-evk.dtb
>>   DTC_CHK arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: /: fixedregulator@101: 'anyOf' conditional failed, one must be fixed:
>> 	'reg' is a required property
>> 	'ranges' is a required property
>> 	from schema $id: http://devicetree.org/schemas/root-node.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: bus@34000000: clock-cm40-ipg: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[132000000]], 'clock-output-names': ['cm40_ipg_clk'], 'phandle': [[15]]} should not be valid under {'type': 'object'}
>> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: intmux@37400000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/interrupt-controller/fsl,intmux.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@591f0000: 'clocks' is a required property
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@591f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@599f0000: 'clocks' is a required property
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: serial@5a070000: Unevaluated properties are not allowed ('resets' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/serial/fsl-lpuart.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a1f0000: 'clocks' is a required property
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a1f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a9f0000: 'clocks' is a required property
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-controller@5a9f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,edma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: bus@5b000000: clock-conn-bch: {'compatible': ['fixed-clock'], '#clock-cells': [[0]], 'clock-frequency': [[400000000]], 'clock-output-names': ['conn_bch_clk']} should not be valid under {'type': 'object'}
>> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-apbh@5b810000: $nodename:0: 'dma-apbh@5b810000' does not match '^dma-controller(@.*)?$'
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
>> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: dma-apbh@5b810000: 'clock-names', 'interrupt-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
>>
> 
> I figured out what's happen. CHECK_DTB will check binding doc except
> example part. So I skip run dt_binding_check when I have not touch example
> part in dt-binding doc.
> 
> The problem is
> step 1. run make CHECK_DTB=y freescale/imx8ulp-evk.dtb
>         Then I get some sai error, I found use wrong 8ulp-evk.dtb
> 
> step 2. run make CHECK_DTBS=y freescale/imx8dxl-evk.dtb
>         Then tools not check dt_binding file again even there are warning.
> 
> Do you have option let CHECK_DTBS to force check binding doc every time.

CHECK_DTB is for checking dtbs, not binding. You must run
dt_bindings_check, as asked by every damn document and guide.

Best regards,
Krzysztof