Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory

From: David Hildenbrand <david@redhat.com>
To: teawater <teawaterz@linux.alibaba.com>
Cc: David Hildenbrand <david@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	virtio-dev@lists.oasis-open.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Sebastien Boeuf <sebastien.boeuf@intel.com>,
	Samuel Ortiz <samuel.ortiz@intel.com>,
	Robert Bradford <robert.bradford@intel.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	Alexander Potapenko <glider@google.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Anthony Yznaga <anthony.yznaga@oracle.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Young <dyoung@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Juergen Gross <jgross@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Len Brown <lenb@kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Oscar Salvador <osalvador@suse.com>,
	Oscar Salvador <osalvador@suse.de>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Pavel Tatashin <pavel.tatashin@microsoft.com>,
	Pingfan Liu <kernelfans@gmail.com>, Qian Cai <cai@lca.pw>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Wei Yang <richard.weiyang@gmail.com>
Subject: Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory
Date: Tue, 24 Dec 2019 10:28:20 +0100	[thread overview]
Message-ID: <2828152B-D0EB-4802-A304-4A90CA5C4B6C@redhat.com> (raw)
In-Reply-To: <91ED8152-61FC-4E87-9F7B-44CD05C77279@linux.alibaba.com>

> Am 24.12.2019 um 08:04 schrieb teawater <teawaterz@linux.alibaba.com>:
> 
> Hi David,
> 
> Thanks for your work.
> 
> I Got following build fail if X86_64_ACPI_NUMA is n with rfc3 and rfc4:
> make -j8 bzImage
>  GEN     Makefile
>  DESCEND  objtool
>  CALL    /home/teawater/kernel/linux-upstream3/scripts/atomic/check-atomics.sh
>  CALL    /home/teawater/kernel/linux-upstream3/scripts/checksyscalls.sh
>  CHK     include/generated/compile.h
>  CC      drivers/virtio/virtio_mem.o
> /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c: In function ‘virtio_mem_translate_node_id’:
> /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c:478:10: error: implicit declaration of function ‘pxm_to_node’ [-Werror=implicit-function-declaration]
>   node = pxm_to_node(node_id);
>          ^~~~~~~~~~~
> cc1: some warnings being treated as errors
> /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:265: recipe for target 'drivers/virtio/virtio_mem.o' failed
> make[3]: *** [drivers/virtio/virtio_mem.o] Error 1
> /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:503: recipe for target 'drivers/virtio' failed
> make[2]: *** [drivers/virtio] Error 2
> /home/teawater/kernel/linux-upstream3/Makefile:1649: recipe for target 'drivers' failed
> make[1]: *** [drivers] Error 2
> /home/teawater/kernel/linux-upstream3/Makefile:179: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
> 

Thanks Hui,

So it has to be wrapped in an ifdef, thanks!

Cheers!