From: Stefan Wahren <stefan.wahren@i2se.com> To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." <bcm-kernel-feedback-list@broadcom.com>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Geert Uytterhoeven <geert+renesas@glider.be>, Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/4] pinctrl: bcm2835: Match BCM7211 compatible string Date: Fri, 29 May 2020 15:11:18 +0200 [thread overview] Message-ID: <291609c0-f1ec-2626-8bfa-cf25a9e45365@i2se.com> (raw) In-Reply-To: <20200528192112.26123-4-f.fainelli@gmail.com> Hi Florian, Am 28.05.20 um 21:21 schrieb Florian Fainelli: > The BCM7211 SoC uses the same pinconf_ops as the ones defined for the > BCM2711 SoC, match the compatible string and use the correct set of > options. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 06bd2b70af3c..e8ad1824c6b3 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -1137,6 +1137,10 @@ static const struct of_device_id bcm2835_pinctrl_match[] = { > .compatible = "brcm,bcm2711-gpio", > .data = &bcm2711_plat_data, > }, > + { > + .compatible = "brcm,bcm7211-gpio", > + .data = &bcm2711_pinconf_ops, this doesn't look safe. Maybe bcm2711_plat_data? Looks like the original patch series based on a older version. Please double check this still applies since the introduction of 58 GPIO support for BCM2711. Regards Stefan > + }, > {} > }; >
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com> To: Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org Cc: "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Scott Branden <sbranden@broadcom.com>, Ray Jui <rjui@broadcom.com>, Linus Walleij <linus.walleij@linaro.org>, Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>, "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." <bcm-kernel-feedback-list@broadcom.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@lists.infradead.org>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: Re: [PATCH 3/4] pinctrl: bcm2835: Match BCM7211 compatible string Date: Fri, 29 May 2020 15:11:18 +0200 [thread overview] Message-ID: <291609c0-f1ec-2626-8bfa-cf25a9e45365@i2se.com> (raw) In-Reply-To: <20200528192112.26123-4-f.fainelli@gmail.com> Hi Florian, Am 28.05.20 um 21:21 schrieb Florian Fainelli: > The BCM7211 SoC uses the same pinconf_ops as the ones defined for the > BCM2711 SoC, match the compatible string and use the correct set of > options. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > index 06bd2b70af3c..e8ad1824c6b3 100644 > --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c > +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c > @@ -1137,6 +1137,10 @@ static const struct of_device_id bcm2835_pinctrl_match[] = { > .compatible = "brcm,bcm2711-gpio", > .data = &bcm2711_plat_data, > }, > + { > + .compatible = "brcm,bcm7211-gpio", > + .data = &bcm2711_pinconf_ops, this doesn't look safe. Maybe bcm2711_plat_data? Looks like the original patch series based on a older version. Please double check this still applies since the introduction of 58 GPIO support for BCM2711. Regards Stefan > + }, > {} > }; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-29 13:11 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 19:21 [PATCH 0/4] pinctrl: bcm2835: Support for wake-up interrupts Florian Fainelli 2020-05-28 19:21 ` Florian Fainelli 2020-05-28 19:21 ` [PATCH 1/4] dt-bindings: pinctrl: Document 7211 compatible for brcm,bcm2835-gpio.txt Florian Fainelli 2020-05-28 19:21 ` [PATCH 1/4] dt-bindings: pinctrl: Document 7211 compatible for brcm, bcm2835-gpio.txt Florian Fainelli 2020-05-29 19:32 ` Rob Herring 2020-05-29 19:32 ` Rob Herring 2020-05-28 19:21 ` [PATCH 2/4] dt-bindings: pinctrl: Document optional BCM7211 wake-up interrupts Florian Fainelli 2020-05-28 19:21 ` Florian Fainelli 2020-05-29 19:33 ` Rob Herring 2020-05-29 19:33 ` Rob Herring 2020-05-29 19:36 ` Florian Fainelli 2020-05-29 19:36 ` Florian Fainelli 2020-05-28 19:21 ` [PATCH 3/4] pinctrl: bcm2835: Match BCM7211 compatible string Florian Fainelli 2020-05-28 19:21 ` Florian Fainelli 2020-05-29 13:11 ` Stefan Wahren [this message] 2020-05-29 13:11 ` Stefan Wahren 2020-05-29 15:44 ` Florian Fainelli 2020-05-29 15:44 ` Florian Fainelli 2020-05-28 19:21 ` [PATCH 4/4] pinctrl: bcm2835: Add support for wake-up interrupts Florian Fainelli 2020-05-28 19:21 ` Florian Fainelli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=291609c0-f1ec-2626-8bfa-cf25a9e45365@i2se.com \ --to=stefan.wahren@i2se.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=geert+renesas@glider.be \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=matti.vaittinen@fi.rohmeurope.com \ --cc=nsaenzjulienne@suse.de \ --cc=rjui@broadcom.com \ --cc=robh+dt@kernel.org \ --cc=sbranden@broadcom.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.