From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Addy Ke <addy.ke@rock-chips.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Seungwon Jeon <tgih.jun@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sonny Rao <sonnyrao@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Bump SD card pin drive strength up on rk3288-evb
Date: Sun, 21 Dec 2014 15:04:13 +0100 [thread overview]
Message-ID: <2971473.Y1akaDeraL@phil> (raw)
In-Reply-To: <1418244929-8254-1-git-send-email-dianders@chromium.org>
Am Mittwoch, 10. Dezember 2014, 12:55:29 schrieb Doug Anderson:
> It seems that ever since (536f6b9 mmc: dw_mmc: Reset DMA before
> enabling IDMAC) landed upstream that SD cards have been very unhappy
> on rk3288-evb. They were a little unhappy before that change, but
> after that change they're REALLY unhappy.
>
> It turns out that the above fix happens to fix a corruption when
> reading card information during probe time. Without the fix we didn't
> detect that high speed SD cards could actually support high speed.
> With the fix we suddenly detect that they're high speed and we try to
> use them at 50MHz. That doesn't work so well on EVB with the default
> drive strength (maybe because there are two physical SD card slots
> hooked up to the same pin?).
>
> Fix the problem by bumping up the drive strength of the sdmmc lines.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Fixes: 536f6b91d21b ("mmc: dw_mmc: Reset DMA before enabling IDMAC")
applied to my 3.19 dts-fixes branch
(after a slight modification of the subject: please use "ARM: dts: rockchip:")
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Jaehoon Chung
<jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Seungwon Jeon <tgih.jun-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Sonny Rao <sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: Bump SD card pin drive strength up on rk3288-evb
Date: Sun, 21 Dec 2014 15:04:13 +0100 [thread overview]
Message-ID: <2971473.Y1akaDeraL@phil> (raw)
In-Reply-To: <1418244929-8254-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Am Mittwoch, 10. Dezember 2014, 12:55:29 schrieb Doug Anderson:
> It seems that ever since (536f6b9 mmc: dw_mmc: Reset DMA before
> enabling IDMAC) landed upstream that SD cards have been very unhappy
> on rk3288-evb. They were a little unhappy before that change, but
> after that change they're REALLY unhappy.
>
> It turns out that the above fix happens to fix a corruption when
> reading card information during probe time. Without the fix we didn't
> detect that high speed SD cards could actually support high speed.
> With the fix we suddenly detect that they're high speed and we try to
> use them at 50MHz. That doesn't work so well on EVB with the default
> drive strength (maybe because there are two physical SD card slots
> hooked up to the same pin?).
>
> Fix the problem by bumping up the drive strength of the sdmmc lines.
>
> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Fixes: 536f6b91d21b ("mmc: dw_mmc: Reset DMA before enabling IDMAC")
applied to my 3.19 dts-fixes branch
(after a slight modification of the subject: please use "ARM: dts: rockchip:")
Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Bump SD card pin drive strength up on rk3288-evb
Date: Sun, 21 Dec 2014 15:04:13 +0100 [thread overview]
Message-ID: <2971473.Y1akaDeraL@phil> (raw)
In-Reply-To: <1418244929-8254-1-git-send-email-dianders@chromium.org>
Am Mittwoch, 10. Dezember 2014, 12:55:29 schrieb Doug Anderson:
> It seems that ever since (536f6b9 mmc: dw_mmc: Reset DMA before
> enabling IDMAC) landed upstream that SD cards have been very unhappy
> on rk3288-evb. They were a little unhappy before that change, but
> after that change they're REALLY unhappy.
>
> It turns out that the above fix happens to fix a corruption when
> reading card information during probe time. Without the fix we didn't
> detect that high speed SD cards could actually support high speed.
> With the fix we suddenly detect that they're high speed and we try to
> use them at 50MHz. That doesn't work so well on EVB with the default
> drive strength (maybe because there are two physical SD card slots
> hooked up to the same pin?).
>
> Fix the problem by bumping up the drive strength of the sdmmc lines.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Fixes: 536f6b91d21b ("mmc: dw_mmc: Reset DMA before enabling IDMAC")
applied to my 3.19 dts-fixes branch
(after a slight modification of the subject: please use "ARM: dts: rockchip:")
Heiko
next prev parent reply other threads:[~2014-12-21 14:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 20:55 [PATCH] ARM: dts: Bump SD card pin drive strength up on rk3288-evb Doug Anderson
2014-12-10 20:55 ` Doug Anderson
2014-12-10 20:55 ` Doug Anderson
2014-12-21 14:04 ` Heiko Stübner [this message]
2014-12-21 14:04 ` Heiko Stübner
2014-12-21 14:04 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2971473.Y1akaDeraL@phil \
--to=heiko@sntech.de \
--cc=abrestic@chromium.org \
--cc=addy.ke@rock-chips.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.