All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pedanekar, Hemant" <hemantp@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Hilman, Kevin" <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: RE: [PATCH 3/3] TI814X: Create board support and enable build for TI8148 EVM
Date: Fri, 19 Aug 2011 09:57:18 +0530	[thread overview]
Message-ID: <2A3DCF3DA181AD40BDE86A3150B27B6B03ABD26D8D@dbde02.ent.ti.com> (raw)
In-Reply-To: <20110815151509.GT12348@atomide.com>

Tony Lindgren wrote on Monday, August 15, 2011 8:45 PM:

> * Hemant Pedanekar <hemantp@ti.com> [110804 20:39]:
>> This patch adds minimal support and build configuration for TI8148 EVM.
>> Also adds support for low level debugging on UART1 console on the EVM. ...
> 
> 
>> +MACHINE_START(TI8148EVM, "ti8148evm")
>> +	/* Maintainer: Texas Instruments */
>> +	.boot_params	= 0x80000100,
>> +	.map_io		= ti8148_evm_map_io,
>> +	.init_early	= ti8148_init_early,
>> +	.init_irq	= ti81xx_init_irq,
>> +	.timer		= &omap3_timer,
>> +	.init_machine	= ti8148_evm_init,
>> +MACHINE_END
> 
> Please just combine this with board-ti8168evm.c by adding the MACHINE_START
> there. It seems the files are identical otherwise?
> 

Tony,
There will be more additions in respective board files such as I2C I/O expander
data, mux handling depending upon the EVM (8168/8148), on board peripherals etc
When these board files would deviate.

What do you suggest to handle such?

Thanks.
   Hemant

WARNING: multiple messages have this Message-ID (diff)
From: hemantp@ti.com (Pedanekar, Hemant)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] TI814X: Create board support and enable build for TI8148 EVM
Date: Fri, 19 Aug 2011 09:57:18 +0530	[thread overview]
Message-ID: <2A3DCF3DA181AD40BDE86A3150B27B6B03ABD26D8D@dbde02.ent.ti.com> (raw)
In-Reply-To: <20110815151509.GT12348@atomide.com>

Tony Lindgren wrote on Monday, August 15, 2011 8:45 PM:

> * Hemant Pedanekar <hemantp@ti.com> [110804 20:39]:
>> This patch adds minimal support and build configuration for TI8148 EVM.
>> Also adds support for low level debugging on UART1 console on the EVM. ...
> 
> 
>> +MACHINE_START(TI8148EVM, "ti8148evm")
>> +	/* Maintainer: Texas Instruments */
>> +	.boot_params	= 0x80000100,
>> +	.map_io		= ti8148_evm_map_io,
>> +	.init_early	= ti8148_init_early,
>> +	.init_irq	= ti81xx_init_irq,
>> +	.timer		= &omap3_timer,
>> +	.init_machine	= ti8148_evm_init,
>> +MACHINE_END
> 
> Please just combine this with board-ti8168evm.c by adding the MACHINE_START
> there. It seems the files are identical otherwise?
> 

Tony,
There will be more additions in respective board files such as I2C I/O expander
data, mux handling depending upon the EVM (8168/8148), on board peripherals etc
When these board files would deviate.

What do you suggest to handle such?

Thanks.
   Hemant

  reply	other threads:[~2011-08-19  4:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 17:45 [PATCH 3/3] TI814X: Create board support and enable build for TI8148 EVM Hemant Pedanekar
2011-08-04 17:45 ` Hemant Pedanekar
2011-08-15 15:15 ` Tony Lindgren
2011-08-15 15:15   ` Tony Lindgren
2011-08-19  4:27   ` Pedanekar, Hemant [this message]
2011-08-19  4:27     ` Pedanekar, Hemant
2011-08-30  0:13 ` Kevin Hilman
2011-08-30  0:13   ` Kevin Hilman
2011-09-08  1:21   ` Pedanekar, Hemant
2011-09-08  1:21     ` Pedanekar, Hemant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2A3DCF3DA181AD40BDE86A3150B27B6B03ABD26D8D@dbde02.ent.ti.com \
    --to=hemantp@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.