From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: "Christoph Hellwig" <hch@infradead.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
<linux-fsdevel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: Please pull NFS client changes
Date: Sun, 31 Jul 2011 11:30:48 -0700 [thread overview]
Message-ID: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430A777FE7@SACMVEXC2-PRD.hq.netapp.com> (raw)
In-Reply-To: <20110731182406.GA16470@infradead.org>
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Sunday, July 31, 2011 2:24 PM
> To: Myklebust, Trond
> Cc: Linus Torvalds; linux-fsdevel@vger.kernel.org; linux-
> nfs@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: Please pull NFS client changes
>
> How does this manage to include the pnfs block code, which only was
> posted
> on the list a few hours before the pull request, and which doesn't
> appear to past testing very well (although the major issue seems to be
> core nfs code)?
The majority of that code has been ready for several weeks and has been
posted several times for review. The main stuff that was addressed in
the last week were smaller issues such as the naming of functions that
are globally visible (i.e. not polluting the kernel namespace), a few
bisectability issues and (in the last iteraction) the lack of a
signed-off-by: from Jim.
I agree that we have to address the bug that Peng found, but that
appears to be linked to the NFSv4.1 back channel, which these patches
did not change.
The other point to note is that the patches do not touch the main
read/write code and only lightly change the pNFS code paths. The impact
of any residual bugs is therefore going to be limited.
WARNING: multiple messages have this Message-ID (diff)
From: "Myklebust, Trond" <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
To: "Christoph Hellwig" <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: "Linus Torvalds"
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: Please pull NFS client changes
Date: Sun, 31 Jul 2011 11:30:48 -0700 [thread overview]
Message-ID: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430A777FE7@SACMVEXC2-PRD.hq.netapp.com> (raw)
In-Reply-To: <20110731182406.GA16470-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org]
> Sent: Sunday, July 31, 2011 2:24 PM
> To: Myklebust, Trond
> Cc: Linus Torvalds; linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
> nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: Please pull NFS client changes
>
> How does this manage to include the pnfs block code, which only was
> posted
> on the list a few hours before the pull request, and which doesn't
> appear to past testing very well (although the major issue seems to be
> core nfs code)?
The majority of that code has been ready for several weeks and has been
posted several times for review. The main stuff that was addressed in
the last week were smaller issues such as the naming of functions that
are globally visible (i.e. not polluting the kernel namespace), a few
bisectability issues and (in the last iteraction) the lack of a
signed-off-by: from Jim.
I agree that we have to address the bug that Peng found, but that
appears to be linked to the NFSv4.1 back channel, which these patches
did not change.
The other point to note is that the patches do not touch the main
read/write code and only lightly change the pNFS code paths. The impact
of any residual bugs is therefore going to be limited.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-07-31 18:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 3:19 Please pull NFS client changes Trond Myklebust
2011-07-31 18:24 ` Christoph Hellwig
2011-07-31 18:24 ` Christoph Hellwig
2011-07-31 18:30 ` Myklebust, Trond [this message]
2011-07-31 18:30 ` Myklebust, Trond
2011-07-31 19:14 ` Jens Axboe
2011-07-31 19:14 ` Jens Axboe
2011-07-31 19:39 ` Trond Myklebust
2011-07-31 19:39 ` Trond Myklebust
2011-07-31 19:39 ` Trond Myklebust
2011-07-31 19:46 ` Jens Axboe
2011-07-31 19:46 ` Jens Axboe
2011-07-31 19:58 ` Trond Myklebust
2011-07-31 19:58 ` Trond Myklebust
2011-07-31 19:58 ` Trond Myklebust
2011-07-31 20:03 ` Jens Axboe
2011-07-31 20:03 ` Jens Axboe
2011-08-01 0:57 ` Stephen Rothwell
2011-08-01 1:01 ` Stephen Rothwell
2011-08-01 1:01 ` Stephen Rothwell
2011-08-03 23:51 ` Boaz Harrosh
2011-08-03 23:54 ` Myklebust, Trond
2011-08-04 4:52 ` [PATCH] pnfs-obj: Fix the comp_index != 0 case Boaz Harrosh
2011-08-04 4:55 ` Boaz Harrosh
2011-08-04 4:54 ` [PATCH 1/2] pnfs-obj: Bug when we are running out of bio Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E1EB2CF9ED1CB4AA966F0EB76EAB4430A777FE7@SACMVEXC2-PRD.hq.netapp.com \
--to=trond.myklebust@netapp.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.