Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

From: Jordan Justen <jljusten@gmail.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA
Date: Wed, 29 Jul 2009 09:23:51 -0700	[thread overview]
Message-ID: <2a50f7880907290923s4568986cs7548650c9315cdf0@mail.gmail.com> (raw)
In-Reply-To: <4A2D886C.5020007@us.ibm.com>

On Mon, Jun 8, 2009 at 2:53 PM, Anthony Liguori<aliguori@us.ibm.com> wrote:
> Anthony Liguori wrote:
>>
>> This is needed for VMware VGA to work properly under KVM.
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>>  hw/vmware_vga.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
>> index bb17698..246011b 100644
>> --- a/hw/vmware_vga.c
>> +++ b/hw/vmware_vga.c
>> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev,
>> int region_num,
>>  #endif
>>     cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>>                     iomemtype);
>> +
>> +    s->vga.map_addr = addr;
>> +    s->vga.map_end = addr + s->vga.vram_size;
>> +    vga_dirty_log_start(&s->vga);
>>  }
>>
>>  void pci_vmsvga_init(PCIBus *bus)
>>
>
> N.B. depth is still screwed up with VMware vga but the fix for that looks a
> bit more non-obvious.  This VBE issue has been a long standing problem
> though and I suspect it effects other guests though.
>

I've tried booting Ubuntu 8.10/9.04 using '-vga vmware' on various versions of
kvm and qemu.  The result is always ok video during BIOS post, but garbage
during pre and post X.  Would this be a symptom of the 'VBE' issue that
you mentioned?

> --
> Regards,
>
> Anthony Liguori
>
>
>
>