Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA

From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] Make sure to enable dirty log tracking for VMware VGA
Date: Mon, 08 Jun 2009 16:53:48 -0500	[thread overview]
Message-ID: <4A2D886C.5020007@us.ibm.com> (raw)
In-Reply-To: <1244497683-14391-2-git-send-email-aliguori@us.ibm.com>

Anthony Liguori wrote:
> This is needed for VMware VGA to work properly under KVM.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  hw/vmware_vga.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
> index bb17698..246011b 100644
> --- a/hw/vmware_vga.c
> +++ b/hw/vmware_vga.c
> @@ -1203,6 +1203,10 @@ static void pci_vmsvga_map_mem(PCIDevice *pci_dev, int region_num,
>  #endif
>      cpu_register_physical_memory(s->vram_base, s->vga.vram_size,
>                      iomemtype);
> +
> +    s->vga.map_addr = addr;
> +    s->vga.map_end = addr + s->vga.vram_size;
> +    vga_dirty_log_start(&s->vga);
>  }
>
>  void pci_vmsvga_init(PCIBus *bus)
>   
N.B. depth is still screwed up with VMware vga but the fix for that 
looks a bit more non-obvious.  This VBE issue has been a long standing 
problem though and I suspect it effects other guests though.

-- 
Regards,

Anthony Liguori