From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Melissa Wen <melissa.srw@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Lucas Stach <l.stach@pengutronix.de>
Cc: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
"Jack Zhang" <Jack.Zhang1@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Steven Price" <steven.price@arm.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Nirmoy Das" <nirmoy.aiemd@gmail.com>
Subject: Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking
Date: Wed, 28 Jul 2021 13:28:59 +0200 [thread overview]
Message-ID: <2bcfba05-b7d5-1bd9-d74a-b9aac1147e20@gmail.com> (raw)
In-Reply-To: <CAKMK7uG8bMuDP=7-z9nZ38WgMdbeUk96eNx3buTCiaKatYOJxw@mail.gmail.com>
Am 27.07.21 um 13:09 schrieb Daniel Vetter:
> Adding a few more people to this bikeshed.
>
> On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
>> @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job,
>> struct drm_sched_entity *entity,
>> void *owner);
>> void drm_sched_job_arm(struct drm_sched_job *job);
>> +int drm_sched_job_await_fence(struct drm_sched_job *job,
>> + struct dma_fence *fence);
>> +int drm_sched_job_await_implicit(struct drm_sched_job *job,
>> + struct drm_gem_object *obj,
>> + bool write);
>> +
>> +
> I'm still waiting on the paint delivery for these two functions so I
> can finish this shed.
Well I wouldn't call that bike shedding, good names are important.
Just imaging we would have called the exclusive-fence write-fence instead.
What speaks against calling them add_dependency() and
_add_implicit_depencencies() ?
Regards,
Christian.
>
> Thanks, Daniel
>
>> void drm_sched_entity_modify_sched(struct drm_sched_entity *entity,
>> struct drm_gpu_scheduler **sched_list,
>> unsigned int num_sched_list);
>> --
>> 2.32.0
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Melissa Wen <melissa.srw@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Lucas Stach <l.stach@pengutronix.de>
Cc: "Jack Zhang" <Jack.Zhang1@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Steven Price" <steven.price@arm.com>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Nirmoy Das" <nirmoy.aiemd@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>
Subject: Re: [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking
Date: Wed, 28 Jul 2021 13:28:59 +0200 [thread overview]
Message-ID: <2bcfba05-b7d5-1bd9-d74a-b9aac1147e20@gmail.com> (raw)
In-Reply-To: <CAKMK7uG8bMuDP=7-z9nZ38WgMdbeUk96eNx3buTCiaKatYOJxw@mail.gmail.com>
Am 27.07.21 um 13:09 schrieb Daniel Vetter:
> Adding a few more people to this bikeshed.
>
> On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
>> @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job,
>> struct drm_sched_entity *entity,
>> void *owner);
>> void drm_sched_job_arm(struct drm_sched_job *job);
>> +int drm_sched_job_await_fence(struct drm_sched_job *job,
>> + struct dma_fence *fence);
>> +int drm_sched_job_await_implicit(struct drm_sched_job *job,
>> + struct drm_gem_object *obj,
>> + bool write);
>> +
>> +
> I'm still waiting on the paint delivery for these two functions so I
> can finish this shed.
Well I wouldn't call that bike shedding, good names are important.
Just imaging we would have called the exclusive-fence write-fence instead.
What speaks against calling them add_dependency() and
_add_implicit_depencencies() ?
Regards,
Christian.
>
> Thanks, Daniel
>
>> void drm_sched_entity_modify_sched(struct drm_sched_entity *entity,
>> struct drm_gpu_scheduler **sched_list,
>> unsigned int num_sched_list);
>> --
>> 2.32.0
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Melissa Wen <melissa.srw@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Lucas Stach <l.stach@pengutronix.de>
Cc: "Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
"Jack Zhang" <Jack.Zhang1@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Steven Price" <steven.price@arm.com>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Nirmoy Das" <nirmoy.aiemd@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>
Subject: Re: [Intel-gfx] [Linaro-mm-sig] [PATCH v4 03/18] drm/sched: Add dependency tracking
Date: Wed, 28 Jul 2021 13:28:59 +0200 [thread overview]
Message-ID: <2bcfba05-b7d5-1bd9-d74a-b9aac1147e20@gmail.com> (raw)
In-Reply-To: <CAKMK7uG8bMuDP=7-z9nZ38WgMdbeUk96eNx3buTCiaKatYOJxw@mail.gmail.com>
Am 27.07.21 um 13:09 schrieb Daniel Vetter:
> Adding a few more people to this bikeshed.
>
> On Mon, Jul 12, 2021 at 10:02 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
>> @@ -349,6 +367,13 @@ int drm_sched_job_init(struct drm_sched_job *job,
>> struct drm_sched_entity *entity,
>> void *owner);
>> void drm_sched_job_arm(struct drm_sched_job *job);
>> +int drm_sched_job_await_fence(struct drm_sched_job *job,
>> + struct dma_fence *fence);
>> +int drm_sched_job_await_implicit(struct drm_sched_job *job,
>> + struct drm_gem_object *obj,
>> + bool write);
>> +
>> +
> I'm still waiting on the paint delivery for these two functions so I
> can finish this shed.
Well I wouldn't call that bike shedding, good names are important.
Just imaging we would have called the exclusive-fence write-fence instead.
What speaks against calling them add_dependency() and
_add_implicit_depencencies() ?
Regards,
Christian.
>
> Thanks, Daniel
>
>> void drm_sched_entity_modify_sched(struct drm_sched_entity *entity,
>> struct drm_gpu_scheduler **sched_list,
>> unsigned int num_sched_list);
>> --
>> 2.32.0
>>
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-28 11:29 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 17:53 [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 01/18] drm/sched: Split drm_sched_job_init Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 20:22 ` Emma Anholt
2021-07-12 20:22 ` [Intel-gfx] " Emma Anholt
2021-07-12 20:22 ` Emma Anholt
2021-07-13 6:40 ` Christian König
2021-07-13 6:40 ` [Intel-gfx] " Christian König
2021-07-13 6:40 ` Christian König
2021-07-13 6:53 ` Daniel Vetter
2021-07-13 6:53 ` [Intel-gfx] " Daniel Vetter
2021-07-13 6:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 02/18] drm/sched: Barriers are needed for entity->last_scheduled Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-13 6:35 ` Christian König
2021-07-13 6:35 ` [Intel-gfx] " Christian König
2021-07-13 6:50 ` Daniel Vetter
2021-07-13 6:50 ` [Intel-gfx] " Daniel Vetter
2021-07-13 7:25 ` Christian König
2021-07-13 7:25 ` [Intel-gfx] " Christian König
2021-07-13 9:10 ` Daniel Vetter
2021-07-13 9:10 ` [Intel-gfx] " Daniel Vetter
2021-07-13 11:20 ` Christian König
2021-07-13 11:20 ` [Intel-gfx] " Christian König
2021-07-13 16:11 ` Andrey Grodzovsky
2021-07-13 16:11 ` [Intel-gfx] " Andrey Grodzovsky
2021-07-13 16:45 ` Daniel Vetter
2021-07-13 16:45 ` [Intel-gfx] " Daniel Vetter
2021-07-14 22:12 ` Andrey Grodzovsky
2021-07-14 22:12 ` [Intel-gfx] " Andrey Grodzovsky
2021-07-15 10:16 ` Daniel Vetter
2021-07-15 10:16 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 03/18] drm/sched: Add dependency tracking Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-27 11:09 ` Daniel Vetter
2021-07-27 11:09 ` [Intel-gfx] " Daniel Vetter
2021-07-27 11:09 ` Daniel Vetter
2021-07-28 11:28 ` Christian König [this message]
2021-07-28 11:28 ` [Intel-gfx] [Linaro-mm-sig] " Christian König
2021-07-28 11:28 ` Christian König
2021-07-28 12:09 ` Daniel Vetter
2021-07-28 12:09 ` [Intel-gfx] " Daniel Vetter
2021-07-28 12:09 ` Daniel Vetter
2021-07-28 12:46 ` Christian König
2021-07-28 12:46 ` [Intel-gfx] " Christian König
2021-07-28 12:46 ` Christian König
2021-07-28 15:20 ` Melissa Wen
2021-07-28 15:20 ` [Intel-gfx] " Melissa Wen
2021-07-28 15:20 ` Melissa Wen
2021-07-12 17:53 ` [PATCH v4 04/18] drm/sched: drop entity parameter from drm_sched_push_job Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 05/18] drm/sched: improve docs around drm_sched_entity Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 06/18] drm/panfrost: use scheduler dependency tracking Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 07/18] drm/lima: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 08/18] drm/v3d: Move drm_sched_job_init to v3d_job_init Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-14 9:34 ` Melissa Wen
2021-07-14 9:34 ` [Intel-gfx] " Melissa Wen
2021-07-12 17:53 ` [PATCH v4 09/18] drm/v3d: Use scheduler dependency handling Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-14 9:37 ` Melissa Wen
2021-07-14 9:37 ` [Intel-gfx] " Melissa Wen
2021-07-12 17:53 ` [PATCH v4 10/18] drm/etnaviv: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 11/18] drm/gem: Delete gem array fencing helpers Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 12/18] drm/sched: Don't store self-dependencies Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 13/18] drm/sched: Check locking in drm_sched_job_await_implicit Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 14/18] drm/msm: Don't break exclusive fence ordering Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-13 16:55 ` Rob Clark
2021-07-13 16:55 ` [Intel-gfx] " Rob Clark
2021-07-13 16:55 ` Rob Clark
2021-07-13 16:58 ` Daniel Vetter
2021-07-13 16:58 ` [Intel-gfx] " Daniel Vetter
2021-07-13 16:58 ` Daniel Vetter
2021-07-13 17:46 ` Rob Clark
2021-07-13 17:46 ` [Intel-gfx] " Rob Clark
2021-07-13 17:46 ` Rob Clark
2021-07-13 17:45 ` Daniel Vetter
2021-07-13 17:45 ` [Intel-gfx] " Daniel Vetter
2021-07-13 17:45 ` Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 15/18] drm/etnaviv: " Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 16/18] drm/i915: delete exclude argument from i915_sw_fence_await_reservation Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 17/18] drm/i915: Don't break exclusive fence ordering Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` [PATCH v4 18/18] dma-resv: Give the docs a do-over Daniel Vetter
2021-07-12 17:53 ` [Intel-gfx] " Daniel Vetter
2021-07-12 17:53 ` Daniel Vetter
2021-07-12 20:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/sched dependency tracking and dma-resv fixes (rev3) Patchwork
2021-07-12 21:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-12 23:43 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-07-27 11:51 ` [PATCH v4 00/18] drm/sched dependency tracking and dma-resv fixes Boris Brezillon
2021-07-27 11:51 ` [Intel-gfx] " Boris Brezillon
2021-07-27 14:47 ` Melissa Wen
2021-07-27 14:47 ` [Intel-gfx] " Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bcfba05-b7d5-1bd9-d74a-b9aac1147e20@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Jack.Zhang1@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=melissa.srw@gmail.com \
--cc=nirmoy.aiemd@gmail.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.