From: Wesley Cheng <quic_wcheng@quicinc.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>, <perex@perex.cz>, <lgirdwood@gmail.com>, <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>, <bgoswami@quicinc.com>, <tiwai@suse.com>, <robh+dt@kernel.org>, <agross@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>, <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>, <linux-usb@vger.kernel.org>, <quic_jackp@quicinc.com>, <quic_plai@quicinc.com> Subject: Re: [RFC PATCH v2 12/22] sound: usb: card: Introduce USB SND platform op callbacks Date: Fri, 10 Feb 2023 14:49:35 -0800 [thread overview] Message-ID: <2c062ab0-905c-f1fe-eca2-02e23cc9fa6f@quicinc.com> (raw) In-Reply-To: <Y9Ui82OaI54Qx8Ft@kroah.com> Hi Greg, On 1/28/2023 5:28 AM, Greg KH wrote: > On Wed, Jan 25, 2023 at 07:14:14PM -0800, Wesley Cheng wrote: >> Allow for different platforms to be notified on USB SND connect/disconnect >> seqeunces. This allows for platform USB SND modules to properly initialize >> and populate internal structures with references to the USB SND chip >> device. >> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >> --- >> sound/usb/card.c | 28 ++++++++++++++++++++++++++++ >> sound/usb/card.h | 20 ++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/sound/usb/card.c b/sound/usb/card.c >> index 26268ffb8274..803230343c16 100644 >> --- a/sound/usb/card.c >> +++ b/sound/usb/card.c >> @@ -117,6 +117,24 @@ MODULE_PARM_DESC(skip_validation, "Skip unit descriptor validation (default: no) >> static DEFINE_MUTEX(register_mutex); >> static struct snd_usb_audio *usb_chip[SNDRV_CARDS]; >> static struct usb_driver usb_audio_driver; >> +static struct snd_usb_platform_ops *platform_ops; > > You can not have a single "platform_ops" pointer, this HAS to be > per-bus. > Agreed. > And what is a "platform operations" anyway? Shouldn't this be a driver > type or something like that? "offload_operations"? > The reason for going with platform operations is because every platform may implement the offloading differently. The offload operations term is more direct though in terms of explaining what the ops are going to be used for, so I can see the incentive of moving to that phrase. >> + >> +int snd_usb_register_platform_ops(struct snd_usb_platform_ops *ops) >> +{ >> + if (platform_ops) >> + return -EEXIST; >> + >> + platform_ops = ops; >> + return 0; > > No locking? not good. > > But again, this has to be per-USB-bus, it can NOT be system wide for > obvious reasons. > Sure, will change that when moving to per USB bus. Thanks Wesley Cheng
WARNING: multiple messages have this Message-ID (diff)
From: Wesley Cheng <quic_wcheng@quicinc.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: srinivas.kandagatla@linaro.org, mathias.nyman@intel.com, lgirdwood@gmail.com, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com, broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, quic_jackp@quicinc.com, quic_plai@quicinc.com Subject: Re: [RFC PATCH v2 12/22] sound: usb: card: Introduce USB SND platform op callbacks Date: Fri, 10 Feb 2023 14:49:35 -0800 [thread overview] Message-ID: <2c062ab0-905c-f1fe-eca2-02e23cc9fa6f@quicinc.com> (raw) In-Reply-To: <Y9Ui82OaI54Qx8Ft@kroah.com> Hi Greg, On 1/28/2023 5:28 AM, Greg KH wrote: > On Wed, Jan 25, 2023 at 07:14:14PM -0800, Wesley Cheng wrote: >> Allow for different platforms to be notified on USB SND connect/disconnect >> seqeunces. This allows for platform USB SND modules to properly initialize >> and populate internal structures with references to the USB SND chip >> device. >> >> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> >> --- >> sound/usb/card.c | 28 ++++++++++++++++++++++++++++ >> sound/usb/card.h | 20 ++++++++++++++++++++ >> 2 files changed, 48 insertions(+) >> >> diff --git a/sound/usb/card.c b/sound/usb/card.c >> index 26268ffb8274..803230343c16 100644 >> --- a/sound/usb/card.c >> +++ b/sound/usb/card.c >> @@ -117,6 +117,24 @@ MODULE_PARM_DESC(skip_validation, "Skip unit descriptor validation (default: no) >> static DEFINE_MUTEX(register_mutex); >> static struct snd_usb_audio *usb_chip[SNDRV_CARDS]; >> static struct usb_driver usb_audio_driver; >> +static struct snd_usb_platform_ops *platform_ops; > > You can not have a single "platform_ops" pointer, this HAS to be > per-bus. > Agreed. > And what is a "platform operations" anyway? Shouldn't this be a driver > type or something like that? "offload_operations"? > The reason for going with platform operations is because every platform may implement the offloading differently. The offload operations term is more direct though in terms of explaining what the ops are going to be used for, so I can see the incentive of moving to that phrase. >> + >> +int snd_usb_register_platform_ops(struct snd_usb_platform_ops *ops) >> +{ >> + if (platform_ops) >> + return -EEXIST; >> + >> + platform_ops = ops; >> + return 0; > > No locking? not good. > > But again, this has to be per-USB-bus, it can NOT be system wide for > obvious reasons. > Sure, will change that when moving to per USB bus. Thanks Wesley Cheng
next prev parent reply other threads:[~2023-02-10 22:50 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-26 3:14 [RFC PATCH v2 00/22] Introduce QC USB SND audio offloading support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 01/22] xhci: fix event ring segment table related masks and variables in header Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 02/22] xhci: remove xhci_test_trb_in_td_math early development check Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 7:48 ` Greg KH 2023-01-26 7:48 ` Greg KH 2023-01-26 3:14 ` [RFC PATCH v2 03/22] xhci: Refactor interrupter code for initial multi interrupter support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 04/22] xhci: Add support to allocate several interrupters Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 05/22] usb: xhci: Add XHCI APIs to support USB offloading Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 06/22] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 07/22] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:32 ` Pierre-Louis Bossart 2023-01-30 22:36 ` Wesley Cheng 2023-01-30 22:36 ` Wesley Cheng 2023-01-28 13:26 ` Greg KH 2023-01-28 13:26 ` Greg KH 2023-01-29 6:54 ` Zhou Furong 2023-01-29 6:54 ` Zhou Furong 2023-01-29 7:09 ` Greg KH 2023-01-29 7:09 ` Greg KH 2023-01-30 8:34 ` Zhou Furong 2023-01-30 8:34 ` Zhou Furong 2023-01-30 9:27 ` Greg KH 2023-01-30 9:27 ` Greg KH 2023-02-10 22:46 ` Wesley Cheng 2023-02-10 22:46 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 08/22] ASoC: dt-bindings: Add USB_RX port Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 11:55 ` Krzysztof Kozlowski 2023-01-26 11:55 ` Krzysztof Kozlowski 2023-01-30 21:52 ` Wesley Cheng 2023-01-30 21:52 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 09/22] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:07 ` Srinivas Kandagatla 2023-01-26 15:07 ` Srinivas Kandagatla 2023-01-26 15:38 ` Pierre-Louis Bossart 2023-01-30 22:54 ` Wesley Cheng 2023-01-30 22:54 ` Wesley Cheng 2023-01-30 23:59 ` Pierre-Louis Bossart 2023-02-01 2:40 ` Wesley Cheng 2023-02-01 2:40 ` Wesley Cheng 2023-02-01 3:02 ` Pierre-Louis Bossart 2023-02-03 1:23 ` Wesley Cheng 2023-02-03 1:23 ` Wesley Cheng 2023-02-03 1:44 ` Wesley Cheng 2023-02-03 1:44 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 10/22] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:09 ` Srinivas Kandagatla 2023-01-26 15:09 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 11/22] ASoC: qcom: Add USB backend ASoC driver for Q6 Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:44 ` Pierre-Louis Bossart 2023-01-30 22:59 ` Wesley Cheng 2023-01-30 22:59 ` Wesley Cheng 2023-01-30 23:50 ` Pierre-Louis Bossart 2023-01-26 16:35 ` Srinivas Kandagatla 2023-01-26 16:35 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 12/22] sound: usb: card: Introduce USB SND platform op callbacks Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 15:50 ` Pierre-Louis Bossart 2023-01-30 23:00 ` Wesley Cheng 2023-01-30 23:00 ` Wesley Cheng 2023-01-28 13:28 ` Greg KH 2023-01-28 13:28 ` Greg KH 2023-02-10 22:49 ` Wesley Cheng [this message] 2023-02-10 22:49 ` Wesley Cheng 2023-02-28 2:59 ` Wesley Cheng 2023-02-28 2:59 ` Wesley Cheng 2023-02-28 7:30 ` Greg KH 2023-02-28 7:30 ` Greg KH 2023-02-28 9:19 ` Wesley Cheng 2023-02-28 9:19 ` Wesley Cheng 2023-02-28 15:29 ` Greg KH 2023-02-28 15:29 ` Greg KH 2023-02-20 17:11 ` Albert Wang 2023-02-20 17:11 ` Albert Wang 2023-01-26 3:14 ` [RFC PATCH v2 13/22] sound: usb: Export USB SND APIs for modules Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps, num-hc-interrupters definition Wesley Cheng 2023-01-26 12:01 ` [RFC PATCH v2 14/22] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Krzysztof Kozlowski 2023-01-26 12:01 ` Krzysztof Kozlowski 2023-01-30 22:02 ` Wesley Cheng 2023-01-30 22:02 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 15/22] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 16/22] sound: usb: Introduce QC USB SND offloading support Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 16:07 ` Pierre-Louis Bossart 2023-01-28 13:32 ` Greg KH 2023-01-28 13:32 ` Greg KH 2023-02-11 0:03 ` Wesley Cheng 2023-02-11 0:03 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 17/22] sound: usb: card: Check for support for requested audio format Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 18/22] sound: soc: soc-usb: Add PCM format check API for USB backend Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 19/22] sound: soc: qcom: qusb6: Ensure PCM format is supported by USB audio device Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 20/22] sound: usb: Prevent starting of audio stream if in use Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 16:12 ` Pierre-Louis Bossart 2023-02-07 1:15 ` Wesley Cheng 2023-02-07 1:15 ` Wesley Cheng 2023-02-07 13:29 ` Pierre-Louis Bossart 2023-02-07 13:29 ` Pierre-Louis Bossart 2023-02-11 9:52 ` Wesley Cheng 2023-02-11 9:52 ` Wesley Cheng 2023-02-13 15:22 ` Pierre-Louis Bossart 2023-02-13 20:12 ` Wesley Cheng 2023-02-13 20:12 ` Wesley Cheng 2023-01-26 3:14 ` [RFC PATCH v2 21/22] ASoC: dt-bindings: Add Q6USB backend bindings Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 12:03 ` Krzysztof Kozlowski 2023-01-26 12:03 ` Krzysztof Kozlowski 2023-01-26 16:01 ` Srinivas Kandagatla 2023-01-26 16:01 ` Srinivas Kandagatla 2023-01-26 3:14 ` [RFC PATCH v2 22/22] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng 2023-01-26 3:14 ` Wesley Cheng 2023-01-26 12:05 ` Krzysztof Kozlowski 2023-01-26 12:05 ` Krzysztof Kozlowski 2023-01-26 9:23 ` [RFC PATCH v2 00/22] Introduce QC USB SND audio offloading support Mathias Nyman 2023-01-26 9:23 ` Mathias Nyman 2023-01-30 21:51 ` Wesley Cheng 2023-01-30 21:51 ` Wesley Cheng 2023-01-26 16:22 ` Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2c062ab0-905c-f1fe-eca2-02e23cc9fa6f@quicinc.com \ --to=quic_wcheng@quicinc.com \ --cc=Thinh.Nguyen@synopsys.com \ --cc=agross@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=andersson@kernel.org \ --cc=bgoswami@quicinc.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=perex@perex.cz \ --cc=quic_jackp@quicinc.com \ --cc=quic_plai@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.