From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christopher Obbard <chris.obbard@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Elaine Zhang <zhangqing@rock-chips.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible
Date: Mon, 25 Apr 2022 20:07:22 +0200 [thread overview]
Message-ID: <2c347033-bd63-05a8-94fb-2eb467e63e76@linaro.org> (raw)
In-Reply-To: <20220425123215.1055251-2-chris.obbard@collabora.com>
On 25/04/2022 14:32, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 089f11d21b25..ce06835e8d61 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -20,6 +20,9 @@ properties:
> - items:
> - const: rockchip,rk3228-vdec
> - const: rockchip,rk3399-vdec
> + - items:
> + - const: rockchip,rk3328-vdec
> + - const: rockchip,rk3399-vdec
This should be rather an enum with rk3228, so:
- enum
- rockchip,rk3228-vdec
- rockchip,rk3328-vdec
- const: rockchip,rk3399-vdec
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christopher Obbard <chris.obbard@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Elaine Zhang <zhangqing@rock-chips.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible
Date: Mon, 25 Apr 2022 20:07:22 +0200 [thread overview]
Message-ID: <2c347033-bd63-05a8-94fb-2eb467e63e76@linaro.org> (raw)
In-Reply-To: <20220425123215.1055251-2-chris.obbard@collabora.com>
On 25/04/2022 14:32, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 089f11d21b25..ce06835e8d61 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -20,6 +20,9 @@ properties:
> - items:
> - const: rockchip,rk3228-vdec
> - const: rockchip,rk3399-vdec
> + - items:
> + - const: rockchip,rk3328-vdec
> + - const: rockchip,rk3399-vdec
This should be rather an enum with rk3228, so:
- enum
- rockchip,rk3228-vdec
- rockchip,rk3328-vdec
- const: rockchip,rk3399-vdec
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christopher Obbard <chris.obbard@collabora.com>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>,
Elaine Zhang <zhangqing@rock-chips.com>
Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible
Date: Mon, 25 Apr 2022 20:07:22 +0200 [thread overview]
Message-ID: <2c347033-bd63-05a8-94fb-2eb467e63e76@linaro.org> (raw)
In-Reply-To: <20220425123215.1055251-2-chris.obbard@collabora.com>
On 25/04/2022 14:32, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 089f11d21b25..ce06835e8d61 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -20,6 +20,9 @@ properties:
> - items:
> - const: rockchip,rk3228-vdec
> - const: rockchip,rk3399-vdec
> + - items:
> + - const: rockchip,rk3328-vdec
> + - const: rockchip,rk3399-vdec
This should be rather an enum with rk3228, so:
- enum
- rockchip,rk3228-vdec
- rockchip,rk3328-vdec
- const: rockchip,rk3399-vdec
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-25 18:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 12:32 [PATCH v2 0/3] Rockchip RK3328 VDEC support Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 18:07 ` Krzysztof Kozlowski [this message]
2022-04-25 18:07 ` Krzysztof Kozlowski
2022-04-25 18:07 ` Krzysztof Kozlowski
2022-04-25 18:47 ` Christopher Obbard
2022-04-25 18:47 ` Christopher Obbard
2022-04-25 18:47 ` Christopher Obbard
2022-04-25 12:32 ` [PATCH v2 2/3] arm64: dts: rockchip: Rename vdec_mmu node for RK3328 Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` [PATCH v2 3/3] arm64: dts: rockchip: Add vdec support " Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
2022-04-25 12:32 ` Christopher Obbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c347033-bd63-05a8-94fb-2eb467e63e76@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.