Re: [PATCH] platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet

From: Hans de Goede <j.w.r.degoede@gmail.com>
To: Bastien Nocera <hadess@hadess.net>, Mark Gross <mgross@linux.intel.com>
Cc: linux-input@vger.kernel.org, Andy Shevchenko <andy@infradead.org>,
	platform-driver-x86@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet
Date: Mon, 4 Jan 2021 14:24:27 +0100	[thread overview]
Message-ID: <2ce7980e-e90f-f778-d349-44e35b3baf1d@gmail.com> (raw)
In-Reply-To: <c7b47af9cc3bd1d38b6c3582f6e63d7876365ee9.camel@hadess.net>

Hi,

On 1/4/21 1:04 PM, Bastien Nocera wrote:
> On Mon, 2021-01-04 at 13:00 +0100, Hans de Goede wrote:
>> <
>> <snip>
>> Thank you for your patch, I've applied this patch to my review-hans 
>> branch:
>>  
>> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>>
>> Note it will show up in my review-hans branch once I've pushed my
>> local branch there, which might take a while.
> 
> Do you plan on sending a patch to migrate the other quirks in goodix.c
> itself to touchscreen_dmi.c?

Ideally yes, but the code in touchscreen_dmi.c matches on the ACPI device-name
the device to know which i2c-device to attach the properties to and that
is based on the ACPI HID.

This is likely "GDIX1001" in most cases, but according to the git log the
"Teclast X98 Pro"
"Cube I15-TC"
"Teclast X89"

Quirks have been added after the "GDIX1002" HID was added, so in theory
they could be using that.

And also some DSTD-s have multiple GDIX1001 nodes with only 1 being
enabled (returning non 0 from _STA) in which case the device-name could
be e.g. "GDIX1001:01" instead of "GDIX1001:00".

So I've just checked if I can find dmesg output or an acpidump for all devices
with a quirk to ensure that I get the device-name right. I can confirm that the
ACPI device-name for the touchscreen is "GDIX1001:00" on the:

  "Teclast X98 Pro"
  "WinBook TW100"
  "WinBook TW700"

I could be either "GDIX1001:00" or "GDIX1001:01" on the "Teclast X89", but
I have that one myself, so I can check that myself.

That just leaves the "Cube I15-TC", for which I cannot find an acpidump
or dmesg output. I will mail the author of the patch adding the quirk for
that one with a patch moving the quirk asking him to test the patch
(and fix it if necessary).

###

Dmitry, once I have a patch ready to move the goodix rotated_screen
and inverted_x_screen DMI quirk tables to platform/drivers/x86/touchscreen_dmi.c
where all other (x86) touchscreen quirks have been gathered so far, the question
becomes how to merge that patch ?

I see 2 options:

1. Have 2 separate patches, one adding the quirks to
platform/drivers/x86/touchscreen_dmi.c and a second patch removing the
DMI tables (and the code handling them) from goodix.c. And then merge
them through the pdx86 resp. the input tree.

2. Have 1 big patch doing both.

The downside of 1. is that there might be a point in git history where
the coordinates of the touchscreens regress. Depending on which pull-req
lands first (if the pdx86 pull-req for 5.12-rc1 gets merged first there
is no issue). But only when git-bisecting so I think that 1. is best to
avoid any merge issues. At least platform/drivers/x86/touchscreen_dmi.c
sees a lot of activity every cycle. So another option would be to 
do 1 big patch and then merge that through the pdx86 tree (I can provide
an immutable branch for that).

Dmitry if you can let me know which way you would prefer to move forward
with this then I can prepare the 1 or 2 patches (once I hear back from the
"Cube I15-TC" quirk patch author).

Regards,

Hans