From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <j.w.r.degoede@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>,
Mark Gross <mgross@linux.intel.com>,
linux-input@vger.kernel.org, Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet
Date: Mon, 4 Jan 2021 13:56:43 -0800 [thread overview]
Message-ID: <X/OPG5caR4SJ/PMH@google.com> (raw)
In-Reply-To: <2ce7980e-e90f-f778-d349-44e35b3baf1d@gmail.com>
Hi Hans,
On Mon, Jan 04, 2021 at 02:24:27PM +0100, Hans de Goede wrote:
>
> Dmitry, once I have a patch ready to move the goodix rotated_screen
> and inverted_x_screen DMI quirk tables to platform/drivers/x86/touchscreen_dmi.c
> where all other (x86) touchscreen quirks have been gathered so far, the question
> becomes how to merge that patch ?
>
> I see 2 options:
>
> 1. Have 2 separate patches, one adding the quirks to
> platform/drivers/x86/touchscreen_dmi.c and a second patch removing the
> DMI tables (and the code handling them) from goodix.c. And then merge
> them through the pdx86 resp. the input tree.
>
> 2. Have 1 big patch doing both.
>
> The downside of 1. is that there might be a point in git history where
> the coordinates of the touchscreens regress. Depending on which pull-req
> lands first (if the pdx86 pull-req for 5.12-rc1 gets merged first there
> is no issue). But only when git-bisecting so I think that 1. is best to
> avoid any merge issues. At least platform/drivers/x86/touchscreen_dmi.c
> sees a lot of activity every cycle. So another option would be to
> do 1 big patch and then merge that through the pdx86 tree (I can provide
> an immutable branch for that).
>
> Dmitry if you can let me know which way you would prefer to move forward
> with this then I can prepare the 1 or 2 patches (once I hear back from the
> "Cube I15-TC" quirk patch author).
I am fine with a single patch going through either platform or input
tree. We could even have an immutable branch off 5.10 and merge it into
both trees to ensure there are no clashes.
Thanks.
--
Dmitry
prev parent reply other threads:[~2021-01-04 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-24 13:51 [PATCH] platform/x86: touchscreen_dmi: Add swap-x-y quirk for Goodix touchscreen on Estar Beauty HD tablet Hans de Goede
[not found] ` <CANgRfon2PC8EY4H=DOzey++VqbQ-S9uG986zLWKR2hFm2E2P_A@mail.gmail.com>
2020-12-25 11:19 ` Hans de Goede
2021-01-04 12:00 ` Hans de Goede
2021-01-04 12:04 ` Bastien Nocera
2021-01-04 13:24 ` Hans de Goede
2021-01-04 21:56 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/OPG5caR4SJ/PMH@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andy@infradead.org \
--cc=hadess@hadess.net \
--cc=j.w.r.degoede@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.