From: "Andrew Jeffery" <andrew@aj.id.au> To: "Linus Walleij" <linus.walleij@linaro.org> Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, "Joel Stanley" <joel@jms.id.au>, linux-aspeed <linux-aspeed@lists.ozlabs.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "Linux ARM" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Johnny Huang" <johnny_huang@aspeedtech.com>, "Ryan Chen" <ryanchen.aspeed@gmail.com> Subject: Re: [PATCH 0/7] pinctrl: Fixes for AST2600 support Date: Wed, 16 Oct 2019 22:11:48 +1030 [thread overview] Message-ID: <2de90789-c374-4821-89f9-5d5f01e7d2d6@www.fastmail.com> (raw) In-Reply-To: <CACRpkda5cWaA7R3XzyiERCCgwUrjnXd+wCBeKvt-wtjex7wNDg@mail.gmail.com> On Wed, 16 Oct 2019, at 21:49, Linus Walleij wrote: > On Tue, Oct 8, 2019 at 6:41 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > This series resolves several issues found in testing by Johnny Huang from > > ASPEED, who also contributed the patches to fix them. We'll have more patches > > from him in the near future (which I'm pretty happy about). > > > > The major issue resolved is the way I grouped the eMMC pins. What I had was > > ugly and I want to get rid of it before the binding is solidified with the 5.4 > > release. > > Should some of these go in with fixes? All of them? Or just some? > I applied them to devel right now (for v5.5). I was hoping to get them into the 5.4 fixes branch: I consider them all fixes - the rework of the eMMC pin groups and functions is a fix for the binding. The rest are fixes for the driver itself. My preference is that they get into a release sooner rather than later. It's there something that makes you think they shouldn't be merged as fixes for 5.4? > > > The remaining fixes are minor issues that stem from lack of documentation or > > understanding on my part, and at least one brain-fart. > > Do they need to go in to v5.4 or not? > > I need a shortlist of anything that should go into v5.4 if anything. IMO all of them should go into 5.4, as above. It's there something I can do in the future to communicate this better? Explicit shortlist in the cover letter? Fixes tags on the relevant patches? Keen to make things easier/more obvious if I can. Cheers, Andrew
WARNING: multiple messages have this Message-ID (diff)
From: "Andrew Jeffery" <andrew@aj.id.au> To: "Linus Walleij" <linus.walleij@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Johnny Huang <johnny_huang@aspeedtech.com>, linux-aspeed <linux-aspeed@lists.ozlabs.org>, Ryan Chen <ryanchen.aspeed@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 0/7] pinctrl: Fixes for AST2600 support Date: Wed, 16 Oct 2019 22:11:48 +1030 [thread overview] Message-ID: <2de90789-c374-4821-89f9-5d5f01e7d2d6@www.fastmail.com> (raw) In-Reply-To: <CACRpkda5cWaA7R3XzyiERCCgwUrjnXd+wCBeKvt-wtjex7wNDg@mail.gmail.com> On Wed, 16 Oct 2019, at 21:49, Linus Walleij wrote: > On Tue, Oct 8, 2019 at 6:41 AM Andrew Jeffery <andrew@aj.id.au> wrote: > > > This series resolves several issues found in testing by Johnny Huang from > > ASPEED, who also contributed the patches to fix them. We'll have more patches > > from him in the near future (which I'm pretty happy about). > > > > The major issue resolved is the way I grouped the eMMC pins. What I had was > > ugly and I want to get rid of it before the binding is solidified with the 5.4 > > release. > > Should some of these go in with fixes? All of them? Or just some? > I applied them to devel right now (for v5.5). I was hoping to get them into the 5.4 fixes branch: I consider them all fixes - the rework of the eMMC pin groups and functions is a fix for the binding. The rest are fixes for the driver itself. My preference is that they get into a release sooner rather than later. It's there something that makes you think they shouldn't be merged as fixes for 5.4? > > > The remaining fixes are minor issues that stem from lack of documentation or > > understanding on my part, and at least one brain-fart. > > Do they need to go in to v5.4 or not? > > I need a shortlist of anything that should go into v5.4 if anything. IMO all of them should go into 5.4, as above. It's there something I can do in the future to communicate this better? Explicit shortlist in the cover letter? Fixes tags on the relevant patches? Keen to make things easier/more obvious if I can. Cheers, Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-16 11:42 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-08 4:41 [PATCH 0/7] pinctrl: Fixes for AST2600 support Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 1/7] dt-bindings: pinctrl: aspeed-g6: Rework SD3 function and groups Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-15 22:24 ` Rob Herring 2019-10-15 22:24 ` Rob Herring 2019-10-08 4:41 ` [PATCH 2/7] pinctrl: aspeed-g6: Sort pins for sanity Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 3/7] pinctrl: aspeed-g6: Fix I2C14 SDA description Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 4/7] pinctrl: aspeed-g6: Fix I3C3/I3C4 pinmux configuration Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 5/7] pinctrl: aspeed-g6: Make SIG_DESC_CLEAR() behave intuitively Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 6/7] pinctrl: aspeed-g6: Fix UART13 group pinmux Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` [PATCH 7/7] pinctrl: aspeed-g6: Rename SD3 to EMMC and rework pin groups Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:41 ` Andrew Jeffery 2019-10-08 4:54 ` [PATCH 0/7] pinctrl: Fixes for AST2600 support Joel Stanley 2019-10-08 4:54 ` Joel Stanley 2019-10-16 11:19 ` Linus Walleij 2019-10-16 11:19 ` Linus Walleij 2019-10-16 11:41 ` Andrew Jeffery [this message] 2019-10-16 11:41 ` Andrew Jeffery 2019-10-16 14:00 ` Linus Walleij 2019-10-16 14:00 ` Linus Walleij 2019-10-16 23:26 ` Andrew Jeffery 2019-10-16 23:26 ` Andrew Jeffery
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2de90789-c374-4821-89f9-5d5f01e7d2d6@www.fastmail.com \ --to=andrew@aj.id.au \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=johnny_huang@aspeedtech.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=ryanchen.aspeed@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.