All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Peter Xu <peterx@redhat.com>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Muchun Song <muchun.song@linux.dev>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf()
Date: Wed, 20 Mar 2024 17:40:39 +0000	[thread overview]
Message-ID: <2e632389-eb4e-42af-adee-36d5ba6c3d0f@csgroup.eu> (raw)
In-Reply-To: <ZfsKIResY4YcxkxK@x1n>



Le 20/03/2024 à 17:09, Peter Xu a écrit :
> On Wed, Mar 20, 2024 at 06:16:43AM +0000, Christophe Leroy wrote:
>> At the first place that was to get a close fit between hardware
>> pagetable topology and linux pagetable topology. But obviously we
>> already stepped back for 512k pages, so let's go one more step aside and
>> do similar with 8M pages.
>>
>> I'll give it a try and see how it goes.
> 
> So you're talking about 8M only for 8xx, am I right?

Yes I am.

> 
> There seem to be other PowerPC systems use hugepd.  Is it possible that we
> convert all hugepd into cont_pte form?

Indeed.

Seems like we have hugepd for book3s/64 and for nohash.

For book3s I don't know, may Aneesh can answer.

For nohash I think it should be possible because TLB misses are handled 
by software. Even the e6500 which has a hardware tablewalk falls back on 
software walk when it is a hugepage IIUC.

Christophe

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Peter Xu <peterx@redhat.com>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Matthew Wilcox <willy@infradead.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Muchun Song <muchun.song@linux.dev>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf()
Date: Wed, 20 Mar 2024 17:40:39 +0000	[thread overview]
Message-ID: <2e632389-eb4e-42af-adee-36d5ba6c3d0f@csgroup.eu> (raw)
In-Reply-To: <ZfsKIResY4YcxkxK@x1n>



Le 20/03/2024 à 17:09, Peter Xu a écrit :
> On Wed, Mar 20, 2024 at 06:16:43AM +0000, Christophe Leroy wrote:
>> At the first place that was to get a close fit between hardware
>> pagetable topology and linux pagetable topology. But obviously we
>> already stepped back for 512k pages, so let's go one more step aside and
>> do similar with 8M pages.
>>
>> I'll give it a try and see how it goes.
> 
> So you're talking about 8M only for 8xx, am I right?

Yes I am.

> 
> There seem to be other PowerPC systems use hugepd.  Is it possible that we
> convert all hugepd into cont_pte form?

Indeed.

Seems like we have hugepd for book3s/64 and for nohash.

For book3s I don't know, may Aneesh can answer.

For nohash I think it should be possible because TLB misses are handled 
by software. Even the e6500 which has a hardware tablewalk falls back on 
software walk when it is a hugepage IIUC.

Christophe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Peter Xu <peterx@redhat.com>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Muchun Song <muchun.song@linux.dev>,
	"x86@kernel.org" <x86@kernel.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Mike Rapoport <rppt@kernel.org>, Jason Gunthorpe <jgg@nvidia.com>,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf()
Date: Wed, 20 Mar 2024 17:40:39 +0000	[thread overview]
Message-ID: <2e632389-eb4e-42af-adee-36d5ba6c3d0f@csgroup.eu> (raw)
In-Reply-To: <ZfsKIResY4YcxkxK@x1n>



Le 20/03/2024 à 17:09, Peter Xu a écrit :
> On Wed, Mar 20, 2024 at 06:16:43AM +0000, Christophe Leroy wrote:
>> At the first place that was to get a close fit between hardware
>> pagetable topology and linux pagetable topology. But obviously we
>> already stepped back for 512k pages, so let's go one more step aside and
>> do similar with 8M pages.
>>
>> I'll give it a try and see how it goes.
> 
> So you're talking about 8M only for 8xx, am I right?

Yes I am.

> 
> There seem to be other PowerPC systems use hugepd.  Is it possible that we
> convert all hugepd into cont_pte form?

Indeed.

Seems like we have hugepd for book3s/64 and for nohash.

For book3s I don't know, may Aneesh can answer.

For nohash I think it should be possible because TLB misses are handled 
by software. Even the e6500 which has a hardware tablewalk falls back on 
software walk when it is a hugepage IIUC.

Christophe

  reply	other threads:[~2024-03-20 17:40 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 21:47 [PATCH 00/13] mm/treewide: Remove pXd_huge() API peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` peterx
2024-03-13 21:47 ` [PATCH 01/13] mm/hmm: Process pud swap entry without pud_huge() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 02/13] mm/gup: Cache p4d in follow_p4d_mask() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 03/13] mm/gup: Check p4d presence before going on peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 04/13] mm/x86: Change pXd_huge() behavior to exclude swap entries peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 05/13] mm/sparc: " peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 06/13] mm/arm: Use macros to define pmd/pud helpers peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 07/13] mm/arm: Redefine pmd_huge() with pmd_leaf() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 08/13] mm/arm64: Merge pXd_huge() and pXd_leaf() definitions peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 09/13] mm/powerpc: Redefine pXd_huge() with pXd_leaf() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-14  8:45   ` Christophe Leroy
2024-03-14  8:45     ` Christophe Leroy
2024-03-14  8:45     ` Christophe Leroy
2024-03-14 12:53     ` Peter Xu
2024-03-14 12:53       ` Peter Xu
2024-03-14 12:53       ` Peter Xu
2024-03-14 13:11       ` Christophe Leroy
2024-03-14 13:11         ` Christophe Leroy
2024-03-14 13:11         ` Christophe Leroy
2024-03-18 16:15         ` Jason Gunthorpe
2024-03-18 16:15           ` Jason Gunthorpe
2024-03-18 16:15           ` Jason Gunthorpe
2024-03-19 23:07           ` Christophe Leroy
2024-03-19 23:07             ` Christophe Leroy
2024-03-19 23:07             ` Christophe Leroy
2024-03-19 23:26             ` Jason Gunthorpe
2024-03-19 23:26               ` Jason Gunthorpe
2024-03-19 23:26               ` Jason Gunthorpe
2024-03-20  6:16               ` Christophe Leroy
2024-03-20  6:16                 ` Christophe Leroy
2024-03-20  6:16                 ` Christophe Leroy
2024-03-20 16:09                 ` Peter Xu
2024-03-20 16:09                   ` Peter Xu
2024-03-20 16:09                   ` Peter Xu
2024-03-20 17:40                   ` Christophe Leroy [this message]
2024-03-20 17:40                     ` Christophe Leroy
2024-03-20 17:40                     ` Christophe Leroy
2024-03-20 20:24                     ` Peter Xu
2024-03-20 20:24                       ` Peter Xu
2024-03-20 20:24                       ` Peter Xu
2024-03-13 21:47 ` [PATCH 10/13] mm/gup: Merge pXd huge mapping checks peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47 ` [PATCH 11/13] mm/treewide: Replace pXd_huge() with pXd_leaf() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-14  8:50   ` Christophe Leroy
2024-03-14  8:50     ` Christophe Leroy
2024-03-14  8:50     ` Christophe Leroy
2024-03-14 12:59     ` Peter Xu
2024-03-14 12:59       ` Peter Xu
2024-03-14 12:59       ` Peter Xu
2024-03-18 16:16       ` Jason Gunthorpe
2024-03-18 16:16         ` Jason Gunthorpe
2024-03-18 16:16         ` Jason Gunthorpe
2024-03-13 21:47 ` [PATCH 12/13] mm/treewide: Remove pXd_huge() peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx
2024-03-14  8:56   ` Christophe Leroy
2024-03-14  8:56     ` Christophe Leroy
2024-03-14  8:56     ` Christophe Leroy
2024-03-14 14:08     ` Peter Xu
2024-03-14 14:08       ` Peter Xu
2024-03-14 14:08       ` Peter Xu
2024-03-13 21:47 ` [PATCH 13/13] mm: Document pXd_leaf() API peterx
2024-03-13 21:47   ` peterx
2024-03-13 21:47   ` peterx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e632389-eb4e-42af-adee-36d5ba6c3d0f@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=jgg@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=muchun.song@linux.dev \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=peterx@redhat.com \
    --cc=rppt@kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.