All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David.Wu" <david.wu@rock-chips.com>
To: Elaine Zhang <zhangqing@rock-chips.com>,
	mturquette@baylibre.com, sboyd@codeaurora.org, heiko@sntech.de
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, xxx@rock-chips.com,
	xf@rock-chips.com, huangtao@rock-chips.com, cl@rock-chips.com,
	andy.yan@rock-chips.com, wdc@rock-chips.com
Subject: Re: [PATCH v2 4/4] clk: rockchip: rv1108: fix up the clk_mac sel register description
Date: Mon, 21 Aug 2017 18:30:59 +0800	[thread overview]
Message-ID: <2f6cae9a-b595-453f-1fd3-1858f7774cd9@rock-chips.com> (raw)
In-Reply-To: <1503303367-17915-5-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

在 2017/8/21 16:16, Elaine Zhang 写道:
> cru_sel24_con[8]
> rmii_extclk_sel
> clock source select control register
> 1'b0: from internal PLL
> 1'b1: from external IO
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rv1108.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 658da17c9d99..4d87828df4f7 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -140,7 +140,7 @@ enum rv1108_plls {
>   PNAME(mux_uart0_p)		= { "uart0_src", "uart0_frac", "xin24m" };
>   PNAME(mux_uart1_p)		= { "uart1_src", "uart1_frac", "xin24m" };
>   PNAME(mux_uart2_p)		= { "uart2_src", "uart2_frac", "xin24m" };
> -PNAME(mux_sclk_mac_p)	= { "ext_gmac", "sclk_mac_pre" };
> +PNAME(mux_sclk_mac_p)	= { "sclk_mac_pre", "ext_gmac" };
>   PNAME(mux_i2s0_pre_p)		= { "i2s0_src", "i2s0_frac", "ext_i2s", "xin12m" };
>   PNAME(mux_i2s_out_p)		= { "i2s0_pre", "xin12m" };
>   PNAME(mux_i2s1_p)		= { "i2s1_src", "i2s1_frac", "dummy", "xin12m" };
> 

Acked-by: David Wu <david.wu@rock-chips.com>

WARNING: multiple messages have this Message-ID (diff)
From: "David.Wu" <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	xf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	cl-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	wdc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v2 4/4] clk: rockchip: rv1108: fix up the clk_mac sel register description
Date: Mon, 21 Aug 2017 18:30:59 +0800	[thread overview]
Message-ID: <2f6cae9a-b595-453f-1fd3-1858f7774cd9@rock-chips.com> (raw)
In-Reply-To: <1503303367-17915-5-git-send-email-zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Hi Elaine,

在 2017/8/21 16:16, Elaine Zhang 写道:
> cru_sel24_con[8]
> rmii_extclk_sel
> clock source select control register
> 1'b0: from internal PLL
> 1'b1: from external IO
> 
> Signed-off-by: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>   drivers/clk/rockchip/clk-rv1108.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 658da17c9d99..4d87828df4f7 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -140,7 +140,7 @@ enum rv1108_plls {
>   PNAME(mux_uart0_p)		= { "uart0_src", "uart0_frac", "xin24m" };
>   PNAME(mux_uart1_p)		= { "uart1_src", "uart1_frac", "xin24m" };
>   PNAME(mux_uart2_p)		= { "uart2_src", "uart2_frac", "xin24m" };
> -PNAME(mux_sclk_mac_p)	= { "ext_gmac", "sclk_mac_pre" };
> +PNAME(mux_sclk_mac_p)	= { "sclk_mac_pre", "ext_gmac" };
>   PNAME(mux_i2s0_pre_p)		= { "i2s0_src", "i2s0_frac", "ext_i2s", "xin12m" };
>   PNAME(mux_i2s_out_p)		= { "i2s0_pre", "xin12m" };
>   PNAME(mux_i2s1_p)		= { "i2s1_src", "i2s1_frac", "dummy", "xin12m" };
> 

Acked-by: David Wu <david.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: david.wu@rock-chips.com (David.Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/4] clk: rockchip: rv1108: fix up the clk_mac sel register description
Date: Mon, 21 Aug 2017 18:30:59 +0800	[thread overview]
Message-ID: <2f6cae9a-b595-453f-1fd3-1858f7774cd9@rock-chips.com> (raw)
In-Reply-To: <1503303367-17915-5-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

? 2017/8/21 16:16, Elaine Zhang ??:
> cru_sel24_con[8]
> rmii_extclk_sel
> clock source select control register
> 1'b0: from internal PLL
> 1'b1: from external IO
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rv1108.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 658da17c9d99..4d87828df4f7 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -140,7 +140,7 @@ enum rv1108_plls {
>   PNAME(mux_uart0_p)		= { "uart0_src", "uart0_frac", "xin24m" };
>   PNAME(mux_uart1_p)		= { "uart1_src", "uart1_frac", "xin24m" };
>   PNAME(mux_uart2_p)		= { "uart2_src", "uart2_frac", "xin24m" };
> -PNAME(mux_sclk_mac_p)	= { "ext_gmac", "sclk_mac_pre" };
> +PNAME(mux_sclk_mac_p)	= { "sclk_mac_pre", "ext_gmac" };
>   PNAME(mux_i2s0_pre_p)		= { "i2s0_src", "i2s0_frac", "ext_i2s", "xin12m" };
>   PNAME(mux_i2s_out_p)		= { "i2s0_pre", "xin12m" };
>   PNAME(mux_i2s1_p)		= { "i2s1_src", "i2s1_frac", "dummy", "xin12m" };
> 

Acked-by: David Wu <david.wu@rock-chips.com>

  reply	other threads:[~2017-08-21 10:31 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21  8:16 [PATCH v2 0/4] clk: rockchip: rv1108: support mac clk Elaine Zhang
2017-08-21  8:16 ` Elaine Zhang
2017-08-21  8:16 ` Elaine Zhang
2017-08-21  8:16 ` [PATCH v2 1/4] clk: rockchip: add rv1108 ACLK_GAMC and PCLK_GMAC ID Elaine Zhang
2017-08-21  8:16   ` Elaine Zhang
2017-08-21  8:16   ` Elaine Zhang
2017-08-21 10:22   ` David.Wu
2017-08-21 10:22     ` David.Wu
2017-08-21 10:22     ` David.Wu
2017-08-21 10:32     ` Heiko Stuebner
2017-08-21 10:32       ` Heiko Stuebner
2017-08-21 10:32       ` Heiko Stuebner
2017-08-21 11:15       ` David.Wu
2017-08-21 11:15         ` David.Wu
2017-08-21 11:15         ` David.Wu
2017-08-21 22:39   ` Heiko Stuebner
2017-08-21 22:39     ` Heiko Stuebner
2017-08-21 22:39     ` Heiko Stuebner
2017-08-21  8:16 ` [PATCH v2 2/4] clk: rockchip: rv1108: add ACLK_GMAC and PCLK_GMAC clk id Elaine Zhang
2017-08-21  8:16   ` Elaine Zhang
2017-08-21 10:23   ` David.Wu
2017-08-21 10:23     ` David.Wu
2017-08-21 10:23     ` David.Wu
2017-08-22  0:52   ` Heiko Stuebner
2017-08-22  0:52     ` Heiko Stuebner
2017-08-21  8:16 ` [PATCH v2 3/4] clk: rockchip: rv1108: rename macphy to mac Elaine Zhang
2017-08-21  8:16   ` Elaine Zhang
2017-08-21 10:30   ` David.Wu
2017-08-21 10:30     ` David.Wu
2017-08-21 10:30     ` David.Wu
2017-08-22  0:56   ` Heiko Stuebner
2017-08-22  0:56     ` Heiko Stuebner
2017-08-22  0:56     ` Heiko Stuebner
2017-08-21  8:16 ` [PATCH v2 4/4] clk: rockchip: rv1108: fix up the clk_mac sel register description Elaine Zhang
2017-08-21  8:16   ` Elaine Zhang
2017-08-21 10:30   ` David.Wu [this message]
2017-08-21 10:30     ` David.Wu
2017-08-21 10:30     ` David.Wu
2017-08-22  0:56   ` Heiko Stuebner
2017-08-22  0:56     ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f6cae9a-b595-453f-1fd3-1858f7774cd9@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=andy.yan@rock-chips.com \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=wdc@rock-chips.com \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.