Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void

From: Helge Deller <deller@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Stephen Kitt <steve@sk2.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Tony Lindgren <tony@atomide.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Michal Simek <michal.simek@xilinx.com>,
	Wang Qing <wangqing@vivo.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Peter Jones <pjones@redhat.com>,
	Xuezhi Zhang <zhangxuezhi1@coolpad.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Gaosheng Cui <cuigaosheng1@huawei.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Xu Panda <xu.panda@zte.com.cn>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Yang Yingliang <yangyingliang@huawei.com>,
	kernel@pengutronix.de, Arnd Bergmann <arnd@arndb.de>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Yu Zhe <yuzhe@nfschina.com>, ye xingchen <ye.xingchen@zte.com.cn>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	Zeng Heng <zengheng4@huawei.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Brown <broonie@kernel.org>, Hyunwoo Kim <imv4bel@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Yihao Han <hanyihao@vivo.com>, Timur Tabi <timur@kernel.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Zhang Qilong <zhangqilong3@huawei.com>,
	Dongliang Mu <dzm91@hust.edu.cn>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void
Date: Tue, 30 May 2023 18:12:09 +0200	[thread overview]
Message-ID: <3010bce3-cc66-4ad6-50b1-7bc66bd532d4@gmx.de> (raw)
In-Reply-To: <20230530140239.qevvxcuaqufv6hwj@pengutronix.de>

Hi Uwe,

On 5/30/23 16:02, Uwe Kleine-König wrote:
> On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote:
>> On 3/19/23 00:53, Uwe Kleine-König wrote:
>>> this series adapts the platform drivers below drivers/video/fbdev to use the
>>> .remove_new() callback. Compared to the traditional .remove() callback
>>> .remove_new() returns no value. This is a good thing because the driver core
>>> doesn't (and cannot) cope for errors during remove. The only effect of a
>>> non-zero return value in .remove() is that the driver core emits a warning. The
>>> device is removed anyhow and an early return from .remove() usually yields a
>>> resource leak.
>>>
>>> By changing the remove callback to return void driver authors cannot
>>> reasonably assume any more that there is some kind of cleanup later.
>>>
>>> The first patch simplifies the remove callback of one driver to obviously
>>> always return zero. After that all drivers are converted trivially to
>>> .remove_new().
>>
>> Thanks for that patch series. It's a nice cleanup.
>> I've applied it to the fbdev "for-next" git tree for now to get some compile testing.
>> I hope that's ok for you.
>
> I found patches #7 up to #51 in next, but the first 6 patches are
> missing. I guess this wasn't' done on purpose?

Strange. I don't know why I didn't applied those.

Anyway, I've just added them now:

Applying: video: fbdev: au1100fb: Drop if with an always false condition
Applying: video: fbdev: arcfb: Convert to platform remove callback returning void
Applying: video: fbdev: au1100fb: Convert to platform remove callback returning void
Applying: video: fbdev: au1200fb: Convert to platform remove callback returning void
Applying: video: fbdev: broadsheetfb: Convert to platform remove callback returning void
Applying: video: fbdev: bw2: Convert to platform remove callback returning void

Thanks!
Helge

Btw... I cleaned up some minor whitespace issues in patch 3 (au1100fb).