From: Tom Lendacky <thomas.lendacky@amd.com>
To: Rob Herring <robh@kernel.org>,
soc@kernel.org, Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/arm64: dts: Removed undocumented and unused "pl022,hierarchy" property
Date: Fri, 29 Sep 2023 08:29:03 -0500 [thread overview]
Message-ID: <30e381f6-8f7c-a654-255f-ac8410d4fed0@amd.com> (raw)
In-Reply-To: <20230928190859.1072420-1-robh@kernel.org>
On 9/28/23 14:08, Rob Herring wrote:
> The "pl022,hierarchy" is not documented, all instances use are 0 and
> isn't handled in the kernel driver, so let's just remove it.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> Arnd, Please apply this directly.
>
> arch/arm/boot/dts/st/spear1310-evb.dts | 2 --
> arch/arm/boot/dts/st/spear1340-evb.dts | 2 --
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts | 1 -
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts | 1 -
> arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 2 --
> 5 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/spear1310-evb.dts b/arch/arm/boot/dts/st/spear1310-evb.dts
> index 05408df38203..18191a87f07c 100644
> --- a/arch/arm/boot/dts/st/spear1310-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1310-evb.dts
> @@ -352,7 +352,6 @@ stmpe610@0 {
> #size-cells = <0>;
> spi-max-frequency = <1000000>;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> @@ -385,7 +384,6 @@ flash@1 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> diff --git a/arch/arm/boot/dts/st/spear1340-evb.dts b/arch/arm/boot/dts/st/spear1340-evb.dts
> index 7700f2afc128..cea624fc745c 100644
> --- a/arch/arm/boot/dts/st/spear1340-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1340-evb.dts
> @@ -445,7 +445,6 @@ flash@0 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> @@ -461,7 +460,6 @@ stmpe610@1 {
> spi-max-frequency = <1000000>;
> spi-cpha;
> reg = <1>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> index 21149acb6b31..1a65f1ec183d 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> @@ -64,7 +64,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> index 99205ae1b46b..52f8d36295a8 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> @@ -76,7 +76,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> index fbf0392b8371..dec5a110f1e8 100644
> --- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> +++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> @@ -113,7 +113,6 @@ slic@0 {
> spi-max-frequency = <5000000>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;
> @@ -137,7 +136,6 @@ at25@0 {
> at25,page-size = <64>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;
WARNING: multiple messages have this Message-ID (diff)
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Rob Herring <robh@kernel.org>,
soc@kernel.org, Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/arm64: dts: Removed undocumented and unused "pl022,hierarchy" property
Date: Fri, 29 Sep 2023 08:29:03 -0500 [thread overview]
Message-ID: <30e381f6-8f7c-a654-255f-ac8410d4fed0@amd.com> (raw)
In-Reply-To: <20230928190859.1072420-1-robh@kernel.org>
On 9/28/23 14:08, Rob Herring wrote:
> The "pl022,hierarchy" is not documented, all instances use are 0 and
> isn't handled in the kernel driver, so let's just remove it.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> Arnd, Please apply this directly.
>
> arch/arm/boot/dts/st/spear1310-evb.dts | 2 --
> arch/arm/boot/dts/st/spear1340-evb.dts | 2 --
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts | 1 -
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts | 1 -
> arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 2 --
> 5 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/spear1310-evb.dts b/arch/arm/boot/dts/st/spear1310-evb.dts
> index 05408df38203..18191a87f07c 100644
> --- a/arch/arm/boot/dts/st/spear1310-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1310-evb.dts
> @@ -352,7 +352,6 @@ stmpe610@0 {
> #size-cells = <0>;
> spi-max-frequency = <1000000>;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> @@ -385,7 +384,6 @@ flash@1 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> diff --git a/arch/arm/boot/dts/st/spear1340-evb.dts b/arch/arm/boot/dts/st/spear1340-evb.dts
> index 7700f2afc128..cea624fc745c 100644
> --- a/arch/arm/boot/dts/st/spear1340-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1340-evb.dts
> @@ -445,7 +445,6 @@ flash@0 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> @@ -461,7 +460,6 @@ stmpe610@1 {
> spi-max-frequency = <1000000>;
> spi-cpha;
> reg = <1>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> index 21149acb6b31..1a65f1ec183d 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> @@ -64,7 +64,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> index 99205ae1b46b..52f8d36295a8 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> @@ -76,7 +76,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> index fbf0392b8371..dec5a110f1e8 100644
> --- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> +++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> @@ -113,7 +113,6 @@ slic@0 {
> spi-max-frequency = <5000000>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;
> @@ -137,7 +136,6 @@ at25@0 {
> at25,page-size = <64>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-29 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 19:08 [PATCH] arm/arm64: dts: Removed undocumented and unused "pl022,hierarchy" property Rob Herring
2023-09-28 19:08 ` Rob Herring
2023-09-29 3:34 ` Viresh Kumar
2023-09-29 3:34 ` Viresh Kumar
2023-09-29 13:29 ` Tom Lendacky [this message]
2023-09-29 13:29 ` Tom Lendacky
2023-10-18 15:40 ` patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e381f6-8f7c-a654-255f-ac8410d4fed0@amd.com \
--to=thomas.lendacky@amd.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.