From: Heiko Stuebner <heiko@sntech.de>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: disable GPU 500 MHz OPP for veyron
Date: Wed, 22 May 2019 11:14:29 +0200 [thread overview]
Message-ID: <3108277.JP5bvJISVS@phil> (raw)
In-Reply-To: <20190520220051.54847-1-mka@chromium.org>
Am Dienstag, 21. Mai 2019, 00:00:49 CEST schrieb Matthias Kaehlcke:
> The NPLL is the only safe way to generate 500 MHz for the GPU. The
> downstream Chrome OS 3.14 kernel ('official' kernel for veyron
> devices) re-purposes NPLL to HDMI and hence disables the OPP for
> the GPU (see https://crrev.com/c/1574579). Disable it here as well
> to keep in sync and avoid problems in case someone decides to
> re-purpose NPLL.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
I was actually expecting to just drop the 500MHz opp from all
of rk3288 ;-) .
To not have to respin, I just modified your patch accordingly,
see [0] and please holler if you disagree :-D .
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=75481833c6dbab4c29d15452f6b4337c16f5407b
> ---
> Changes in v2:
> - patch added to the series
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 90c8312d01ff..ec10ce4fcf04 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -174,6 +174,14 @@
> temperature = <100000>;
> };
>
> +/*
> + * Remove 500 MHz since the only way to make 500 MHz is via the NPLL
> + * which might be used for HDMI.
> + */
> +&gpu_opp_table {
> + /delete-node/ opp-500000000;
> +};
> +
> &hdmi {
> ddc-i2c-bus = <&i2c5>;
> status = "okay";
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: disable GPU 500 MHz OPP for veyron
Date: Wed, 22 May 2019 11:14:29 +0200 [thread overview]
Message-ID: <3108277.JP5bvJISVS@phil> (raw)
In-Reply-To: <20190520220051.54847-1-mka@chromium.org>
Am Dienstag, 21. Mai 2019, 00:00:49 CEST schrieb Matthias Kaehlcke:
> The NPLL is the only safe way to generate 500 MHz for the GPU. The
> downstream Chrome OS 3.14 kernel ('official' kernel for veyron
> devices) re-purposes NPLL to HDMI and hence disables the OPP for
> the GPU (see https://crrev.com/c/1574579). Disable it here as well
> to keep in sync and avoid problems in case someone decides to
> re-purpose NPLL.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
I was actually expecting to just drop the 500MHz opp from all
of rk3288 ;-) .
To not have to respin, I just modified your patch accordingly,
see [0] and please holler if you disagree :-D .
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=75481833c6dbab4c29d15452f6b4337c16f5407b
> ---
> Changes in v2:
> - patch added to the series
> ---
> arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 90c8312d01ff..ec10ce4fcf04 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -174,6 +174,14 @@
> temperature = <100000>;
> };
>
> +/*
> + * Remove 500 MHz since the only way to make 500 MHz is via the NPLL
> + * which might be used for HDMI.
> + */
> +&gpu_opp_table {
> + /delete-node/ opp-500000000;
> +};
> +
> &hdmi {
> ddc-i2c-bus = <&i2c5>;
> status = "okay";
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-22 9:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 22:00 [PATCH v2 1/3] ARM: dts: rockchip: disable GPU 500 MHz OPP for veyron Matthias Kaehlcke
2019-05-20 22:00 ` Matthias Kaehlcke
2019-05-20 22:00 ` [PATCH v2 2/3] ARM: dts: rockchip: Use the GPU to cool CPU thermal zone of veyron mickey Matthias Kaehlcke
2019-05-20 22:00 ` Matthias Kaehlcke
2019-05-20 23:26 ` Doug Anderson
2019-05-20 23:26 ` Doug Anderson
2019-05-22 9:14 ` Heiko Stuebner
2019-05-22 9:14 ` Heiko Stuebner
2019-05-20 22:00 ` [PATCH v2 3/3] ARM: dts: rockchip: Configure the GPU thermal zone for mickey Matthias Kaehlcke
2019-05-20 22:00 ` Matthias Kaehlcke
2019-05-20 23:29 ` Doug Anderson
2019-05-20 23:29 ` Doug Anderson
2019-05-20 23:24 ` [PATCH v2 1/3] ARM: dts: rockchip: disable GPU 500 MHz OPP for veyron Doug Anderson
2019-05-20 23:24 ` Doug Anderson
2019-05-22 9:14 ` Heiko Stuebner [this message]
2019-05-22 9:14 ` Heiko Stuebner
2019-05-22 18:13 ` Doug Anderson
2019-05-22 18:13 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3108277.JP5bvJISVS@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.