From: Dave Gerlach <d-gerlach@ti.com>
To: Keerthy <j-keerthy@ti.com>, <vireshk@kernel.org>, <nm@ti.com>,
<sboyd@kernel.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<t-kristo@ti.com>
Subject: Re: [PATCH 2/2] opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call
Date: Mon, 12 Nov 2018 15:49:22 -0600 [thread overview]
Message-ID: <312975f3-3cbd-3ece-20b6-ceb93421a3c9@ti.com> (raw)
In-Reply-To: <1541565263-8296-3-git-send-email-j-keerthy@ti.com>
On 11/06/2018 10:34 PM, Keerthy wrote:
> _get_optimal_vdd_voltage call provides new_supply_vbb->u_volt
> as the reference voltage while it should be really new_supply_vdd->u_volt.
>
> Fixes: 9a835fa6e47 ("PM / OPP: Add ti-opp-supply driver")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
Acked-by: Dave Gerlach <d-gerlach@ti.com>
Currently all corresponding vbb and vdd values provided by the device tree match
which is why this does not fail, but this was a typo by me and vdd is the
correct value to actually use.
Regards,
Dave
> drivers/opp/ti-opp-supply.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> index 29e08a4..3f4fb4d 100644
> --- a/drivers/opp/ti-opp-supply.c
> +++ b/drivers/opp/ti-opp-supply.c
> @@ -288,7 +288,7 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> int ret;
>
> vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data,
> - new_supply_vbb->u_volt);
> + new_supply_vdd->u_volt);
>
> if (new_supply_vdd->u_volt_min < vdd_uv)
> new_supply_vdd->u_volt_min = vdd_uv;
>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Gerlach <d-gerlach@ti.com>
To: Keerthy <j-keerthy@ti.com>,
vireshk@kernel.org, nm@ti.com, sboyd@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com
Subject: Re: [PATCH 2/2] opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call
Date: Mon, 12 Nov 2018 15:49:22 -0600 [thread overview]
Message-ID: <312975f3-3cbd-3ece-20b6-ceb93421a3c9@ti.com> (raw)
In-Reply-To: <1541565263-8296-3-git-send-email-j-keerthy@ti.com>
On 11/06/2018 10:34 PM, Keerthy wrote:
> _get_optimal_vdd_voltage call provides new_supply_vbb->u_volt
> as the reference voltage while it should be really new_supply_vdd->u_volt.
>
> Fixes: 9a835fa6e47 ("PM / OPP: Add ti-opp-supply driver")
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
Acked-by: Dave Gerlach <d-gerlach@ti.com>
Currently all corresponding vbb and vdd values provided by the device tree match
which is why this does not fail, but this was a typo by me and vdd is the
correct value to actually use.
Regards,
Dave
> drivers/opp/ti-opp-supply.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> index 29e08a4..3f4fb4d 100644
> --- a/drivers/opp/ti-opp-supply.c
> +++ b/drivers/opp/ti-opp-supply.c
> @@ -288,7 +288,7 @@ static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> int ret;
>
> vdd_uv = _get_optimal_vdd_voltage(dev, &opp_data,
> - new_supply_vbb->u_volt);
> + new_supply_vdd->u_volt);
>
> if (new_supply_vdd->u_volt_min < vdd_uv)
> new_supply_vdd->u_volt_min = vdd_uv;
>
next prev parent reply other threads:[~2018-11-12 21:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 4:34 [PATCH 0/2] opp: ti-opp-supply: Fixes Keerthy
2018-11-07 4:34 ` Keerthy
2018-11-07 4:34 ` [PATCH 1/2] opp: ti-opp-supply: Dynamically update u_volt_min Keerthy
2018-11-07 4:34 ` Keerthy
2018-11-08 5:54 ` Viresh Kumar
2018-11-12 3:15 ` J, KEERTHY
2018-11-12 3:15 ` J, KEERTHY
2018-11-12 22:05 ` Dave Gerlach
2018-11-12 22:05 ` Dave Gerlach
2018-11-07 4:34 ` [PATCH 2/2] opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call Keerthy
2018-11-07 4:34 ` Keerthy
2018-11-12 21:49 ` Dave Gerlach [this message]
2018-11-12 21:49 ` Dave Gerlach
2018-11-08 5:53 ` [PATCH 0/2] opp: ti-opp-supply: Fixes Viresh Kumar
2018-11-13 4:12 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312975f3-3cbd-3ece-20b6-ceb93421a3c9@ti.com \
--to=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.