From: Thomas Richard <thomas.richard@bootlin.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq
Date: Fri, 19 Jan 2024 18:01:33 +0100 [thread overview]
Message-ID: <31c42f08-7d5e-4b91-87e9-bfc7e2cfdefe@bootlin.com> (raw)
In-Reply-To: <20240116074333.GO5185@atomide.com>
Hello Tony,
On 1/16/24 08:43, Tony Lindgren wrote:
> * Thomas Richard <thomas.richard@bootlin.com> [240115 16:16]:
>> Some IOs can be needed during suspend_noirq/resume_noirq.
>> So move suspend/resume callbacks to noirq.
>
> So have you checked that the pca953x_save_context() and restore works
> this way? There's i2c traffic and regulators may sleep.. I wonder if
> you instead just need to leave gpio-pca953x enabled in some cases
> instead?
>
Yes I tested it, and it works (with my setup).
But this patch may have an impact for other people.
How could I leave it enabled in some cases ?
Regards,
--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Richard <thomas.richard@bootlin.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq
Date: Fri, 19 Jan 2024 18:01:33 +0100 [thread overview]
Message-ID: <31c42f08-7d5e-4b91-87e9-bfc7e2cfdefe@bootlin.com> (raw)
In-Reply-To: <20240116074333.GO5185@atomide.com>
Hello Tony,
On 1/16/24 08:43, Tony Lindgren wrote:
> * Thomas Richard <thomas.richard@bootlin.com> [240115 16:16]:
>> Some IOs can be needed during suspend_noirq/resume_noirq.
>> So move suspend/resume callbacks to noirq.
>
> So have you checked that the pca953x_save_context() and restore works
> this way? There's i2c traffic and regulators may sleep.. I wonder if
> you instead just need to leave gpio-pca953x enabled in some cases
> instead?
>
Yes I tested it, and it works (with my setup).
But this patch may have an impact for other people.
How could I leave it enabled in some cases ?
Regards,
--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Richard <thomas.richard@bootlin.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andy Shevchenko" <andy@kernel.org>,
"Haojian Zhuang" <haojian.zhuang@linaro.org>,
"Vignesh R" <vigneshr@ti.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Peter Rosin" <peda@axentia.se>, "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tom Joseph" <tjoseph@cadence.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
linux-pci@vger.kernel.org, gregory.clement@bootlin.com,
theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com,
u-kumar1@ti.com
Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq
Date: Fri, 19 Jan 2024 18:01:33 +0100 [thread overview]
Message-ID: <31c42f08-7d5e-4b91-87e9-bfc7e2cfdefe@bootlin.com> (raw)
In-Reply-To: <20240116074333.GO5185@atomide.com>
Hello Tony,
On 1/16/24 08:43, Tony Lindgren wrote:
> * Thomas Richard <thomas.richard@bootlin.com> [240115 16:16]:
>> Some IOs can be needed during suspend_noirq/resume_noirq.
>> So move suspend/resume callbacks to noirq.
>
> So have you checked that the pca953x_save_context() and restore works
> this way? There's i2c traffic and regulators may sleep.. I wonder if
> you instead just need to leave gpio-pca953x enabled in some cases
> instead?
>
Yes I tested it, and it works (with my setup).
But this patch may have an impact for other people.
How could I leave it enabled in some cases ?
Regards,
--
Thomas Richard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-19 17:01 UTC|newest]
Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 16:14 [PATCH 00/14] Add suspend to ram support for PCIe on J7200 Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 19:56 ` Andy Shevchenko
2024-01-15 19:56 ` Andy Shevchenko
2024-01-15 19:56 ` Andy Shevchenko
2024-01-19 15:50 ` Thomas Richard
2024-01-19 15:50 ` Thomas Richard
2024-01-19 15:50 ` Thomas Richard
2024-01-16 7:43 ` Tony Lindgren
2024-01-16 7:43 ` Tony Lindgren
2024-01-16 7:43 ` Tony Lindgren
2024-01-19 17:01 ` Thomas Richard [this message]
2024-01-19 17:01 ` Thomas Richard
2024-01-19 17:01 ` Thomas Richard
2024-01-28 0:12 ` Linus Walleij
2024-01-28 0:12 ` Linus Walleij
2024-01-28 0:12 ` Linus Walleij
2024-02-08 16:19 ` Thomas Richard
2024-02-08 16:19 ` Thomas Richard
2024-02-08 16:19 ` Thomas Richard
2024-02-08 16:53 ` Bartosz Golaszewski
2024-02-08 16:53 ` Bartosz Golaszewski
2024-02-08 16:53 ` Bartosz Golaszewski
2024-02-08 21:29 ` Linus Walleij
2024-02-08 21:29 ` Linus Walleij
2024-02-08 21:29 ` Linus Walleij
2024-02-09 7:44 ` Thomas Richard
2024-02-09 7:44 ` Thomas Richard
2024-02-09 7:44 ` Thomas Richard
2024-02-09 10:50 ` Linus Walleij
2024-02-09 10:50 ` Linus Walleij
2024-02-09 10:50 ` Linus Walleij
2024-01-15 16:14 ` [PATCH 02/14] pinctrl: pinctrl-single: " Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 20:02 ` Andy Shevchenko
2024-01-15 20:02 ` Andy Shevchenko
2024-01-15 20:02 ` Andy Shevchenko
2024-01-19 16:08 ` Thomas Richard
2024-01-19 16:08 ` Thomas Richard
2024-01-19 16:08 ` Thomas Richard
2024-01-19 16:11 ` Andy Shevchenko
2024-01-19 16:11 ` Andy Shevchenko
2024-01-19 16:11 ` Andy Shevchenko
2024-01-22 14:33 ` Thomas Richard
2024-01-22 14:33 ` Thomas Richard
2024-01-22 14:33 ` Thomas Richard
2024-01-23 12:44 ` Andy Shevchenko
2024-01-23 12:44 ` Andy Shevchenko
2024-01-23 12:44 ` Andy Shevchenko
2024-01-31 8:05 ` Linus Walleij
2024-01-31 8:05 ` Linus Walleij
2024-01-31 8:05 ` Linus Walleij
2024-01-15 16:14 ` [PATCH 03/14] i2c: omap: wakeup the controller during suspend callback Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 20:03 ` Andy Shevchenko
2024-01-15 20:03 ` Andy Shevchenko
2024-01-15 20:03 ` Andy Shevchenko
2024-01-15 16:14 ` [PATCH 04/14] mux: mmio: Add resume support Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 20:05 ` Andy Shevchenko
2024-01-15 20:05 ` Andy Shevchenko
2024-01-15 20:05 ` Andy Shevchenko
2024-01-15 22:31 ` Peter Rosin
2024-01-15 22:31 ` Peter Rosin
2024-01-15 22:31 ` Peter Rosin
2024-01-19 16:25 ` Thomas Richard
2024-01-19 16:25 ` Thomas Richard
2024-01-19 16:25 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 05/14] phy: ti: phy-j721e-wiz: make wiz_clock_init callable multiple times Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-23 7:18 ` Vinod Koul
2024-01-23 7:18 ` Vinod Koul
2024-01-23 7:18 ` Vinod Koul
2024-01-23 8:20 ` Thomas Richard
2024-01-23 8:20 ` Thomas Richard
2024-01-23 8:20 ` Thomas Richard
2024-01-23 14:02 ` Vinod Koul
2024-01-23 14:02 ` Vinod Koul
2024-01-23 14:02 ` Vinod Koul
2024-01-15 16:14 ` [PATCH 06/14] phy: ti: phy-j721e-wiz: add resume support Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 07/14] phy: cadence-torrent: extract calls to clk_get from cdns_torrent_clk Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 08/14] phy: cadence-torrent: register resets even if the phy is already configured Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 09/14] phy: cadence-torrent: move already_configured to struct cdns_torrent_phy Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 10/14] phy: cadence-torrent: remove noop_ops phy operations Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 11/14] phy: cadence-torrent: add suspend and resume support Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-16 18:22 ` Bjorn Helgaas
2024-01-16 18:22 ` Bjorn Helgaas
2024-01-16 18:22 ` Bjorn Helgaas
2024-01-22 14:24 ` Thomas Richard
2024-01-22 14:24 ` Thomas Richard
2024-01-22 14:24 ` Thomas Richard
2024-01-17 15:12 ` Philipp Zabel
2024-01-17 15:12 ` Philipp Zabel
2024-01-17 15:12 ` Philipp Zabel
2024-01-22 14:28 ` Thomas Richard
2024-01-22 14:28 ` Thomas Richard
2024-01-22 14:28 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 12/14] PCI: cadence: add resume support to cdns_pcie_host_setup() Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` [PATCH 13/14] PCI: j721e: move reset GPIO to device struct Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 20:08 ` Andy Shevchenko
2024-01-15 20:08 ` Andy Shevchenko
2024-01-15 20:08 ` Andy Shevchenko
2024-01-16 18:19 ` Bjorn Helgaas
2024-01-16 18:19 ` Bjorn Helgaas
2024-01-16 18:19 ` Bjorn Helgaas
2024-01-15 16:14 ` [PATCH 14/14] PCI: j721e: add suspend and resume support Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 16:14 ` Thomas Richard
2024-01-15 20:13 ` Andy Shevchenko
2024-01-15 20:13 ` Andy Shevchenko
2024-01-15 20:13 ` Andy Shevchenko
2024-01-22 15:30 ` Thomas Richard
2024-01-22 15:30 ` Thomas Richard
2024-01-22 15:30 ` Thomas Richard
2024-01-22 21:36 ` Andy Shevchenko
2024-01-22 21:36 ` Andy Shevchenko
2024-01-22 21:36 ` Andy Shevchenko
2024-01-24 14:09 ` Thomas Richard
2024-01-24 14:09 ` Thomas Richard
2024-01-24 14:09 ` Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31c42f08-7d5e-4b91-87e9-bfc7e2cfdefe@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@linaro.org \
--cc=jmkrzyszt@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.