From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>,
peter.griffin@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
tudor.ambarus@linaro.org, willmcvicker@google.com,
semen.protsenko@linaro.org, alim.akhtar@samsung.com,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on
Date: Thu, 1 Feb 2024 10:58:15 +0100 [thread overview]
Message-ID: <31c4afb2-b80a-4f41-bc09-badf8aa5818f@linaro.org> (raw)
In-Reply-To: <20240130093812.1746512-2-andre.draszik@linaro.org>
On 30/01/2024 10:36, André Draszik wrote:
> This pclk clock is required any time we access the pinctrl registers of
> this block.
>
> Since pinctrl-samsung doesn't support a clock at the moment, we just
> keep the kernel from disabling it at boot, until we have an update for
> pinctrl-samsung to handle this required clock, at which point we'll be
> able to drop the flag again.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
Dropped fixes tag. The driver looks correct, it's pinctrl issue.
I really dislike how these patches are inter-mixed with DTS. Makes
applying difficult and confuses about dependencies.
I assume there are no dependencies here.
I am repeating this and repeating, but in future I will just reject the
patches:
Your DTS and driver changes cannot depend on each other for new feature
submissions.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "André Draszik" <andre.draszik@linaro.org>,
peter.griffin@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
tudor.ambarus@linaro.org, willmcvicker@google.com,
semen.protsenko@linaro.org, alim.akhtar@samsung.com,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on
Date: Thu, 1 Feb 2024 10:58:15 +0100 [thread overview]
Message-ID: <31c4afb2-b80a-4f41-bc09-badf8aa5818f@linaro.org> (raw)
In-Reply-To: <20240130093812.1746512-2-andre.draszik@linaro.org>
On 30/01/2024 10:36, André Draszik wrote:
> This pclk clock is required any time we access the pinctrl registers of
> this block.
>
> Since pinctrl-samsung doesn't support a clock at the moment, we just
> keep the kernel from disabling it at boot, until we have an update for
> pinctrl-samsung to handle this required clock, at which point we'll be
> able to drop the flag again.
>
> Fixes: 893f133a040b ("clk: samsung: gs101: add support for cmu_peric0")
Dropped fixes tag. The driver looks correct, it's pinctrl issue.
I really dislike how these patches are inter-mixed with DTS. Makes
applying difficult and confuses about dependencies.
I assume there are no dependencies here.
I am repeating this and repeating, but in future I will just reject the
patches:
Your DTS and driver changes cannot depend on each other for new feature
submissions.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-01 9:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:36 [PATCH v2 0/6] gs101 oriole: peripheral block 0 (peric0) fixes André Draszik
2024-01-30 9:36 ` André Draszik
2024-01-30 9:36 ` [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 9:58 ` Krzysztof Kozlowski [this message]
2024-02-01 9:58 ` Krzysztof Kozlowski
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-02-01 10:36 ` Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 2/6] arm64: dts: exynos: gs101: fix usi8 default mode André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 10:16 ` Krzysztof Kozlowski
2024-02-01 10:16 ` Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 3/6] arm64: dts: exynos: gs101: use correct clocks for usi8 André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-02-01 10:36 ` Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 4/6] arm64: dts: exynos: gs101: use correct clocks for usi_uart André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-02-01 10:36 ` Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential clocks as critical André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 10:02 ` Krzysztof Kozlowski
2024-02-01 10:02 ` Krzysztof Kozlowski
2024-02-01 15:23 ` André Draszik
2024-02-01 15:23 ` André Draszik
2024-01-30 9:36 ` [PATCH v2 6/6] arm64: dts: exynos: gs101: reorder hsi2c_8 pinctrl-* properties André Draszik
2024-01-30 9:36 ` André Draszik
2024-02-01 10:04 ` Krzysztof Kozlowski
2024-02-01 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31c4afb2-b80a-4f41-bc09-badf8aa5818f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.