From: Robin Murphy <robin.murphy@arm.com>
To: Peter Geis <pgwipeout@gmail.com>, Dmitry Osipenko <digetx@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c
Date: Mon, 20 Dec 2021 11:54:32 +0000 [thread overview]
Message-ID: <320d0e55-0202-a7cf-a021-f9a49e0e2f66@arm.com> (raw)
In-Reply-To: <CAMdYzYrDp5zcRJ=TudtiAtviJVMyNmqB5TMNYZ=XN+mb3paSTQ@mail.gmail.com>
On 2021-12-17 18:42, Peter Geis wrote:
> On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 17.12.2021 21:16, Peter Geis пишет:
>>>>> + break;
>>>>> + default:
>>>>> + dev_info(&client->dev, "pmic controlled board reset not supported\n");
>>
>> I'd change this dev_info to dev_dbg to not clutter KMSG.
>
> I'd prefer to leave this as info, since the device is designated as
> the system power controller but it is only capable of powering down
> the system, not rebooting it.
> But on second thought, anyone who's making these changes would be
> investigating the driver anyway.
> So I'll change it to dev_dbg.
Indeed, this is the expected case for RK808, which has to be
system-power-controller if you want shutdown to actually power off.
Cheers,
Robin.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Peter Geis <pgwipeout@gmail.com>, Dmitry Osipenko <digetx@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c
Date: Mon, 20 Dec 2021 11:54:32 +0000 [thread overview]
Message-ID: <320d0e55-0202-a7cf-a021-f9a49e0e2f66@arm.com> (raw)
In-Reply-To: <CAMdYzYrDp5zcRJ=TudtiAtviJVMyNmqB5TMNYZ=XN+mb3paSTQ@mail.gmail.com>
On 2021-12-17 18:42, Peter Geis wrote:
> On Fri, Dec 17, 2021 at 1:30 PM Dmitry Osipenko <digetx@gmail.com> wrote:
>>
>> 17.12.2021 21:16, Peter Geis пишет:
>>>>> + break;
>>>>> + default:
>>>>> + dev_info(&client->dev, "pmic controlled board reset not supported\n");
>>
>> I'd change this dev_info to dev_dbg to not clutter KMSG.
>
> I'd prefer to leave this as info, since the device is designated as
> the system power controller but it is only capable of powering down
> the system, not rebooting it.
> But on second thought, anyone who's making these changes would be
> investigating the driver anyway.
> So I'll change it to dev_dbg.
Indeed, this is the expected case for RK808, which has to be
system-power-controller if you want shutdown to actually power off.
Cheers,
Robin.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-12-20 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 14:55 [PATCH v2] mfd: rk808: add reboot support to rk808.c Peter Geis
2021-12-17 14:55 ` Peter Geis
2021-12-17 15:29 ` Dmitry Osipenko
2021-12-17 15:29 ` Dmitry Osipenko
2021-12-17 18:16 ` Peter Geis
2021-12-17 18:16 ` Peter Geis
2021-12-17 18:30 ` Dmitry Osipenko
2021-12-17 18:30 ` Dmitry Osipenko
2021-12-17 18:42 ` Peter Geis
2021-12-17 18:42 ` Peter Geis
2021-12-20 11:54 ` Robin Murphy [this message]
2021-12-20 11:54 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320d0e55-0202-a7cf-a021-f9a49e0e2f66@arm.com \
--to=robin.murphy@arm.com \
--cc=digetx@gmail.com \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.