Re: [PATCH 00/15] XSM/FLASK updates for 4.8

From: Doug Goldstein <cardoe@cardoe.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>, xen-devel@lists.xen.org
Subject: Re: [PATCH 00/15] XSM/FLASK updates for 4.8
Date: Mon, 20 Jun 2016 00:40:58 -0500	[thread overview]
Message-ID: <3245e06e-694a-3769-1100-02592759a2c8@cardoe.com> (raw)
In-Reply-To: <1465483638-9489-1-git-send-email-dgdegra@tycho.nsa.gov>

[-- Attachment #1.1.1: Type: text/plain, Size: 2089 bytes --]

On 6/9/16 9:47 AM, Daniel De Graaf wrote:
> Some of these patches have been posted before (patch 11 was posted in
> 2014; an earlier variant of 1-6 and 15 were posted recently as RFC).
> The rest are mostly removal of unused code or other cleanup.
> 
> FLASK policy updates:
> [PATCH 01/15] flask/policy: split into modules
> [PATCH 02/15] flask/policy: split out rules for system_r
> [PATCH 03/15] flask/policy: move user definitions and constraints
> [PATCH 04/15] flask/policy: remove unused support for binary modules
> [PATCH 05/15] flask/policy: xenstore stubdom policy
> [PATCH 06/15] flask/policy: remove unused example
> 
> Hypervisor updates to the FLASK security server:
> [PATCH 07/15] flask: unify {get,set}vcpucontext permissions
> [PATCH 08/15] flask: remove unused secondary context in ocontext
> [PATCH 09/15] flask: remove unused AVC callback functions
> [PATCH 10/15] flask: remove xen_flask_userlist operation
> [PATCH 11/15] flask: improve unknown permission handling
> 
> Hypervisor updates to the XSM framework:
> [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section
> [PATCH 13/15] xsm: annotate setup functions with __init
> [PATCH 14/15] xsm: clean up unregistration
> [PATCH 15/15] xsm: add a default policy to .init.data
> 

I've reviewed the whole series at this point. I'd honestly like to see
at least the first 6 patches land into staging at this point. There's
two R-b's (mine and Konrad's) and no comments that would imply a change
needs to happen. Those 6 stand on their own as well. There are no ACKs
since Daniel is the only maintainer for those changes.

I can rebase some changes I've got locally for a custom policy (honestly
Daniel's changes will make it easier/better for me) and give it a full
on test Monday morning if there is any concerns.

The other patches in the series can mostly get my R-b as well. I do have
some of the same comments / concerns that have already been brought up
so I'll go through and add my R-b to the clean patches and wait for a v2
of the others.

-- 
Doug Goldstein

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel