Re: [PATCH 10/15] flask: remove xen_flask_userlist operation

From: "Jan Beulich" <JBeulich@suse.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH 10/15] flask: remove xen_flask_userlist operation
Date: Fri, 10 Jun 2016 00:51:27 -0600	[thread overview]
Message-ID: <575A7F8F02000078000F3D2E@prv-mh.provo.novell.com> (raw)
In-Reply-To: <63b90c1b-ae23-21ba-ff29-d0dbebc8b45c@tycho.nsa.gov>

>>> On 09.06.16 at 18:43, <dgdegra@tycho.nsa.gov> wrote:
> On 06/09/2016 12:07 PM, Jan Beulich wrote:
>>>>> On 09.06.16 at 16:47, <dgdegra@tycho.nsa.gov> wrote:
>>> --- a/xen/include/public/xsm/flask_op.h
>>> +++ b/xen/include/public/xsm/flask_op.h
>>> @@ -70,20 +70,6 @@ struct xen_flask_transition {
>>>      uint32_t newsid;
>>>  };
>>>
>>> -struct xen_flask_userlist {
>>> -    /* IN: starting SID for list */
>>> -    uint32_t start_sid;
>>> -    /* IN: size of user string and output buffer
>>> -     * OUT: number of SIDs returned */
>>> -    uint32_t size;
>>> -    union {
>>> -        /* IN: user to enumerate SIDs */
>>> -        XEN_GUEST_HANDLE(char) user;
>>> -        /* OUT: SID list */
>>> -        XEN_GUEST_HANDLE(uint32) sids;
>>> -    } u;
>>> -};
>>
>> No known users or not, we don't normally allow breaking code that
>> may be consuming any of our public headers. I.e. conventionally,
>> for interfaces not restricted to the tool stack we keep everything,
>> but guard it with a __XEN_INTERFACE_VERSION__ conditional.
>>
>> Whether making an exception here is okay I'm not certain; in any
>> event would you imo need to bump XEN_FLASK_INTERFACE_VERSION.
> 
> OK, then I'll drop this patch.

Well, no, please don't drop it, make it add aforementioned #if-s.
(And after thinking about it again, bumping the interface version
doesn't seem to make sense for a plain removal.)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel