Re: [PATCH v5 08/14] dt-bindings: thermal: Add fsl,scu-thermal yaml file

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viorel Suman <viorel.suman@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>, Stefan Agner <stefan@agner.ch>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Oliver Graute <oliver.graute@kococonnector.com>,
	Mirela Rabulea <mirela.rabulea@nxp.com>,
	Peng Fan <peng.fan@nxp.com>, Liu Ying <victor.liu@nxp.com>,
	Ming Qian <ming.qian@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-input@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Abel Vesa <abel.vesa@nxp.com>
Subject: Re: [PATCH v5 08/14] dt-bindings: thermal: Add fsl,scu-thermal yaml file
Date: Fri, 24 Jun 2022 12:18:20 +0200	[thread overview]
Message-ID: <326d3cc2-3af7-ee08-3fd2-91dcf30ef5fa@linaro.org> (raw)
In-Reply-To: <20220616164303.790379-9-viorel.suman@nxp.com>

On 16/06/2022 18:42, Viorel Suman wrote:
> From: Abel Vesa <abel.vesa@nxp.com>
> 
> In order to replace the fsl,scu txt file from bindings/arm/freescale,
> we need to split it between the right subsystems. This patch documents
> separately the 'thermal' child node of the SCU main node.
> 
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> ---
>  .../bindings/thermal/fsl,scu-thermal.yaml     | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml b/Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml
> new file mode 100644
> index 000000000000..8f2646a18ef0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/fsl,scu-thermal.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/fsl,scu-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: i.MX SCU Client Device Node - Thermal bindings based on SCU Message Protocol
> +
> +maintainers:
> +  - Dong Aisheng <aisheng.dong@nxp.com>
> +
> +description: i.MX SCU Client Device Node
> +  Client nodes are maintained as children of the relevant IMX-SCU device node.
> +
> +allOf:
> +  - $ref: /schemas/thermal/thermal-sensor.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: fsl,imx8qxp-sc-thermal
> +      - const: fsl,imx-sc-thermal
> +
> +  '#thermal-sensor-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - '#thermal-sensor-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    thermal-sensor {

Wrong indentation.

> +             compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-thermal";
> +             #thermal-sensor-cells = <1>;
> +    };

Best regards,
Krzysztof