Re: [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal

From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: akolli@codeaurora.org
Cc: akolli@qti.qualcomm.com, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: Add BMI parameters to fix calibration from DT/pre-cal
Date: Fri, 08 Dec 2017 14:40:14 +0100	[thread overview]
Message-ID: <3432385.m9oFIzB3n7@sven-edge> (raw)
In-Reply-To: <637ab47b1794b409e595b7e219cd904f@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]

On Freitag, 8. Dezember 2017 18:05:38 CET akolli@codeaurora.org wrote:
> On 2017-12-08 17:42, Sven Eckelmann wrote:
> > On Donnerstag, 25. Mai 2017 16:21:23 CET akolli@qti.qualcomm.com wrote:
> >> From: Anilkumar Kolli <akolli@qti.qualcomm.com>
> >> 
> >> QCA99X0, QCA9888, QCA9984 supports calibration data in
> >> either OTP or DT/pre-cal file. Current ath10k supports
> >> Calibration data from OTP only.
[...]
> > Just tried this on an QCA9984 which doesn't seem to have the
> > calibration data in the PCI EEPROM.
> > 
> >     [   71.728929] ath10k_pci 0000:01:00.0: qca9984/qca9994 hw1.0
> > target 0x01000000 chip_id 0x00000000 sub 168c:cafe
> >     [   71.732926] ath10k_pci 0000:01:00.0: kconfig debug 1 debugfs 1
> > tracing 0 dfs 1 testmode 1
> >     [   71.752282] ath10k_pci 0000:01:00.0: firmware ver
> > 10.4-ct-9984-fW-009-dfa0083 api 5 features peer-flow-ctrl crc32
> > 7198d117
> >     [   73.805730] ath10k_pci 0000:01:00.0: unable to read from the 
> > device
> >     [   73.805769] ath10k_pci 0000:01:00.0: could not execute otp for
> > board id check: -110
> > 
> 
> 'ATH10K driver <-> 10.4 firmware' expects cal data to be either in 
> EEPROM or pre-cal-file or DT.
> Hope the error is observed when there is no cal data loaded.

The problem happens when pre-cal data file is loaded using the userspace 
helper on the QCA9984. I was only able to use the device when I (for a test) 
used the pre-cal data as cal-data (file).

The EEPROM on the on the PCI device doesn't seem to be populated with a valid 
pre-cal data. I've already tested it with a QCA9984 device which had pre-cal 
data in the PCI device's EEPROM and this worked fine (without cal file and 
without pre-cal file).

> > It works when I use the pre-cal data as calibration data. The checksum 
> > in the
> > pre-cal seems to be correct. Also the pre-cal data from 0:ART for the 
> > 2.4GHz
> > and 5GHz QCA4019 seem to work perfectly fine.
> > 
> 
> Do you mean this patch works for only QCA4019 and not working for 
> QCA9984 ?

Worked fine for QCA4019 and QCA9888 - but I had no luck with QCA9984. The 
error shown above it the only thing I get.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]