From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
nathanl@linux.ibm.com, arnd@arndb.de, tglx@linutronix.de,
vincenzo.frascino@arm.com, luto@kernel.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: Re: [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation.
Date: Fri, 17 Jan 2020 10:26:56 +0100 [thread overview]
Message-ID: <345e2772-cde9-7d86-874e-347db1453c80@c-s.fr> (raw)
In-Reply-To: <20200117085851.GS3191@gate.crashing.org>
Le 17/01/2020 à 09:58, Segher Boessenkool a écrit :
> Hi!
>
> On Thu, Jan 16, 2020 at 05:58:24PM +0000, Christophe Leroy wrote:
>> On a powerpc8xx, with current powerpc/32 ASM VDSO:
>>
>> gettimeofday: vdso: 907 nsec/call
>> clock-getres-realtime: vdso: 484 nsec/call
>> clock-gettime-realtime: vdso: 899 nsec/call
>>
>> The first patch adds VDSO generic C support without any changes to common code.
>> Performance is as follows:
>>
>> gettimeofday: vdso: 1211 nsec/call
>> clock-getres-realtime: vdso: 722 nsec/call
>> clock-gettime-realtime: vdso: 1216 nsec/call
>>
>> Then a few changes in the common code have allowed performance improvement. At
>> the end of the series we have:
>>
>> gettimeofday: vdso: 974 nsec/call
>> clock-getres-realtime: vdso: 545 nsec/call
>> clock-gettime-realtime: vdso: 941 nsec/call
>>
>> The final result is rather close to pure ASM VDSO:
>> * 7% more on gettimeofday (9 cycles)
>> * 5% more on clock-gettime-realtime (6 cycles)
>> * 12% more on clock-getres-realtime (8 cycles)
>
> Nice! Much better.
>
> It should be tested on more representative hardware, too, but this looks
> promising alright :-)
>
Yes.
Now the challenge is to get VDSO32 buildable on PPC64. The big issue is
that in most powerpc/include/asm/*.h , CONFIG_PPC64 is used to know if
the build is a 64 bits build or a 32 bits build, so VDSO32 build fails.
I don't know how this could be easily fixed.
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: nathanl@linux.ibm.com, arnd@arndb.de, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
Paul Mackerras <paulus@samba.org>,
luto@kernel.org, tglx@linutronix.de, vincenzo.frascino@arm.com,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation.
Date: Fri, 17 Jan 2020 10:26:56 +0100 [thread overview]
Message-ID: <345e2772-cde9-7d86-874e-347db1453c80@c-s.fr> (raw)
In-Reply-To: <20200117085851.GS3191@gate.crashing.org>
Le 17/01/2020 à 09:58, Segher Boessenkool a écrit :
> Hi!
>
> On Thu, Jan 16, 2020 at 05:58:24PM +0000, Christophe Leroy wrote:
>> On a powerpc8xx, with current powerpc/32 ASM VDSO:
>>
>> gettimeofday: vdso: 907 nsec/call
>> clock-getres-realtime: vdso: 484 nsec/call
>> clock-gettime-realtime: vdso: 899 nsec/call
>>
>> The first patch adds VDSO generic C support without any changes to common code.
>> Performance is as follows:
>>
>> gettimeofday: vdso: 1211 nsec/call
>> clock-getres-realtime: vdso: 722 nsec/call
>> clock-gettime-realtime: vdso: 1216 nsec/call
>>
>> Then a few changes in the common code have allowed performance improvement. At
>> the end of the series we have:
>>
>> gettimeofday: vdso: 974 nsec/call
>> clock-getres-realtime: vdso: 545 nsec/call
>> clock-gettime-realtime: vdso: 941 nsec/call
>>
>> The final result is rather close to pure ASM VDSO:
>> * 7% more on gettimeofday (9 cycles)
>> * 5% more on clock-gettime-realtime (6 cycles)
>> * 12% more on clock-getres-realtime (8 cycles)
>
> Nice! Much better.
>
> It should be tested on more representative hardware, too, but this looks
> promising alright :-)
>
Yes.
Now the challenge is to get VDSO32 buildable on PPC64. The big issue is
that in most powerpc/include/asm/*.h , CONFIG_PPC64 is used to know if
the build is a 64 bits build or a 32 bits build, so VDSO32 build fails.
I don't know how this could be easily fixed.
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: nathanl@linux.ibm.com, arnd@arndb.de,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
luto@kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
tglx@linutronix.de, vincenzo.frascino@arm.com,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation.
Date: Fri, 17 Jan 2020 10:26:56 +0100 [thread overview]
Message-ID: <345e2772-cde9-7d86-874e-347db1453c80@c-s.fr> (raw)
In-Reply-To: <20200117085851.GS3191@gate.crashing.org>
Le 17/01/2020 à 09:58, Segher Boessenkool a écrit :
> Hi!
>
> On Thu, Jan 16, 2020 at 05:58:24PM +0000, Christophe Leroy wrote:
>> On a powerpc8xx, with current powerpc/32 ASM VDSO:
>>
>> gettimeofday: vdso: 907 nsec/call
>> clock-getres-realtime: vdso: 484 nsec/call
>> clock-gettime-realtime: vdso: 899 nsec/call
>>
>> The first patch adds VDSO generic C support without any changes to common code.
>> Performance is as follows:
>>
>> gettimeofday: vdso: 1211 nsec/call
>> clock-getres-realtime: vdso: 722 nsec/call
>> clock-gettime-realtime: vdso: 1216 nsec/call
>>
>> Then a few changes in the common code have allowed performance improvement. At
>> the end of the series we have:
>>
>> gettimeofday: vdso: 974 nsec/call
>> clock-getres-realtime: vdso: 545 nsec/call
>> clock-gettime-realtime: vdso: 941 nsec/call
>>
>> The final result is rather close to pure ASM VDSO:
>> * 7% more on gettimeofday (9 cycles)
>> * 5% more on clock-gettime-realtime (6 cycles)
>> * 12% more on clock-getres-realtime (8 cycles)
>
> Nice! Much better.
>
> It should be tested on more representative hardware, too, but this looks
> promising alright :-)
>
Yes.
Now the challenge is to get VDSO32 buildable on PPC64. The big issue is
that in most powerpc/include/asm/*.h , CONFIG_PPC64 is used to know if
the build is a 64 bits build or a 32 bits build, so VDSO32 build fails.
I don't know how this could be easily fixed.
Christophe
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-17 9:50 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:58 [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 01/11] powerpc/64: Don't provide time functions in compat VDSO32 Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 02/11] powerpc/vdso: Switch VDSO to generic C implementation Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 03/11] lib: vdso: only read hrtimer_res when needed in __cvdso_clock_getres() Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 04/11] powerpc/vdso: simplify __get_datapage() Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 05/11] lib: vdso: allow arches to provide vdso data pointer Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 06/11] powerpc/vdso: provide inline alternative to __get_datapage() Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 07/11] powerpc/vdso: provide vdso data pointer from the ASM caller Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 08/11] lib: vdso: allow fixed clock mode Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 20:13 ` Thomas Gleixner
2020-01-16 20:13 ` Thomas Gleixner
2020-01-16 20:13 ` Thomas Gleixner
2020-01-16 20:19 ` Andy Lutomirski
2020-01-16 20:19 ` Andy Lutomirski
2020-01-16 20:19 ` Andy Lutomirski
2020-01-16 21:07 ` Thomas Gleixner
2020-01-16 21:07 ` Thomas Gleixner
2020-01-16 21:07 ` Thomas Gleixner
2020-01-16 17:58 ` [RFC PATCH v4 09/11] powerpc/vdso: override __arch_vdso_capable() Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 10/11] lib: vdso: Allow arches to override the ns shift operation Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 19:47 ` Andy Lutomirski
2020-01-16 19:47 ` Andy Lutomirski
2020-01-16 19:47 ` Andy Lutomirski
2020-01-16 19:57 ` Thomas Gleixner
2020-01-16 19:57 ` Thomas Gleixner
2020-01-16 19:57 ` Thomas Gleixner
2020-01-16 20:20 ` Andy Lutomirski
2020-01-16 20:20 ` Andy Lutomirski
2020-01-16 20:20 ` Andy Lutomirski
2020-01-29 7:14 ` Thomas Gleixner
2020-01-29 7:14 ` Thomas Gleixner
2020-01-29 7:14 ` Thomas Gleixner
2020-01-29 7:26 ` Christophe Leroy
2020-01-29 7:26 ` Christophe Leroy
2020-01-29 7:26 ` Christophe Leroy
2020-01-16 17:58 ` [RFC PATCH v4 11/11] powerpc/32: provide vdso_shift_ns() Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-16 17:58 ` Christophe Leroy
2020-01-17 8:58 ` [RFC PATCH v4 00/11] powerpc: switch VDSO to C implementation Segher Boessenkool
2020-01-17 8:58 ` Segher Boessenkool
2020-01-17 8:58 ` Segher Boessenkool
2020-01-17 9:26 ` Christophe Leroy [this message]
2020-01-17 9:26 ` Christophe Leroy
2020-01-17 9:26 ` Christophe Leroy
2020-01-20 14:56 ` Christophe Leroy
2020-01-20 14:56 ` Christophe Leroy
2020-01-20 14:56 ` Christophe Leroy
2020-01-20 15:19 ` Segher Boessenkool
2020-01-20 15:19 ` Segher Boessenkool
2020-01-20 15:19 ` Segher Boessenkool
2020-01-20 17:08 ` Christophe Leroy
2020-01-20 17:08 ` Christophe Leroy
2020-01-20 17:08 ` Christophe Leroy
2020-01-20 17:27 ` Segher Boessenkool
2020-01-20 17:27 ` Segher Boessenkool
2020-01-20 17:27 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345e2772-cde9-7d86-874e-347db1453c80@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.