From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: georgi.djakov@linaro.org, cw00.choi@samsung.com,
devicetree@vger.kernel.org, robh+dt@kernel.org,
a.swigon@samsung.com, myungjoo.ham@samsung.com,
inki.dae@samsung.com, sw0312.kim@samsung.com,
b.zolnierkie@samsung.com, m.szyprowski@samsung.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs
Date: Wed, 4 Nov 2020 14:22:37 +0100 [thread overview]
Message-ID: <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com> (raw)
In-Reply-To: <20201104123729.GA13371@kozik-lap>
On 04.11.2020 13:37, Krzysztof Kozlowski wrote:
> On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote:
>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
>> index d203520..c2f9e9d 100644
>> --- a/drivers/interconnect/Makefile
>> +++ b/drivers/interconnect/Makefile
>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
>> obj-$(CONFIG_INTERCONNECT) += icc-core.o
>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
>> +obj-$(CONFIG_INTERCONNECT_SAMSUNG) += samsung/
>> \ No newline at end of file
>
> This needs a fix.
Corrected, thanks for pointing out.
>> diff --git a/drivers/interconnect/samsung/Kconfig b/drivers/interconnect/samsung/Kconfig
>> new file mode 100644
>> index 0000000..508ed64
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Kconfig
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +config INTERCONNECT_SAMSUNG
>> + bool "Samsung interconnect drivers"
>
> "Samsung SoC interconnect drivers"
Changed.
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>
> Don't the depend on INTERCONNECT?
This file gets included only if INTERCONNECT is enabled, see
higher level Kconfig file.
>> + help
>> + Interconnect drivers for Samsung SoCs.
>> +
>> +
>
> One line break
Fixed.
>> +config INTERCONNECT_EXYNOS
>> + tristate "Exynos generic interconnect driver"
>> + depends on INTERCONNECT_SAMSUNG
>
> How about:
> default y if ARCH_EXYNOS
OK, added.
>> + help
>> + Generic interconnect driver for Exynos SoCs.
>> diff --git a/drivers/interconnect/samsung/Makefile b/drivers/interconnect/samsung/Makefile
>> new file mode 100644
>> index 0000000..e19d1df
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Makefile
>> @@ -0,0 +1,4 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +exynos-interconnect-objs := exynos.o
>
> What is this line for?
That allows to change the module name, so it's exynos-interconnect.ko
rather than just exynos.c. It's done similarly for other SoCs in
the subsystem.
>> +obj-$(CONFIG_INTERCONNECT_EXYNOS) += exynos-interconnect.o
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
b.zolnierkie@samsung.com, linux-pm@vger.kernel.org,
sw0312.kim@samsung.com, a.swigon@samsung.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, inki.dae@samsung.com,
cw00.choi@samsung.com, myungjoo.ham@samsung.com,
dri-devel@lists.freedesktop.org, georgi.djakov@linaro.org,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs
Date: Wed, 4 Nov 2020 14:22:37 +0100 [thread overview]
Message-ID: <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com> (raw)
In-Reply-To: <20201104123729.GA13371@kozik-lap>
On 04.11.2020 13:37, Krzysztof Kozlowski wrote:
> On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote:
>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
>> index d203520..c2f9e9d 100644
>> --- a/drivers/interconnect/Makefile
>> +++ b/drivers/interconnect/Makefile
>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
>> obj-$(CONFIG_INTERCONNECT) += icc-core.o
>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
>> +obj-$(CONFIG_INTERCONNECT_SAMSUNG) += samsung/
>> \ No newline at end of file
>
> This needs a fix.
Corrected, thanks for pointing out.
>> diff --git a/drivers/interconnect/samsung/Kconfig b/drivers/interconnect/samsung/Kconfig
>> new file mode 100644
>> index 0000000..508ed64
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Kconfig
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +config INTERCONNECT_SAMSUNG
>> + bool "Samsung interconnect drivers"
>
> "Samsung SoC interconnect drivers"
Changed.
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>
> Don't the depend on INTERCONNECT?
This file gets included only if INTERCONNECT is enabled, see
higher level Kconfig file.
>> + help
>> + Interconnect drivers for Samsung SoCs.
>> +
>> +
>
> One line break
Fixed.
>> +config INTERCONNECT_EXYNOS
>> + tristate "Exynos generic interconnect driver"
>> + depends on INTERCONNECT_SAMSUNG
>
> How about:
> default y if ARCH_EXYNOS
OK, added.
>> + help
>> + Generic interconnect driver for Exynos SoCs.
>> diff --git a/drivers/interconnect/samsung/Makefile b/drivers/interconnect/samsung/Makefile
>> new file mode 100644
>> index 0000000..e19d1df
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Makefile
>> @@ -0,0 +1,4 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +exynos-interconnect-objs := exynos.o
>
> What is this line for?
That allows to change the module name, so it's exynos-interconnect.ko
rather than just exynos.c. It's done similarly for other SoCs in
the subsystem.
>> +obj-$(CONFIG_INTERCONNECT_EXYNOS) += exynos-interconnect.o
--
Regards,
Sylwester
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
b.zolnierkie@samsung.com, linux-pm@vger.kernel.org,
sw0312.kim@samsung.com, a.swigon@samsung.com, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, cw00.choi@samsung.com,
myungjoo.ham@samsung.com, dri-devel@lists.freedesktop.org,
georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs
Date: Wed, 4 Nov 2020 14:22:37 +0100 [thread overview]
Message-ID: <346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com> (raw)
In-Reply-To: <20201104123729.GA13371@kozik-lap>
On 04.11.2020 13:37, Krzysztof Kozlowski wrote:
> On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote:
>> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
>> index d203520..c2f9e9d 100644
>> --- a/drivers/interconnect/Makefile
>> +++ b/drivers/interconnect/Makefile
>> @@ -6,3 +6,4 @@ icc-core-objs := core.o bulk.o
>> obj-$(CONFIG_INTERCONNECT) += icc-core.o
>> obj-$(CONFIG_INTERCONNECT_IMX) += imx/
>> obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
>> +obj-$(CONFIG_INTERCONNECT_SAMSUNG) += samsung/
>> \ No newline at end of file
>
> This needs a fix.
Corrected, thanks for pointing out.
>> diff --git a/drivers/interconnect/samsung/Kconfig b/drivers/interconnect/samsung/Kconfig
>> new file mode 100644
>> index 0000000..508ed64
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Kconfig
>> @@ -0,0 +1,13 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +config INTERCONNECT_SAMSUNG
>> + bool "Samsung interconnect drivers"
>
> "Samsung SoC interconnect drivers"
Changed.
>> + depends on ARCH_EXYNOS || COMPILE_TEST
>
> Don't the depend on INTERCONNECT?
This file gets included only if INTERCONNECT is enabled, see
higher level Kconfig file.
>> + help
>> + Interconnect drivers for Samsung SoCs.
>> +
>> +
>
> One line break
Fixed.
>> +config INTERCONNECT_EXYNOS
>> + tristate "Exynos generic interconnect driver"
>> + depends on INTERCONNECT_SAMSUNG
>
> How about:
> default y if ARCH_EXYNOS
OK, added.
>> + help
>> + Generic interconnect driver for Exynos SoCs.
>> diff --git a/drivers/interconnect/samsung/Makefile b/drivers/interconnect/samsung/Makefile
>> new file mode 100644
>> index 0000000..e19d1df
>> --- /dev/null
>> +++ b/drivers/interconnect/samsung/Makefile
>> @@ -0,0 +1,4 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +exynos-interconnect-objs := exynos.o
>
> What is this line for?
That allows to change the module name, so it's exynos-interconnect.ko
rather than just exynos.c. It's done similarly for other SoCs in
the subsystem.
>> +obj-$(CONFIG_INTERCONNECT_EXYNOS) += exynos-interconnect.o
--
Regards,
Sylwester
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-04 13:23 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201104103713eucas1p2d21b6f936aa18725ae4b4878f3be0a8e@eucas1p2.samsung.com>
2020-11-04 10:36 ` [PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
[not found] ` <CGME20201104103718eucas1p1c103f1a96499b03c72e5457ac2542c3d@eucas1p1.samsung.com>
2020-11-04 10:36 ` [PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 12:25 ` Krzysztof Kozlowski
2020-11-04 12:25 ` Krzysztof Kozlowski
2020-11-04 12:25 ` Krzysztof Kozlowski
2020-11-04 12:28 ` Chanwoo Choi
2020-11-04 12:28 ` Chanwoo Choi
2020-11-04 12:28 ` Chanwoo Choi
2020-11-10 14:26 ` Rob Herring
2020-11-10 14:26 ` Rob Herring
2020-11-10 14:26 ` Rob Herring
[not found] ` <CGME20201104103720eucas1p1014217e751a681796ed508af22c6bb12@eucas1p1.samsung.com>
2020-11-04 10:36 ` [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 12:28 ` Chanwoo Choi
2020-11-04 12:28 ` Chanwoo Choi
2020-11-04 12:28 ` Chanwoo Choi
2020-11-04 12:37 ` Krzysztof Kozlowski
2020-11-04 12:37 ` Krzysztof Kozlowski
2020-11-04 12:37 ` Krzysztof Kozlowski
2020-11-04 13:22 ` Sylwester Nawrocki [this message]
2020-11-04 13:22 ` Sylwester Nawrocki
2020-11-04 13:22 ` Sylwester Nawrocki
2020-11-04 14:06 ` Krzysztof Kozlowski
2020-11-04 14:06 ` Krzysztof Kozlowski
2020-11-04 14:06 ` Krzysztof Kozlowski
[not found] ` <CGME20201104103722eucas1p1db939995e60d0bf2cd581070c14379f5@eucas1p1.samsung.com>
2020-11-04 10:36 ` [PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 12:27 ` Krzysztof Kozlowski
2020-11-04 12:27 ` Krzysztof Kozlowski
2020-11-04 12:27 ` Krzysztof Kozlowski
2020-11-04 13:27 ` Sylwester Nawrocki
2020-11-04 13:27 ` Sylwester Nawrocki
2020-11-04 13:27 ` Sylwester Nawrocki
2020-11-04 12:30 ` Chanwoo Choi
2020-11-04 12:30 ` Chanwoo Choi
2020-11-04 12:30 ` Chanwoo Choi
[not found] ` <CGME20201104103726eucas1p2e8f7c32f13b4232d925e901284ada13d@eucas1p2.samsung.com>
2020-11-04 10:36 ` [PATCH v8 4/7] PM / devfreq: exynos-bus: Add registration of interconnect child device Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
[not found] ` <CGME20201104103726eucas1p248b51b25f5ee42898bf03e9cb2229c5d@eucas1p2.samsung.com>
2020-11-04 10:36 ` [PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 12:31 ` Chanwoo Choi
2020-11-04 12:31 ` Chanwoo Choi
2020-11-04 12:31 ` Chanwoo Choi
2020-11-10 18:11 ` Krzysztof Kozlowski
2020-11-10 18:11 ` Krzysztof Kozlowski
2020-11-10 18:11 ` Krzysztof Kozlowski
[not found] ` <CGME20201104103728eucas1p2f671f29ed9eb06d4c6c991b073be092e@eucas1p2.samsung.com>
2020-11-04 10:36 ` [PATCH v8 6/7] ARM: dts: exynos: Add interconnects to Exynos4412 mixer Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-10 18:12 ` Krzysztof Kozlowski
2020-11-10 18:12 ` Krzysztof Kozlowski
2020-11-10 18:12 ` Krzysztof Kozlowski
[not found] ` <CGME20201104103730eucas1p2964e5910a1319fc1c931db8f02a447de@eucas1p2.samsung.com>
2020-11-04 10:36 ` [PATCH v8 7/7] drm: exynos: mixer: Add interconnect support Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 10:36 ` Sylwester Nawrocki
2020-11-04 12:31 ` Chanwoo Choi
2020-11-04 12:31 ` Chanwoo Choi
2020-11-04 12:31 ` Chanwoo Choi
2020-11-05 2:20 ` [PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect Chanwoo Choi
2020-11-05 2:20 ` Chanwoo Choi
2020-11-05 2:20 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346da718-2340-c862-9a1a-c5f64aae19c2@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.swigon@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=inki.dae@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.