All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: peng.fan@oss.nxp.com
Cc: abel.vesa@nxp.com, aford173@gmail.com, agx@sigxcpu.org,
	andrew.smirnov@gmail.com, devicetree@vger.kernel.org,
	festevam@gmail.com, frieder.schrempf@kontron.de,
	jagan@amarulasolutions.com, kernel@pengutronix.de,
	krzk@kernel.org, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, marex@denx.de,
	p.zabel@pengutronix.de, peng.fan@nxp.com, ping.bai@nxp.com,
	robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support
Date: Wed, 7 Jul 2021 22:11:14 +0200	[thread overview]
Message-ID: <34904917-787e-1cb7-5a88-6d96588e296e@collabora.com> (raw)
In-Reply-To: <20210629072941.7980-1-peng.fan@oss.nxp.com>

Hi Peng,

I have try to use this series to implement BLK-CTL for IMX8MQ and to test it with G1 and G2 VPUs.
You can find the code here:
https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/commits/control_block_imx8mq

It seems that IMX8MQ requires to set 'fuses' registers to enable the VPUs, I have added that in your code.

Unfortunately that doesn't work, the VPUs are blocked like if they were never reset.
Note that use syscon to manage the reset is working fine.
Since IMX8MQ control block seems lightly different than for IMX8MM, would you mind to add the support for it in your next series ?

Regards,
Benjamin


WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: peng.fan@oss.nxp.com
Cc: abel.vesa@nxp.com, aford173@gmail.com, agx@sigxcpu.org,
	andrew.smirnov@gmail.com, devicetree@vger.kernel.org,
	festevam@gmail.com, frieder.schrempf@kontron.de,
	jagan@amarulasolutions.com, kernel@pengutronix.de,
	krzk@kernel.org, l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
	linux-kernel@vger.kernel.org, marex@denx.de,
	p.zabel@pengutronix.de, peng.fan@nxp.com, ping.bai@nxp.com,
	robh+dt@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support
Date: Wed, 7 Jul 2021 22:11:14 +0200	[thread overview]
Message-ID: <34904917-787e-1cb7-5a88-6d96588e296e@collabora.com> (raw)
In-Reply-To: <20210629072941.7980-1-peng.fan@oss.nxp.com>

Hi Peng,

I have try to use this series to implement BLK-CTL for IMX8MQ and to test it with G1 and G2 VPUs.
You can find the code here:
https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/commits/control_block_imx8mq

It seems that IMX8MQ requires to set 'fuses' registers to enable the VPUs, I have added that in your code.

Unfortunately that doesn't work, the VPUs are blocked like if they were never reset.
Note that use syscon to manage the reset is working fine.
Since IMX8MQ control block seems lightly different than for IMX8MM, would you mind to add the support for it in your next series ?

Regards,
Benjamin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-07-07 20:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  7:29 [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support Peng Fan (OSS)
2021-06-29  7:29 ` Peng Fan (OSS)
2021-06-29  7:29 ` [PATCH V8 1/4] dt-bindings: power: Add defines for i.MX8MM BLK-CTL power domains Peng Fan (OSS)
2021-06-29  7:29   ` Peng Fan (OSS)
2021-06-29  7:29 ` [PATCH V8 2/4] dt-bindings: soc: imx: Add bindings for i.MX BLK_CTL Peng Fan (OSS)
2021-06-29  7:29   ` Peng Fan (OSS)
2021-06-29  7:29 ` [PATCH V8 3/4] soc: imx: Add generic blk-ctl driver Peng Fan (OSS)
2021-06-29  7:29   ` Peng Fan (OSS)
2021-07-05 14:55   ` Lucas Stach
2021-07-05 14:55     ` Lucas Stach
2021-07-07  9:56     ` Peng Fan
2021-07-07  9:56       ` Peng Fan
2021-07-09  8:51       ` Lucas Stach
2021-07-09  8:51         ` Lucas Stach
2021-07-09 10:08         ` Peng Fan
2021-07-09 10:08           ` Peng Fan
2021-07-09 12:38           ` Lucas Stach
2021-07-09 12:38             ` Lucas Stach
2021-06-29  7:29 ` [PATCH V8 4/4] soc: imx: Add blk-ctl driver for i.MX8MM Peng Fan (OSS)
2021-06-29  7:29   ` Peng Fan (OSS)
2021-06-29 21:17   ` kernel test robot
2021-06-29 13:26 ` [PATCH V8 0/4] soc: imx: add i.MX BLK-CTL support Adam Ford
2021-06-29 13:26   ` Adam Ford
2021-06-30  9:34   ` Peng Fan (OSS)
2021-06-30  9:34     ` Peng Fan (OSS)
2021-06-30 12:09     ` Adam Ford
2021-06-30 12:09       ` Adam Ford
2021-06-30 14:46       ` Frieder Schrempf
2021-06-30 14:46         ` Frieder Schrempf
2021-06-30 16:28         ` Marek Vasut
2021-06-30 16:28           ` Marek Vasut
2021-06-30 17:20           ` Frieder Schrempf
2021-06-30 17:20             ` Frieder Schrempf
2021-07-01  7:32             ` Frieder Schrempf
2021-07-01  7:32               ` Frieder Schrempf
2021-07-02  3:24               ` Peng Fan
2021-07-02  3:24                 ` Peng Fan
2021-07-05 10:45                 ` Frieder Schrempf
2021-07-05 10:45                   ` Frieder Schrempf
2021-07-07 20:11 ` Benjamin Gaignard [this message]
2021-07-07 20:11   ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34904917-787e-1cb7-5a88-6d96588e296e@collabora.com \
    --to=benjamin.gaignard@collabora.com \
    --cc=abel.vesa@nxp.com \
    --cc=aford173@gmail.com \
    --cc=agx@sigxcpu.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=jagan@amarulasolutions.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.