All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nvme@lists.infradead.org,
	List Linux RDMA Mailing <linux-rdma@vger.kernel.org>,
	target-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address
Date: Thu, 16 Feb 2017 20:11:27 +0200	[thread overview]
Message-ID: <34a7fa67-2b72-aaa8-1c66-cfdd5d041124@grimberg.me> (raw)
In-Reply-To: <EB281BA3-28DB-4DBA-BA3B-31A98BC0D44E@oracle.com>


>> Yea, I wanted to get all the rpc_pton/rpc_ntop (which handle both
>> ipv4 and ipv6 with scopes) converted to use a common helper.
>
> RPC is dealing with universal addresses, which are not quite the
> same as IP presentation addresses. The port number is expressed
> as:
>
>   hi8.lo8

I noticed that, that's why there will be some processing in
sunrpc to construct a port string to a generic helper (if it chooses to
use it).

> And universal IPv6 addresses don't have a mechanism for conveying
> scope information.

I do see scope handling in rpc_pton6 code if provided...

WARNING: multiple messages have this Message-ID (diff)
From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address
Date: Thu, 16 Feb 2017 20:11:27 +0200	[thread overview]
Message-ID: <34a7fa67-2b72-aaa8-1c66-cfdd5d041124@grimberg.me> (raw)
In-Reply-To: <EB281BA3-28DB-4DBA-BA3B-31A98BC0D44E@oracle.com>


>> Yea, I wanted to get all the rpc_pton/rpc_ntop (which handle both
>> ipv4 and ipv6 with scopes) converted to use a common helper.
>
> RPC is dealing with universal addresses, which are not quite the
> same as IP presentation addresses. The port number is expressed
> as:
>
>   hi8.lo8

I noticed that, that's why there will be some processing in
sunrpc to construct a port string to a generic helper (if it chooses to
use it).

> And universal IPv6 addresses don't have a mechanism for conveying
> scope information.

I do see scope handling in rpc_pton6 code if provided...

  reply	other threads:[~2017-02-16 18:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 17:43 [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address Sagi Grimberg
2017-02-16 17:43 ` Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper Sagi Grimberg
2017-02-16 17:43   ` Sagi Grimberg
2017-02-16 21:34   ` kbuild test robot
2017-02-16 21:34     ` kbuild test robot
     [not found]     ` <1487267017-29904-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-02-16 21:34       ` [PATCH] net/utils: fix semicolon.cocci warnings kbuild test robot
2017-02-16 21:34         ` kbuild test robot
2017-02-17 18:52         ` David Miller
2017-02-17 18:52           ` David Miller
2017-02-17 19:19           ` Keith Busch
2017-02-17 19:19             ` Keith Busch
2017-02-18  0:39           ` Fengguang Wu
2017-02-18  0:39             ` Fengguang Wu
2017-02-19 17:15   ` [PATCH rfc 1/4] net/utils: generic inet_pton_with_scope helper Christoph Hellwig
2017-02-19 17:15     ` Christoph Hellwig
     [not found]     ` <20170219171523.GC10310-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-21 21:18       ` Sagi Grimberg
2017-02-21 21:18         ` Sagi Grimberg
     [not found]         ` <6c2a4f67-ede6-0ee1-5a90-14023994d029-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-02-22  7:43           ` Christoph Hellwig
2017-02-22  7:43             ` Christoph Hellwig
     [not found] ` <1487267017-29904-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-02-16 17:43   ` [PATCH rfc 2/4] nvmet-rdma: use generic inet_pton_with_scope Sagi Grimberg
2017-02-16 17:43     ` Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 3/4] nvme-rdma: use inet_pton_with_scope helper Sagi Grimberg
2017-02-16 17:43   ` Sagi Grimberg
2017-02-16 17:43 ` [PATCH rfc 4/4] iscsi-target: use generic inet_pton_with_scope Sagi Grimberg
2017-02-16 17:43   ` Sagi Grimberg
2017-02-19  5:54   ` Nicholas A. Bellinger
2017-02-19  5:54     ` Nicholas A. Bellinger
2017-02-16 17:50 ` [PATCH rfc 0/4] Introduce a new helper for parsing ipv[4|6]:port to socket address Chuck Lever
2017-02-16 17:50   ` Chuck Lever
2017-02-16 17:53   ` Sagi Grimberg
2017-02-16 17:53     ` Sagi Grimberg
     [not found]     ` <8dc41cfc-85b2-fb42-61b0-5be499fa7ad0-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-02-16 17:59       ` Chuck Lever
2017-02-16 17:59         ` Chuck Lever
2017-02-16 18:11         ` Sagi Grimberg [this message]
2017-02-16 18:11           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34a7fa67-2b72-aaa8-1c66-cfdd5d041124@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.