From: Scott Branden <scott.branden@broadcom.com> To: kbuild test robot <lkp@intel.com> Cc: kbuild-all@lists.01.org, Luis Chamberlain <mcgrof@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Brown <david.brown@linaro.org>, Alexander Viro <viro@zeniv.linux.org.uk>, Shuah Khan <shuah@kernel.org>, bjorn.andersson@linaro.org, Shuah Khan <skhan@linuxfoundation.org>, Arnd Bergmann <arnd@arndb.de>, Linux Memory Management List <linux-mm@kvack.org> Subject: Re: [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Date: Fri, 21 Feb 2020 17:26:21 -0800 [thread overview] Message-ID: <34ac08f4-8528-a150-d451-4ce6cc98d555@broadcom.com> (raw) In-Reply-To: <202002220811.ZfoxGUs3%lkp@intel.com> Will remove semicolon to fix compile error on certain CONFIG_FW_LOADER not selected. On 2020-02-21 4:50 p.m., kbuild test robot wrote: > Hi Scott, > > I love your patch! Yet something to improve: > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on kselftest/next linus/master v5.6-rc2] > [cannot apply to driver-core/driver-core-testing next-20200221] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200222-032851 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 06e33595e96f212811066df192ae8bf802174296 > config: x86_64-randconfig-c002-20200221 (attached as .config) > compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > In file included from drivers/base/firmware_loader/fallback.h:5:0, > from drivers/base/firmware_loader/fallback_table.c:12: >>> include/linux/firmware.h:97:1: error: expected identifier or '(' before '{' token > { > ^ > include/linux/firmware.h:94:19: warning: 'request_firmware_into_buf' declared 'static' but never defined [-Wunused-function] > static inline int request_firmware_into_buf(const struct firmware **firmware_p, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > vim +97 include/linux/firmware.h > > fbab976d7ce455 James Bottomley 2008-03-07 93 > a098ecd2fa7db8 Stephen Boyd 2016-08-02 94 static inline int request_firmware_into_buf(const struct firmware **firmware_p, > 6f0a3d616d978b Scott Branden 2020-02-19 95 const char *name, struct device *device, void *buf, size_t size, > 6f0a3d616d978b Scott Branden 2020-02-19 96 size_t offset, unsigned int pread_flags); Will remove ; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 @97 { > a098ecd2fa7db8 Stephen Boyd 2016-08-02 98 return -EINVAL; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 99 } > a098ecd2fa7db8 Stephen Boyd 2016-08-02 100 > > :::::: The code at line 97 was first introduced by commit > :::::: a098ecd2fa7db8fa4fcc178a43627b29b226edb9 firmware: support loading into a pre-allocated buffer > > :::::: TO: Stephen Boyd <stephen.boyd@linaro.org> > :::::: CC: Linus Torvalds <torvalds@linux-foundation.org> > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Scott Branden <scott.branden@broadcom.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Date: Fri, 21 Feb 2020 17:26:21 -0800 [thread overview] Message-ID: <34ac08f4-8528-a150-d451-4ce6cc98d555@broadcom.com> (raw) In-Reply-To: <202002220811.ZfoxGUs3%lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2894 bytes --] Will remove semicolon to fix compile error on certain CONFIG_FW_LOADER not selected. On 2020-02-21 4:50 p.m., kbuild test robot wrote: > Hi Scott, > > I love your patch! Yet something to improve: > > [auto build test ERROR on char-misc/char-misc-testing] > [also build test ERROR on kselftest/next linus/master v5.6-rc2] > [cannot apply to driver-core/driver-core-testing next-20200221] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200222-032851 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 06e33595e96f212811066df192ae8bf802174296 > config: x86_64-randconfig-c002-20200221 (attached as .config) > compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): > > In file included from drivers/base/firmware_loader/fallback.h:5:0, > from drivers/base/firmware_loader/fallback_table.c:12: >>> include/linux/firmware.h:97:1: error: expected identifier or '(' before '{' token > { > ^ > include/linux/firmware.h:94:19: warning: 'request_firmware_into_buf' declared 'static' but never defined [-Wunused-function] > static inline int request_firmware_into_buf(const struct firmware **firmware_p, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > vim +97 include/linux/firmware.h > > fbab976d7ce455 James Bottomley 2008-03-07 93 > a098ecd2fa7db8 Stephen Boyd 2016-08-02 94 static inline int request_firmware_into_buf(const struct firmware **firmware_p, > 6f0a3d616d978b Scott Branden 2020-02-19 95 const char *name, struct device *device, void *buf, size_t size, > 6f0a3d616d978b Scott Branden 2020-02-19 96 size_t offset, unsigned int pread_flags); Will remove ; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 @97 { > a098ecd2fa7db8 Stephen Boyd 2016-08-02 98 return -EINVAL; > a098ecd2fa7db8 Stephen Boyd 2016-08-02 99 } > a098ecd2fa7db8 Stephen Boyd 2016-08-02 100 > > :::::: The code at line 97 was first introduced by commit > :::::: a098ecd2fa7db8fa4fcc178a43627b29b226edb9 firmware: support loading into a pre-allocated buffer > > :::::: TO: Stephen Boyd <stephen.boyd@linaro.org> > :::::: CC: Linus Torvalds <torvalds@linux-foundation.org> > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2020-02-22 1:26 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 0:48 [PATCH v2 0/7] firmware: add partial read support in request_firmware_into_buf Scott Branden 2020-02-20 0:48 ` [PATCH v2 1/7] fs: introduce kernel_pread_file* support Scott Branden 2020-02-20 0:48 ` [PATCH v2 2/7] firmware: add offset to request_firmware_into_buf Scott Branden 2020-02-20 1:22 ` Luis Chamberlain 2020-02-21 0:14 ` Scott Branden 2020-02-22 0:50 ` kbuild test robot 2020-02-22 0:50 ` kbuild test robot 2020-02-22 1:26 ` Scott Branden [this message] 2020-02-22 1:26 ` Scott Branden 2020-02-20 0:48 ` [PATCH v2 3/7] test_firmware: add partial read support for request_firmware_into_buf Scott Branden 2020-02-20 8:42 ` Dan Carpenter 2020-02-21 18:30 ` Scott Branden 2020-02-22 1:13 ` Scott Branden 2020-02-24 8:08 ` Dan Carpenter 2020-02-25 19:11 ` Luis Chamberlain 2020-02-20 0:48 ` [PATCH v2 4/7] firmware: test partial file reads of request_firmware_into_buf Scott Branden 2020-02-20 0:48 ` [PATCH v2 5/7] bcm-vk: add bcm_vk UAPI Scott Branden 2020-02-20 7:50 ` Greg Kroah-Hartman 2020-02-21 1:15 ` Scott Branden 2020-02-21 8:34 ` Arnd Bergmann 2020-02-21 18:27 ` Scott Branden 2020-02-21 9:22 ` Greg Kroah-Hartman 2020-02-20 0:48 ` [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver Scott Branden 2020-02-20 1:04 ` Randy Dunlap 2020-02-21 0:06 ` Scott Branden 2020-02-21 0:21 ` Randy Dunlap 2020-02-20 7:47 ` Greg Kroah-Hartman 2020-02-21 18:19 ` Scott Branden 2020-02-22 8:02 ` Arnd Bergmann 2020-02-23 10:00 ` Greg Kroah-Hartman 2020-02-23 23:55 ` Olof Johansson 2020-02-25 22:37 ` Scott Branden 2020-02-20 10:43 ` Dan Carpenter 2020-02-21 18:29 ` Scott Branden 2020-04-17 21:49 ` Scott Branden 2020-04-18 11:45 ` Dan Carpenter 2020-04-18 11:47 ` Dan Carpenter 2020-04-18 17:25 ` Scott Branden 2020-02-22 16:44 ` kbuild test robot 2020-02-22 16:44 ` kbuild test robot 2020-02-22 16:44 ` [RFC PATCH] misc: bcm-vk: image_tab[] can be static kbuild test robot 2020-02-22 16:44 ` kbuild test robot 2020-02-20 0:48 ` [PATCH v2 7/7] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=34ac08f4-8528-a150-d451-4ce6cc98d555@broadcom.com \ --to=scott.branden@broadcom.com \ --cc=arnd@arndb.de \ --cc=bjorn.andersson@linaro.org \ --cc=david.brown@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-mm@kvack.org \ --cc=lkp@intel.com \ --cc=mcgrof@kernel.org \ --cc=shuah@kernel.org \ --cc=skhan@linuxfoundation.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.