From: JeffleXu <jefflexu@linux.alibaba.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com,
dm-devel@redhat.com
Subject: Re: [dm-devel] dm: use gcd() to fix chunk_sectors limit stacking
Date: Thu, 3 Dec 2020 09:48:30 +0800 [thread overview]
Message-ID: <353a132b-1430-60b0-3f17-979af1b8dd22@linux.alibaba.com> (raw)
In-Reply-To: <20201202151112.GD20535@redhat.com>
On 12/2/20 11:11 PM, Mike Snitzer wrote:
> On Wed, Dec 02 2020 at 2:10am -0500,
> JeffleXu <jefflexu@linux.alibaba.com> wrote:
>
>>
>>
>> On 12/2/20 1:03 PM, Mike Snitzer wrote:
>>> What you've done here is fairly chaotic/disruptive:
>>> 1) you emailed a patch out that isn't needed or ideal, I dealt already
>>> staged a DM fix in linux-next for 5.10-rcX, see:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.10-rcX&id=f28de262ddf09b635095bdeaf0e07ff507b3c41b
>>
>> Then ti->type->io_hints() is still bypassed when type->iterate_devices()
>> not defined?
>
> Yes, the stacking of limits really is tightly coupled to device-based
> influence. Hypothetically some DM target that doesn't remap to any data
> devices may want to override limits... in practice there isn't a need
> for this. If that changes we can take action to accommodate it.. but I'm
> definitely not interested in modifying DM core in this area when there
> isn't a demonstrated need.
Thanks.
--
Thanks,
Jeffle
WARNING: multiple messages have this Message-ID (diff)
From: JeffleXu <jefflexu@linux.alibaba.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, joseph.qi@linux.alibaba.com,
dm-devel@redhat.com
Subject: Re: [dm-devel] dm: use gcd() to fix chunk_sectors limit stacking
Date: Thu, 3 Dec 2020 09:48:30 +0800 [thread overview]
Message-ID: <353a132b-1430-60b0-3f17-979af1b8dd22@linux.alibaba.com> (raw)
In-Reply-To: <20201202151112.GD20535@redhat.com>
On 12/2/20 11:11 PM, Mike Snitzer wrote:
> On Wed, Dec 02 2020 at 2:10am -0500,
> JeffleXu <jefflexu@linux.alibaba.com> wrote:
>
>>
>>
>> On 12/2/20 1:03 PM, Mike Snitzer wrote:
>>> What you've done here is fairly chaotic/disruptive:
>>> 1) you emailed a patch out that isn't needed or ideal, I dealt already
>>> staged a DM fix in linux-next for 5.10-rcX, see:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.10-rcX&id=f28de262ddf09b635095bdeaf0e07ff507b3c41b
>>
>> Then ti->type->io_hints() is still bypassed when type->iterate_devices()
>> not defined?
>
> Yes, the stacking of limits really is tightly coupled to device-based
> influence. Hypothetically some DM target that doesn't remap to any data
> devices may want to override limits... in practice there isn't a need
> for this. If that changes we can take action to accommodate it.. but I'm
> definitely not interested in modifying DM core in this area when there
> isn't a demonstrated need.
Thanks.
--
Thanks,
Jeffle
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2020-12-03 1:49 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:18 [PATCH] block: revert to using min_not_zero() when stacking chunk_sectors Mike Snitzer
2020-11-30 17:18 ` [dm-devel] " Mike Snitzer
2020-11-30 20:51 ` John Dorminy
2020-11-30 20:51 ` [dm-devel] " John Dorminy
2020-11-30 23:24 ` Mike Snitzer
2020-11-30 23:24 ` [dm-devel] " Mike Snitzer
2020-12-01 0:21 ` John Dorminy
2020-12-01 0:21 ` [dm-devel] " John Dorminy
2020-12-01 2:12 ` Mike Snitzer
2020-12-01 2:12 ` [dm-devel] " Mike Snitzer
2020-12-01 16:07 ` [PATCH v2] block: use gcd() to fix chunk_sectors limit stacking Mike Snitzer
2020-12-01 16:07 ` [dm-devel] " Mike Snitzer
2020-12-01 17:43 ` John Dorminy
2020-12-01 17:43 ` [dm-devel] " John Dorminy
2020-12-01 17:53 ` Jens Axboe
2020-12-01 17:53 ` [dm-devel] " Jens Axboe
2020-12-01 18:02 ` Martin K. Petersen
2020-12-01 18:02 ` [dm-devel] " Martin K. Petersen
2020-12-02 3:38 ` [PATCH] dm: " Jeffle Xu
2020-12-02 3:38 ` [dm-devel] " Jeffle Xu
2020-12-02 3:38 ` Jeffle Xu
2020-12-02 3:38 ` [dm-devel] " Jeffle Xu
2020-12-02 3:57 ` JeffleXu
2020-12-02 3:57 ` [dm-devel] " JeffleXu
2020-12-02 5:03 ` Mike Snitzer
2020-12-02 5:03 ` [dm-devel] " Mike Snitzer
2020-12-02 5:14 ` Mike Snitzer
2020-12-02 5:14 ` [dm-devel] " Mike Snitzer
2020-12-02 6:31 ` JeffleXu
2020-12-02 6:31 ` [dm-devel] " JeffleXu
2020-12-02 6:35 ` JeffleXu
2020-12-02 6:35 ` [dm-devel] " JeffleXu
2020-12-02 6:28 ` JeffleXu
2020-12-02 6:28 ` [dm-devel] " JeffleXu
2020-12-02 7:10 ` JeffleXu
2020-12-02 7:10 ` [dm-devel] " JeffleXu
2020-12-02 15:11 ` Mike Snitzer
2020-12-02 15:11 ` [dm-devel] " Mike Snitzer
2020-12-03 1:48 ` JeffleXu [this message]
2020-12-03 1:48 ` JeffleXu
2020-12-03 3:26 ` [PATCH v2] block: " Ming Lei
2020-12-03 3:26 ` [dm-devel] " Ming Lei
2020-12-03 14:33 ` Mike Snitzer
2020-12-03 14:33 ` [dm-devel] " Mike Snitzer
2020-12-03 16:27 ` Keith Busch
2020-12-03 16:27 ` [dm-devel] " Keith Busch
2020-12-03 17:56 ` Mike Snitzer
2020-12-03 17:56 ` [dm-devel] " Mike Snitzer
2020-12-04 1:45 ` Ming Lei
2020-12-04 1:45 ` [dm-devel] " Ming Lei
2020-12-04 2:11 ` Mike Snitzer
2020-12-04 2:11 ` [dm-devel] " Mike Snitzer
2020-12-04 6:22 ` Damien Le Moal
2020-12-04 6:22 ` Damien Le Moal
2020-12-04 1:12 ` Ming Lei
2020-12-04 1:12 ` [dm-devel] " Ming Lei
2020-12-04 2:03 ` Mike Snitzer
2020-12-04 2:03 ` [dm-devel] " Mike Snitzer
2020-12-04 3:59 ` Ming Lei
2020-12-04 3:59 ` [dm-devel] " Ming Lei
2020-12-04 16:47 ` Mike Snitzer
2020-12-04 16:47 ` [dm-devel] " Mike Snitzer
2020-12-04 17:32 ` [RFC PATCH] dm: fix IO splitting [was: Re: [PATCH v2] block: use gcd() to fix chunk_sectors limit stacking] Mike Snitzer
2020-12-04 17:32 ` [dm-devel] " Mike Snitzer
2020-12-04 17:49 ` Mike Snitzer
2020-12-04 17:49 ` [dm-devel] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353a132b-1430-60b0-3f17-979af1b8dd22@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=dm-devel@redhat.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.