From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Sean Wang <sean.wang@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8186
Date: Wed, 31 Jan 2024 09:51:56 +0100 [thread overview]
Message-ID: <3561b91a-9e02-47c8-ba70-2b7f082b5ab4@collabora.com> (raw)
In-Reply-To: <20240131071910.3950450-1-wenst@chromium.org>
Il 31/01/24 08:19, Chen-Yu Tsai ha scritto:
> The MT8186 does not support configuring pin slew rate. This is evident
> from both the datasheet, and the fact that the driver points the slew
> rate register range at the GPIO direction register range.
>
> Drop the bogus setting.
>
> Fixes: 8b483bda1e46 ("pinctrl: add pinctrl driver on mt8186")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Argh :-)
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chen-Yu Tsai <wenst@chromium.org>,
Sean Wang <sean.wang@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8186
Date: Wed, 31 Jan 2024 09:51:56 +0100 [thread overview]
Message-ID: <3561b91a-9e02-47c8-ba70-2b7f082b5ab4@collabora.com> (raw)
In-Reply-To: <20240131071910.3950450-1-wenst@chromium.org>
Il 31/01/24 08:19, Chen-Yu Tsai ha scritto:
> The MT8186 does not support configuring pin slew rate. This is evident
> from both the datasheet, and the fact that the driver points the slew
> rate register range at the GPIO direction register range.
>
> Drop the bogus setting.
>
> Fixes: 8b483bda1e46 ("pinctrl: add pinctrl driver on mt8186")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Argh :-)
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-31 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 7:19 [PATCH 1/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8186 Chen-Yu Tsai
2024-01-31 7:19 ` Chen-Yu Tsai
2024-01-31 7:19 ` [PATCH 2/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8192 Chen-Yu Tsai
2024-01-31 7:19 ` Chen-Yu Tsai
2024-01-31 8:51 ` AngeloGioacchino Del Regno
2024-01-31 8:51 ` AngeloGioacchino Del Regno
2024-01-31 8:51 ` AngeloGioacchino Del Regno [this message]
2024-01-31 8:51 ` [PATCH 1/2] pinctrl: mediatek: Drop bogus slew rate register range for MT8186 AngeloGioacchino Del Regno
2024-02-07 10:48 ` Linus Walleij
2024-02-07 10:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3561b91a-9e02-47c8-ba70-2b7f082b5ab4@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.