From: kernel test robot <rong.a.chen@intel.com>
To: David Howells <dhowells@redhat.com>, kernel test robot <lkp@intel.com>
Cc: torvalds@linux-foundation.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
nicolas.dichtel@6wind.com, raven@themaw.net,
Christian Brauner <christian@brauner.io>,
keyrings@vger.kernel.org, linux-usb@vger.kernel.org,
linux-block@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, lkp@lists.01.org
Subject: Re: [LKP] Re: [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference,address
Date: Mon, 18 Nov 2019 15:53:22 +0800 [thread overview]
Message-ID: <35daca93-ff2b-2c7d-b837-72396ca0677a@intel.com> (raw)
In-Reply-To: <6853.1573834946@warthog.procyon.org.uk>
Hi David,
Yes, it can fix the problem.
Best Regards,
Rong Chen
On 11/16/2019 12:22 AM, David Howells wrote:
> Actually, no, this is the fix:
>
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index 7006b5b2106d..be2fc5793ddd 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -537,7 +537,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
> buf->ops = &default_pipe_buf_ops;
> buf->page = page;
> buf->offset = 0;
> - buf->len = max_t(ssize_t, left, PAGE_SIZE);
> + buf->len = min_t(ssize_t, left, PAGE_SIZE);
> left -= buf->len;
> iter_head++;
> pipe->head = iter_head;
>
> David
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <rong.a.chen@intel.com>
To: David Howells <dhowells@redhat.com>, kernel test robot <lkp@intel.com>
Cc: torvalds@linux-foundation.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Zijlstra <peterz@infradead.org>,
nicolas.dichtel@6wind.com, raven@themaw.net,
Christian Brauner <christian@brauner.io>,
keyrings@vger.kernel.org, linux-usb@vger.kernel.org,
linux-block@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, lkp@lists.01.org
Subject: Re: [LKP] Re: [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference,address
Date: Mon, 18 Nov 2019 07:53:22 +0000 [thread overview]
Message-ID: <35daca93-ff2b-2c7d-b837-72396ca0677a@intel.com> (raw)
In-Reply-To: <6853.1573834946@warthog.procyon.org.uk>
Hi David,
Yes, it can fix the problem.
Best Regards,
Rong Chen
On 11/16/2019 12:22 AM, David Howells wrote:
> Actually, no, this is the fix:
>
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index 7006b5b2106d..be2fc5793ddd 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -537,7 +537,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
> buf->ops = &default_pipe_buf_ops;
> buf->page = page;
> buf->offset = 0;
> - buf->len = max_t(ssize_t, left, PAGE_SIZE);
> + buf->len = min_t(ssize_t, left, PAGE_SIZE);
> left -= buf->len;
> iter_head++;
> pipe->head = iter_head;
>
> David
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <rong.a.chen@intel.com>
To: lkp@lists.01.org
Subject: Re: [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference, address
Date: Mon, 18 Nov 2019 15:53:22 +0800 [thread overview]
Message-ID: <35daca93-ff2b-2c7d-b837-72396ca0677a@intel.com> (raw)
In-Reply-To: <6853.1573834946@warthog.procyon.org.uk>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
Hi David,
Yes, it can fix the problem.
Best Regards,
Rong Chen
On 11/16/2019 12:22 AM, David Howells wrote:
> Actually, no, this is the fix:
>
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index 7006b5b2106d..be2fc5793ddd 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -537,7 +537,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
> buf->ops = &default_pipe_buf_ops;
> buf->page = page;
> buf->offset = 0;
> - buf->len = max_t(ssize_t, left, PAGE_SIZE);
> + buf->len = min_t(ssize_t, left, PAGE_SIZE);
> left -= buf->len;
> iter_head++;
> pipe->head = iter_head;
>
> David
> _______________________________________________
> LKP mailing list -- lkp(a)lists.01.org
> To unsubscribe send an email to lkp-leave(a)lists.01.org
next prev parent reply other threads:[~2019-11-18 7:53 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 17:34 [RFC PATCH 00/11] pipe: Notification queue preparation [ver #3] David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` [RFC PATCH 01/11] pipe: Reduce #inclusion of pipe_fs_i.h " David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` [RFC PATCH 02/11] Remove the nr_exclusive argument from __wake_up_sync_key() " David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` [RFC PATCH 03/11] Add wake_up_interruptible_sync_poll_locked() " David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` [RFC PATCH 04/11] pipe: Use head and tail pointers for the ring, not cursor and length " David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-07 9:03 ` [pipe] d60337eff1: phoronix-test-suite.noise-level.0.activity_level 144.0% improvement lkp report check
2019-11-07 9:03 ` lkp report check
2019-11-07 9:03 ` lkp report check
2019-11-07 16:51 ` Linus Torvalds
2019-11-07 16:51 ` Linus Torvalds
2019-11-07 16:51 ` Linus Torvalds
2019-11-07 17:42 ` David Howells
2019-11-07 17:42 ` David Howells
2019-11-10 3:13 ` [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2019-11-10 3:13 ` kernel test robot
2019-11-10 3:13 ` kernel test robot
2019-11-15 13:28 ` David Howells
2019-11-15 13:28 ` [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference, address David Howells
2019-11-15 16:22 ` [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference,address David Howells
2019-11-15 16:22 ` [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference, address David Howells
2019-11-18 7:53 ` kernel test robot [this message]
2019-11-18 7:53 ` kernel test robot
2019-11-18 7:53 ` [LKP] Re: [pipe] d60337eff1: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2019-11-01 17:34 ` [RFC PATCH 05/11] pipe: Allow pipes to have kernel-reserved slots [ver #3] David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` [RFC PATCH 06/11] pipe: Advance tail pointer inside of wait spinlock in pipe_read() " David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:34 ` David Howells
2019-11-01 17:35 ` [RFC PATCH 07/11] pipe: Conditionalise wakeup " David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` [RFC PATCH 08/11] pipe: Rearrange sequence in pipe_write() to preallocate slot " David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` [RFC PATCH 09/11] pipe: Remove redundant wakeup from pipe_write() " David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` [RFC PATCH 10/11] pipe: Check for ring full inside of the spinlock in " David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` [RFC PATCH 11/11] pipe: Increase the writer-wakeup threshold to reduce context-switch count " David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 17:35 ` David Howells
2019-11-01 19:24 ` [RFC PATCH 00/11] pipe: Notification queue preparation " Linus Torvalds
2019-11-01 19:24 ` Linus Torvalds
2019-11-01 22:05 ` David Howells
2019-11-01 22:12 ` Linus Torvalds
2019-11-01 22:12 ` Linus Torvalds
2019-11-05 16:02 ` Details on the UAPI of implementing notifications on pipes David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35daca93-ff2b-2c7d-b837-72396ca0677a@intel.com \
--to=rong.a.chen@intel.com \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=nicolas.dichtel@6wind.com \
--cc=peterz@infradead.org \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.