From: David Howells <dhowells@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: dhowells@redhat.com,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Casey Schaufler <casey@schaufler-ca.com>,
keyrings@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask
Date: Wed, 13 May 2020 23:16:12 +0000 [thread overview]
Message-ID: <3611715.1589411772@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHC9VhQhYz8xZ6MGv0S9q2D-gReb0Pqqb=2+oX=NVuxb_F5WfA@mail.gmail.com>
Paul Moore <paul@paul-moore.com> wrote:
> > + case KEY_NEED_VIEW: perm = KEY__VIEW; break;
> > + case KEY_NEED_READ: perm = KEY__READ; break;
> > + case KEY_NEED_WRITE: perm = KEY__WRITE; break;
> > + case KEY_NEED_SEARCH: perm = KEY__SEARCH; break;
> > + case KEY_NEED_LINK: perm = KEY__LINK; break;
> > + case KEY_NEED_SETATTR: perm = KEY__SETATTR; break;
>
> Please don't put the case statements all on one line, use the more
> traditional multi-line format. For example:
>
> case KEY_NEED_SETATTR:
> perm = KEY__SETATTR;
> break;
Tabulation was invented something like 6000 years ago for just this kind of
purpose;-) It's less readable your way, but whatever...
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: dhowells@redhat.com,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Casey Schaufler <casey@schaufler-ca.com>,
keyrings@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask
Date: Thu, 14 May 2020 00:16:12 +0100 [thread overview]
Message-ID: <3611715.1589411772@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHC9VhQhYz8xZ6MGv0S9q2D-gReb0Pqqb=2+oX=NVuxb_F5WfA@mail.gmail.com>
Paul Moore <paul@paul-moore.com> wrote:
> > + case KEY_NEED_VIEW: perm = KEY__VIEW; break;
> > + case KEY_NEED_READ: perm = KEY__READ; break;
> > + case KEY_NEED_WRITE: perm = KEY__WRITE; break;
> > + case KEY_NEED_SEARCH: perm = KEY__SEARCH; break;
> > + case KEY_NEED_LINK: perm = KEY__LINK; break;
> > + case KEY_NEED_SETATTR: perm = KEY__SETATTR; break;
>
> Please don't put the case statements all on one line, use the more
> traditional multi-line format. For example:
>
> case KEY_NEED_SETATTR:
> perm = KEY__SETATTR;
> break;
Tabulation was invented something like 6000 years ago for just this kind of
purpose;-) It's less readable your way, but whatever...
David
next prev parent reply other threads:[~2020-05-13 23:16 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:48 Problem with 9ba09998baa9 ("selinux: Implement the watch_key security hook") in linux-next Paul Moore
2020-04-17 15:48 ` Paul Moore
2020-04-17 16:32 ` Richard Haines
2020-04-17 16:32 ` Richard Haines
2020-04-17 16:59 ` Paul Moore
2020-04-17 16:59 ` Paul Moore
2020-04-21 12:29 ` David Howells
2020-04-21 12:29 ` David Howells
2020-04-22 19:20 ` Paul Moore
2020-04-22 19:20 ` Paul Moore
2020-04-22 21:09 ` Paul Moore
2020-04-22 21:09 ` Paul Moore
2020-04-24 23:43 ` David Howells
2020-04-24 23:43 ` David Howells
2020-04-26 20:53 ` Paul Moore
2020-04-26 20:53 ` Paul Moore
2020-04-27 14:12 ` [PATCH] selinux: Fix use of KEY_NEED_* instead of KEY__* perms David Howells
2020-04-27 14:12 ` David Howells
2020-04-27 14:36 ` Stephen Smalley
2020-04-27 14:36 ` Stephen Smalley
2020-04-27 15:24 ` Paul Moore
2020-04-27 15:24 ` Paul Moore
2020-04-27 17:02 ` Stephen Smalley
2020-04-27 17:02 ` Stephen Smalley
2020-04-27 22:17 ` Paul Moore
2020-04-27 22:17 ` Paul Moore
2020-04-28 12:54 ` [PATCH] selinux: Fix use of KEY_NEED_* instead of KEY__* perms [v2] David Howells
2020-04-28 12:54 ` David Howells
2020-04-28 14:32 ` Stephen Smalley
2020-04-28 14:32 ` Stephen Smalley
2020-04-28 15:57 ` David Howells
2020-04-28 15:57 ` David Howells
2020-04-28 16:19 ` Stephen Smalley
2020-04-28 16:19 ` Stephen Smalley
2020-05-01 16:37 ` Paul Moore
2020-05-01 16:37 ` Paul Moore
2020-05-12 22:33 ` [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask David Howells
2020-05-12 22:33 ` David Howells
2020-05-13 1:04 ` Paul Moore
2020-05-13 1:04 ` Paul Moore
2020-05-13 12:58 ` Stephen Smalley
2020-05-13 12:58 ` Stephen Smalley
2020-05-13 15:25 ` Casey Schaufler
2020-05-13 15:25 ` Casey Schaufler
2020-05-13 23:13 ` David Howells
2020-05-13 23:13 ` David Howells
2020-05-14 12:08 ` Stephen Smalley
2020-05-14 12:08 ` Stephen Smalley
2020-05-14 14:45 ` Stephen Smalley
2020-05-14 14:45 ` Stephen Smalley
2020-05-13 23:16 ` David Howells [this message]
2020-05-13 23:16 ` David Howells
2020-05-13 23:25 ` David Howells
2020-05-13 23:25 ` David Howells
2020-05-14 11:00 ` Jarkko Sakkinen
2020-05-14 11:00 ` Jarkko Sakkinen
2020-05-14 16:58 ` [PATCH] keys: Move permissions checking decisions into the checking code David Howells
2020-05-14 16:58 ` David Howells
2020-05-14 17:06 ` Casey Schaufler
2020-05-14 17:06 ` Casey Schaufler
2020-05-15 15:06 ` Stephen Smalley
2020-05-15 15:06 ` Stephen Smalley
2020-05-15 16:45 ` David Howells
2020-05-15 16:45 ` David Howells
2020-05-15 18:55 ` Stephen Smalley
2020-05-15 18:55 ` Stephen Smalley
2020-05-15 19:10 ` Casey Schaufler
2020-05-15 19:10 ` Casey Schaufler
2020-05-15 22:27 ` David Howells
2020-05-15 22:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3611715.1589411772@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=casey@schaufler-ca.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.