All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>,
	<dri-devel@lists.freedesktop.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>, <linux-arm-msm@vger.kernel.org>,
	<linux-pwm@vger.kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	<patches@opensource.cirrus.com>,
	Support Opensource <support.opensource@diasemi.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v3 02/13] backlight: add backlight_is_blank()
Date: Mon, 1 Jun 2020 15:27:39 +0300	[thread overview]
Message-ID: <36c42682-c17c-b5d9-8401-89eadd325bf4@ti.com> (raw)
In-Reply-To: <20200601065207.492614-3-sam@ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]



On 01/06/2020 9.51, Sam Ravnborg wrote:
> The backlight support has two properties that express the state:
> - power
> - state
> 
> It is un-documented and easy to get wrong.
> Add backlight_is_blank() helper to make it simpler
> for drivers to get the check of the state correct.
> 
> A lot of drivers also includes checks for fb_blank.
> This check is redundant when the state is checked
> and thus not needed in this helper function.
> But added anyway to avoid introducing subtle bugs
> due to the creative use of fb_blank in some drivers.
> Introducing this helper will for some drivers results in
> added support for fb_blank. This will be a change in
> functionality, which will improve the backlight driver.
> 
> Rolling out this helper to all relevant backlight drivers
> will eliminate almost all accesses to fb_blank.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> v3:
>   - Clarified that the fb_blank support in
>     backlight_is_blank() may result in functionality
>     changes for the users (Emil)
> 
> v2:
>   - Added fb_blank condition (Daniel)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---
>  include/linux/backlight.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index c7d6b2e8c3b5..a0a083b35c47 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -175,6 +175,25 @@ static inline void backlight_put(struct backlight_device *bd)
>  		put_device(&bd->dev);
>  }
>  
> +/**
> + * backlight_is_blank - Return true if display is expected to be blank
> + * @bd: the backlight device
> + *
> + * Display is expected to be blank if any of these is true::
> + *
> + *   1) if power in not UNBLANK
> + *   2) if fb_blank is not UNBLANK
> + *   3) if state indicate BLANK or SUSPENDED
> + *
> + * Returns true if display is expected to be blank, false otherwise.
> + */
> +static inline bool backlight_is_blank(struct backlight_device *bd)
> +{
> +	return bd->props.power != FB_BLANK_UNBLANK ||
> +	       bd->props.fb_blank != FB_BLANK_UNBLANK ||
> +	       bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK);
> +}
> +
>  extern struct backlight_device *backlight_device_register(const char *name,
>  	struct device *dev, void *devdata, const struct backlight_ops *ops,
>  	const struct backlight_properties *props);
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1783 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org,
	Jingoo Han <jingoohan1@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	patches@opensource.cirrus.com,
	Support Opensource <support.opensource@diasemi.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH v3 02/13] backlight: add backlight_is_blank()
Date: Mon, 1 Jun 2020 15:27:39 +0300	[thread overview]
Message-ID: <36c42682-c17c-b5d9-8401-89eadd325bf4@ti.com> (raw)
In-Reply-To: <20200601065207.492614-3-sam@ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]



On 01/06/2020 9.51, Sam Ravnborg wrote:
> The backlight support has two properties that express the state:
> - power
> - state
> 
> It is un-documented and easy to get wrong.
> Add backlight_is_blank() helper to make it simpler
> for drivers to get the check of the state correct.
> 
> A lot of drivers also includes checks for fb_blank.
> This check is redundant when the state is checked
> and thus not needed in this helper function.
> But added anyway to avoid introducing subtle bugs
> due to the creative use of fb_blank in some drivers.
> Introducing this helper will for some drivers results in
> added support for fb_blank. This will be a change in
> functionality, which will improve the backlight driver.
> 
> Rolling out this helper to all relevant backlight drivers
> will eliminate almost all accesses to fb_blank.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> v3:
>   - Clarified that the fb_blank support in
>     backlight_is_blank() may result in functionality
>     changes for the users (Emil)
> 
> v2:
>   - Added fb_blank condition (Daniel)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---
>  include/linux/backlight.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index c7d6b2e8c3b5..a0a083b35c47 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -175,6 +175,25 @@ static inline void backlight_put(struct backlight_device *bd)
>  		put_device(&bd->dev);
>  }
>  
> +/**
> + * backlight_is_blank - Return true if display is expected to be blank
> + * @bd: the backlight device
> + *
> + * Display is expected to be blank if any of these is true::
> + *
> + *   1) if power in not UNBLANK
> + *   2) if fb_blank is not UNBLANK
> + *   3) if state indicate BLANK or SUSPENDED
> + *
> + * Returns true if display is expected to be blank, false otherwise.
> + */
> +static inline bool backlight_is_blank(struct backlight_device *bd)
> +{
> +	return bd->props.power != FB_BLANK_UNBLANK ||
> +	       bd->props.fb_blank != FB_BLANK_UNBLANK ||
> +	       bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK);
> +}
> +
>  extern struct backlight_device *backlight_device_register(const char *name,
>  	struct device *dev, void *devdata, const struct backlight_ops *ops,
>  	const struct backlight_properties *props);
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1783 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>,
	<dri-devel@lists.freedesktop.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>
Cc: linux-pwm@vger.kernel.org,
	Support Opensource <support.opensource@diasemi.com>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-arm-msm@vger.kernel.org,
	Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>,
	patches@opensource.cirrus.com
Subject: Re: [PATCH v3 02/13] backlight: add backlight_is_blank()
Date: Mon, 1 Jun 2020 15:27:39 +0300	[thread overview]
Message-ID: <36c42682-c17c-b5d9-8401-89eadd325bf4@ti.com> (raw)
In-Reply-To: <20200601065207.492614-3-sam@ravnborg.org>

[-- Attachment #1: Type: text/plain, Size: 2880 bytes --]



On 01/06/2020 9.51, Sam Ravnborg wrote:
> The backlight support has two properties that express the state:
> - power
> - state
> 
> It is un-documented and easy to get wrong.
> Add backlight_is_blank() helper to make it simpler
> for drivers to get the check of the state correct.
> 
> A lot of drivers also includes checks for fb_blank.
> This check is redundant when the state is checked
> and thus not needed in this helper function.
> But added anyway to avoid introducing subtle bugs
> due to the creative use of fb_blank in some drivers.
> Introducing this helper will for some drivers results in
> added support for fb_blank. This will be a change in
> functionality, which will improve the backlight driver.
> 
> Rolling out this helper to all relevant backlight drivers
> will eliminate almost all accesses to fb_blank.

Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> 
> v3:
>   - Clarified that the fb_blank support in
>     backlight_is_blank() may result in functionality
>     changes for the users (Emil)
> 
> v2:
>   - Added fb_blank condition (Daniel)
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Emil Velikov <emil.l.velikov@gmail.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Jingoo Han <jingoohan1@gmail.com>
> ---
>  include/linux/backlight.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> index c7d6b2e8c3b5..a0a083b35c47 100644
> --- a/include/linux/backlight.h
> +++ b/include/linux/backlight.h
> @@ -175,6 +175,25 @@ static inline void backlight_put(struct backlight_device *bd)
>  		put_device(&bd->dev);
>  }
>  
> +/**
> + * backlight_is_blank - Return true if display is expected to be blank
> + * @bd: the backlight device
> + *
> + * Display is expected to be blank if any of these is true::
> + *
> + *   1) if power in not UNBLANK
> + *   2) if fb_blank is not UNBLANK
> + *   3) if state indicate BLANK or SUSPENDED
> + *
> + * Returns true if display is expected to be blank, false otherwise.
> + */
> +static inline bool backlight_is_blank(struct backlight_device *bd)
> +{
> +	return bd->props.power != FB_BLANK_UNBLANK ||
> +	       bd->props.fb_blank != FB_BLANK_UNBLANK ||
> +	       bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK);
> +}
> +
>  extern struct backlight_device *backlight_device_register(const char *name,
>  	struct device *dev, void *devdata, const struct backlight_ops *ops,
>  	const struct backlight_properties *props);
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1783 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-01 12:27 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  6:51 [PATCH v3 0/16] backlight updates Sam Ravnborg
2020-06-01  6:51 ` Sam Ravnborg
2020-06-01  6:51 ` Sam Ravnborg
2020-06-01  6:51 ` [PATCH v3 01/13] backlight: refactor fb_notifier_callback() Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51 ` [PATCH v3 02/13] backlight: add backlight_is_blank() Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01 12:27   ` Peter Ujfalusi [this message]
2020-06-01 12:27     ` Peter Ujfalusi
2020-06-01 12:27     ` Peter Ujfalusi
2020-06-01  6:51 ` [PATCH v3 03/13] backlight: improve backlight_ops documentation Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51 ` [PATCH v3 04/13] backlight: improve backlight_properties documentation Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01 10:10   ` Daniel Thompson
2020-06-01 10:10     ` Daniel Thompson
2020-06-01 10:10     ` Daniel Thompson
2020-06-01  6:51 ` [PATCH v3 05/13] backlight: improve backlight_device documentation Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01  6:51   ` Sam Ravnborg
2020-06-01 10:23   ` Daniel Thompson
2020-06-01 10:23     ` Daniel Thompson
2020-06-01 10:23     ` Daniel Thompson
2020-06-01  6:52 ` [PATCH v3 06/13] backlight: document inline functions in backlight.h Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52 ` [PATCH v3 07/13] backlight: document enums " Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52 ` [PATCH v3 08/13] backlight: remove the unused backlight_bl driver Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52 ` [PATCH v3 09/13] backlight: drop extern from prototypes Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52 ` [PATCH v3 10/13] backlight: add overview and update existing doc Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01 10:34   ` Daniel Thompson
2020-06-01 10:34     ` Daniel Thompson
2020-06-01 10:34     ` Daniel Thompson
2020-06-01  6:52 ` [PATCH v3 11/13] backlight: wire up kernel-doc documentation Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52 ` [PATCH v3 12/13] backlight: as3711_bl: introduce backlight_is_blank() Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01 10:35   ` Daniel Thompson
2020-06-01 10:35     ` Daniel Thompson
2020-06-01 10:35     ` Daniel Thompson
2020-06-01  6:52 ` [PATCH v3 13/13] backlight: use backlight_is_blank() in all backlight drivers Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01  6:52   ` Sam Ravnborg
2020-06-01 12:28   ` Peter Ujfalusi
2020-06-01 12:28     ` Peter Ujfalusi
2020-06-01 12:28     ` Peter Ujfalusi
2020-06-01 12:39     ` Sam Ravnborg
2020-06-01 12:39       ` Sam Ravnborg
2020-06-01 12:39       ` Sam Ravnborg
2020-06-02 14:04 ` [PATCH v3 0/16] backlight updates Emil Velikov
2020-06-02 14:04   ` Emil Velikov
2020-06-02 14:04   ` Emil Velikov
2020-07-02  8:01   ` Sam Ravnborg
2020-07-02  8:01     ` Sam Ravnborg
2020-07-02  8:01     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36c42682-c17c-b5d9-8401-89eadd325bf4@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=corbet@lwn.net \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michael.hennerich@analog.com \
    --cc=mripard@kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=sam@ravnborg.org \
    --cc=support.opensource@diasemi.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tzimmermann@suse.de \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.