All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	bertrand.marquis@arm.com, wei.chen@arm.com,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE
Date: Mon, 8 Mar 2021 11:00:51 +0100	[thread overview]
Message-ID: <3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com> (raw)
In-Reply-To: <20210308095233.13329-1-michal.orzel@arm.com>

On 08.03.2021 10:52, Michal Orzel wrote:
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -400,6 +400,20 @@ config DOM0_MEM
>  
>  	  Leave empty if you are not sure what to specify.
>  
> +config LINK_DTB
> +	bool "Link DTB into Xen image"
> +	depends on ARM
> +	default n

I don't think this last line is needed.

> +config DTB_FILE
> +	string "Absolute path to device tree blob"
> +	default ""
> +	depends on LINK_DTB
> +	---help---
> +	  When using a bootloader that has no device tree support or when there
> +	  is no bootloader at all, use this option to specify the absolute path
> +	  to a device tree that will be linked directly inside Xen binary.

How is selecting LINK_DTB but leaving DTB_FILE at an empty string
different from not having a LINK_DTB setting at all?

Jan


  reply	other threads:[~2021-03-08 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08  9:52 [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE Michal Orzel
2021-03-08 10:00 ` Jan Beulich [this message]
2021-03-08 11:02   ` Michal Orzel
2021-03-08 11:28     ` Jan Beulich
2021-03-08 13:11       ` Michal Orzel
2021-03-08 13:13         ` Jan Beulich
2021-03-08 13:44           ` Michal Orzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3709714b-6627-3c66-b8ca-4cb9c59df83b@suse.com \
    --to=jbeulich@suse.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bertrand.marquis@arm.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=julien@xen.org \
    --cc=michal.orzel@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.chen@arm.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.