From: Jan Beulich <jbeulich@suse.com>
To: Michal Orzel <michal.orzel@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
bertrand.marquis@arm.com, wei.chen@arm.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE
Date: Mon, 8 Mar 2021 12:28:43 +0100 [thread overview]
Message-ID: <dc49957d-885d-07e4-aa00-74668e331da2@suse.com> (raw)
In-Reply-To: <f15c2f35-4f1c-de2c-81dc-de47282cf588@arm.com>
On 08.03.2021 12:02, Michal Orzel wrote:
> On 08.03.2021 11:00, Jan Beulich wrote:
>> On 08.03.2021 10:52, Michal Orzel wrote:
>>> +config DTB_FILE
>>> + string "Absolute path to device tree blob"
>>> + default ""
>>> + depends on LINK_DTB
>>> + ---help---
>>> + When using a bootloader that has no device tree support or when there
>>> + is no bootloader at all, use this option to specify the absolute path
>>> + to a device tree that will be linked directly inside Xen binary.
>>
>> How is selecting LINK_DTB but leaving DTB_FILE at an empty string
>> different from not having a LINK_DTB setting at all?
>>
> LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB option will result in
> a build failure each time the user does not want to embed dtb into Xen(DTB_FILE is empty).
Which isn't any different from having LINK_DTB and leaving the
string empty, is it? I.e. imo no improved user experience.
> I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an empty string.
People may not "want" to, but simply think accepting the default
is fine, considering they've already said to link in some DTB.
It may be obvious to you that there's no good default here, but
it may not be to the person configuring their Xen. I'm guessing
here, but did you try leaving out the default line? Would this
make kconfig insist on the person to type in something? (Likely
an empty string would still be accepted. As would be a relative
path, despite what the help text says; I guess some forms of
relative paths may even work.)
Jan
next prev parent reply other threads:[~2021-03-08 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 9:52 [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE Michal Orzel
2021-03-08 10:00 ` Jan Beulich
2021-03-08 11:02 ` Michal Orzel
2021-03-08 11:28 ` Jan Beulich [this message]
2021-03-08 13:11 ` Michal Orzel
2021-03-08 13:13 ` Jan Beulich
2021-03-08 13:44 ` Michal Orzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc49957d-885d-07e4-aa00-74668e331da2@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=michal.orzel@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.