All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: bvanassche@acm.org, hch@lst.de, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org,
	james.bottomley@hansenpartnership.com,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	snitzer@kernel.org, axboe@kernel.dk,
	linux-nvme@lists.infradead.org, chaitanyak@nvidia.com,
	target-devel@vger.kernel.org
Subject: Re: [PATCH v3 08/19] nvme: Move pr code to it's own file
Date: Fri, 28 Oct 2022 11:06:29 -0500	[thread overview]
Message-ID: <370e66bd-81d0-5451-850e-50a4172ed64f@oracle.com> (raw)
In-Reply-To: <Y1q6so/3Hx9GZmTz@kbusch-mbp.dhcp.thefacebook.com>

On 10/27/22 12:06 PM, Keith Busch wrote:
> On Wed, Oct 26, 2022 at 06:19:34PM -0500, Mike Christie wrote:
>> This patch moves the pr code to it's own file because I'm going to be
>> adding more functions and core.c is getting bigger.
>>
>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> 
> Good idea.

Credit goes to Chaitanya.

One question for you. I wasn't sure about the copyright. I saw
you added the pr_ops code in 2015 when you were at Intel. Do you
want me to add:

Copyright (c) 2015, Intel Corporation.

to the new pr.c file?

WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michael.christie@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	chaitanyak@nvidia.com, bvanassche@acm.org,
	linux-scsi@vger.kernel.org, snitzer@kernel.org,
	linux-nvme@lists.infradead.org,
	james.bottomley@hansenpartnership.com, dm-devel@redhat.com,
	target-devel@vger.kernel.org, martin.petersen@oracle.com,
	hch@lst.de
Subject: Re: [dm-devel] [PATCH v3 08/19] nvme: Move pr code to it's own file
Date: Fri, 28 Oct 2022 11:06:29 -0500	[thread overview]
Message-ID: <370e66bd-81d0-5451-850e-50a4172ed64f@oracle.com> (raw)
In-Reply-To: <Y1q6so/3Hx9GZmTz@kbusch-mbp.dhcp.thefacebook.com>

On 10/27/22 12:06 PM, Keith Busch wrote:
> On Wed, Oct 26, 2022 at 06:19:34PM -0500, Mike Christie wrote:
>> This patch moves the pr code to it's own file because I'm going to be
>> adding more functions and core.c is getting bigger.
>>
>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> 
> Good idea.

Credit goes to Chaitanya.

One question for you. I wasn't sure about the copyright. I saw
you added the pr_ops code in 2015 when you were at Intel. Do you
want me to add:

Copyright (c) 2015, Intel Corporation.

to the new pr.c file?

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2022-10-28 16:09 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 23:19 [PATCH v3 00/19] Use block pr_ops in LIO Mike Christie
2022-10-26 23:19 ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 01/19] block: Add PR callouts for read keys and reservation Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-11-02 22:50   ` Bart Van Assche
2022-11-02 22:50     ` [dm-devel] " Bart Van Assche
2022-11-03  1:54     ` Mike Christie
2022-11-03  1:54       ` [dm-devel] " Mike Christie
2022-11-02 22:53   ` Bart Van Assche
2022-11-02 22:53     ` [dm-devel] " Bart Van Assche
2022-11-03  2:25     ` Mike Christie
2022-11-03  2:25       ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 02/19] scsi: Rename sd_pr_command Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-11-01  5:33   ` Chaitanya Kulkarni
2022-11-01  5:33     ` [dm-devel] " Chaitanya Kulkarni
2022-10-26 23:19 ` [PATCH v3 03/19] scsi: Move sd_pr_type to header to share Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-11-01  5:43   ` Chaitanya Kulkarni
2022-11-01  5:43     ` [dm-devel] " Chaitanya Kulkarni
2022-11-01 16:43     ` Mike Christie
2022-11-01 16:43       ` [dm-devel] " Mike Christie
2022-11-02 22:47   ` Bart Van Assche
2022-11-02 22:47     ` [dm-devel] " Bart Van Assche
2022-11-03  2:13     ` Mike Christie
2022-11-03  2:13       ` [dm-devel] " Mike Christie
2022-11-03 18:14       ` Bart Van Assche
2022-11-03 18:14         ` [dm-devel] " Bart Van Assche
2022-10-26 23:19 ` [PATCH v3 04/19] scsi: Add support for block PR read keys/reservation Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-27  6:08   ` kernel test robot
2022-10-27  6:08     ` [dm-devel] " kernel test robot
2022-10-27  7:59   ` kernel test robot
2022-10-27  7:59     ` [dm-devel] " kernel test robot
2022-10-27 10:41   ` kernel test robot
2022-10-27 10:41     ` [dm-devel] " kernel test robot
2022-11-01  5:45   ` Chaitanya Kulkarni
2022-11-01  5:45     ` [dm-devel] " Chaitanya Kulkarni
2022-11-02 22:54   ` Bart Van Assche
2022-11-02 22:54     ` [dm-devel] " Bart Van Assche
2022-10-26 23:19 ` [PATCH v3 05/19] dm: " Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 06/19] nvme: Fix reservation status related structs Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-27 17:04   ` Keith Busch
2022-10-27 17:04     ` [dm-devel] " Keith Busch
2022-10-26 23:19 ` [PATCH v3 07/19] nvme: Don't hardcode the data len for pr commands Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-27 17:05   ` Keith Busch
2022-10-27 17:05     ` [dm-devel] " Keith Busch
2022-11-01  5:29   ` Chaitanya Kulkarni
2022-11-01  5:29     ` [dm-devel] " Chaitanya Kulkarni
2022-10-26 23:19 ` [PATCH v3 08/19] nvme: Move pr code to it's own file Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-27 17:06   ` Keith Busch
2022-10-27 17:06     ` [dm-devel] " Keith Busch
2022-10-28 16:06     ` Mike Christie [this message]
2022-10-28 16:06       ` Mike Christie
2022-10-28 16:38       ` Keith Busch
2022-10-28 16:38         ` [dm-devel] " Keith Busch
2022-10-30  8:06         ` Christoph Hellwig
2022-10-30  8:06           ` [dm-devel] " Christoph Hellwig
2022-11-01  5:25   ` Chaitanya Kulkarni
2022-11-01  5:25     ` [dm-devel] " Chaitanya Kulkarni
2022-10-26 23:19 ` [PATCH v3 09/19] nvme: Add pr_ops read_keys support Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-30  8:17   ` Christoph Hellwig
2022-10-30  8:17     ` [dm-devel] " Christoph Hellwig
2022-10-30 20:47     ` Mike Christie
2022-10-30 20:47       ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 10/19] nvme: Move NVMe and Block PR types to an array Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-27 15:18   ` Keith Busch
2022-10-27 15:18     ` [dm-devel] " Keith Busch
2022-10-27 17:06     ` Mike Christie
2022-10-27 17:06       ` [dm-devel] " Mike Christie
2022-10-27 17:13       ` michael.christie
2022-10-27 17:13         ` [dm-devel] " michael.christie
2022-10-27 17:16         ` Keith Busch
2022-10-27 17:16           ` [dm-devel] " Keith Busch
2022-10-28 16:05           ` Mike Christie
2022-10-28 16:05             ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 11/19] nvme: Add pr_ops read_reservation support Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-30  8:18   ` Christoph Hellwig
2022-10-30  8:18     ` [dm-devel] " Christoph Hellwig
2022-10-30 20:54     ` Mike Christie
2022-10-30 20:54       ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 12/19] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Mike Christie
2022-10-26 23:19   ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Mike Christie
2022-10-30  8:20   ` [PATCH v3 12/19] block,nvme,scsi,dm: " Christoph Hellwig
2022-10-30  8:20     ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Christoph Hellwig
2022-10-30 23:05     ` [PATCH v3 12/19] block,nvme,scsi,dm: " Mike Christie
2022-10-30 23:05       ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Mike Christie
2022-11-01 10:15       ` [PATCH v3 12/19] block,nvme,scsi,dm: " Christoph Hellwig
2022-11-01 10:15         ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Christoph Hellwig
2022-11-05 18:36         ` [PATCH v3 12/19] block,nvme,scsi,dm: " Mike Christie
2022-11-05 18:36           ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Mike Christie
2022-11-07  9:16           ` [PATCH v3 12/19] block,nvme,scsi,dm: " Christoph Hellwig
2022-11-07  9:16             ` [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: " Christoph Hellwig
2022-10-26 23:19 ` [PATCH v3 13/19] nvme: Have NVMe pr_ops return a blk_status_t Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 14/19] scsi: Export scsi_result_to_blk_status Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 15/19] scsi: Have sd pr_ops return a blk_status_t Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 16/19] scsi: target: Rename sbc_ops to exec_cmd_ops Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 17/19] scsi: target: Allow backends to hook into PR handling Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 18/19] scsi: target: Don't support SCSI-2 RESERVE/RELEASE Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie
2022-10-26 23:19 ` [PATCH v3 19/19] scsi: target: Add block PR support to iblock Mike Christie
2022-10-26 23:19   ` [dm-devel] " Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=370e66bd-81d0-5451-850e-50a4172ed64f@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=snitzer@kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.