From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4] ubifs: remove broken lazytime support
Date: Wed, 25 Mar 2020 18:51:59 +0300 [thread overview]
Message-ID: <3771d2fd-b563-b74d-491b-e2bab9242126@cogentembedded.com> (raw)
In-Reply-To: <20200325122825.1086872-2-hch@lst.de>
Hello!
On 03/25/2020 03:28 PM, Christoph Hellwig wrote:
> When "ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs" introduces atime
> support to ubifs, it also lazytime support, but that support is
^ includes?
> terminally broken, as it causes mark_inode_dirty_sync to be called from
> __writeback_single_inode, which will then trigger the locking assert
> in ubifs_dirty_inode. Just remove this broken support for now, it can
> be readded later, especially as some infrastructure changes should
> make that easier soon.
>
> Fixes: 8c1c5f263833 ("ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 1/4] ubifs: remove broken lazytime support
Date: Wed, 25 Mar 2020 18:51:59 +0300 [thread overview]
Message-ID: <3771d2fd-b563-b74d-491b-e2bab9242126@cogentembedded.com> (raw)
In-Reply-To: <20200325122825.1086872-2-hch@lst.de>
Hello!
On 03/25/2020 03:28 PM, Christoph Hellwig wrote:
> When "ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs" introduces atime
> support to ubifs, it also lazytime support, but that support is
^ includes?
> terminally broken, as it causes mark_inode_dirty_sync to be called from
> __writeback_single_inode, which will then trigger the locking assert
> in ubifs_dirty_inode. Just remove this broken support for now, it can
> be readded later, especially as some infrastructure changes should
> make that easier soon.
>
> Fixes: 8c1c5f263833 ("ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
[...]
MBR, Sergei
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Christoph Hellwig <hch@lst.de>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/4] ubifs: remove broken lazytime support
Date: Wed, 25 Mar 2020 18:51:59 +0300 [thread overview]
Message-ID: <3771d2fd-b563-b74d-491b-e2bab9242126@cogentembedded.com> (raw)
In-Reply-To: <20200325122825.1086872-2-hch@lst.de>
Hello!
On 03/25/2020 03:28 PM, Christoph Hellwig wrote:
> When "ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs" introduces atime
> support to ubifs, it also lazytime support, but that support is
^ includes?
> terminally broken, as it causes mark_inode_dirty_sync to be called from
> __writeback_single_inode, which will then trigger the locking assert
> in ubifs_dirty_inode. Just remove this broken support for now, it can
> be readded later, especially as some infrastructure changes should
> make that easier soon.
>
> Fixes: 8c1c5f263833 ("ubifs: introduce UBIFS_ATIME_SUPPORT to ubifs")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
[...]
MBR, Sergei
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-03-25 15:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 12:28 lazytime fixes Christoph Hellwig
2020-03-25 12:28 ` Christoph Hellwig
2020-03-25 12:28 ` [f2fs-dev] " Christoph Hellwig
2020-03-25 12:28 ` [PATCH 1/4] ubifs: remove broken lazytime support Christoph Hellwig
2020-03-25 12:28 ` Christoph Hellwig
2020-03-25 12:28 ` [f2fs-dev] " Christoph Hellwig
2020-03-25 15:51 ` Sergei Shtylyov [this message]
2020-03-25 15:51 ` Sergei Shtylyov
2020-03-25 15:51 ` [f2fs-dev] " Sergei Shtylyov
2020-03-25 12:28 ` [PATCH 2/4] fs: avoid double-writing the inode on a lazytime expiration Christoph Hellwig
2020-03-25 12:28 ` Christoph Hellwig
2020-03-25 12:28 ` [f2fs-dev] " Christoph Hellwig
2020-03-25 15:01 ` Christoph Hellwig
2020-03-25 15:01 ` Christoph Hellwig
2020-03-25 15:01 ` [f2fs-dev] " Christoph Hellwig
2020-03-26 3:22 ` Dave Chinner
2020-03-26 3:22 ` Dave Chinner
2020-03-26 3:22 ` [f2fs-dev] " Dave Chinner
2020-03-26 17:01 ` Christoph Hellwig
2020-03-26 17:01 ` Christoph Hellwig
2020-03-26 17:01 ` [f2fs-dev] " Christoph Hellwig
2020-03-25 12:28 ` [PATCH 3/4] fs: don't call ->dirty_inode for lazytime timestamp updates Christoph Hellwig
2020-03-25 12:28 ` Christoph Hellwig
2020-03-25 12:28 ` [f2fs-dev] " Christoph Hellwig
2020-03-25 12:28 ` [PATCH 4/4] fs: clean up generic_update_time a bit Christoph Hellwig
2020-03-25 12:28 ` Christoph Hellwig
2020-03-25 12:28 ` [f2fs-dev] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3771d2fd-b563-b74d-491b-e2bab9242126@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.