From: "Rafael J. Wysocki" <rjw@sisk.pl> To: Viresh Kumar <viresh.kumar@linaro.org>, robin.randhawa@arm.com Cc: Francesco Lavra <francescolavra.fl@gmail.com>, Steve.Bannister@arm.com, linux@arm.linux.org.uk, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>, devicetree-discuss@lists.ozlabs.org, Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, charles.garcia-tobin@arm.com Subject: Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Date: Fri, 22 Mar 2013 00:50:56 +0100 [thread overview] Message-ID: <3782512.fC3ZOYy3MV@vostro.rjw.lan> (raw) In-Reply-To: <CAKohponV8MR=J8bbNFxGF9JXQB0uadv7iDcbW9D-qr2N53U_kQ@mail.gmail.com> On Monday, March 11, 2013 08:57:49 AM Viresh Kumar wrote: > On 10 March 2013 23:58, Francesco Lavra <francescolavra.fl@gmail.com> wrote: > > On 03/07/2013 06:14 PM, Viresh Kumar wrote: > >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > >> +{ > >> + if (arm_bL_ops != ops) { > >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", > >> + __func__, arm_bL_ops->name); > >> + } > > > > The code is not doing what the info message says. > > Yes, following is the improvement: Please post a complete update patch if you want me to take it. I'd also would like it to be ACKed by someone involved in the big-LITTLE work on the arch side. Thanks, Rafael > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 8b8b07e..9d449cf 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -264,8 +264,9 @@ EXPORT_SYMBOL_GPL(bL_cpufreq_register); > void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > { > if (arm_bL_ops != ops) { > - pr_info("%s: Registered with: %s, can't unregister, exiting\n", > + pr_err("%s: Registered with: %s, can't unregister, exiting\n", > __func__, arm_bL_ops->name); > + return; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
WARNING: multiple messages have this Message-ID (diff)
From: rjw@sisk.pl (Rafael J. Wysocki) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Date: Fri, 22 Mar 2013 00:50:56 +0100 [thread overview] Message-ID: <3782512.fC3ZOYy3MV@vostro.rjw.lan> (raw) In-Reply-To: <CAKohponV8MR=J8bbNFxGF9JXQB0uadv7iDcbW9D-qr2N53U_kQ@mail.gmail.com> On Monday, March 11, 2013 08:57:49 AM Viresh Kumar wrote: > On 10 March 2013 23:58, Francesco Lavra <francescolavra.fl@gmail.com> wrote: > > On 03/07/2013 06:14 PM, Viresh Kumar wrote: > >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > >> +{ > >> + if (arm_bL_ops != ops) { > >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", > >> + __func__, arm_bL_ops->name); > >> + } > > > > The code is not doing what the info message says. > > Yes, following is the improvement: Please post a complete update patch if you want me to take it. I'd also would like it to be ACKed by someone involved in the big-LITTLE work on the arch side. Thanks, Rafael > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 8b8b07e..9d449cf 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -264,8 +264,9 @@ EXPORT_SYMBOL_GPL(bL_cpufreq_register); > void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > { > if (arm_bL_ops != ops) { > - pr_info("%s: Registered with: %s, can't unregister, exiting\n", > + pr_err("%s: Registered with: %s, can't unregister, exiting\n", > __func__, arm_bL_ops->name); > + return; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-03-21 23:43 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-03-07 17:14 [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Viresh Kumar 2013-03-07 17:14 ` Viresh Kumar 2013-03-07 21:56 ` Guennadi Liakhovetski 2013-03-07 21:56 ` Guennadi Liakhovetski 2013-03-08 4:20 ` Viresh Kumar 2013-03-08 4:20 ` Viresh Kumar 2013-03-08 6:11 ` Guennadi Liakhovetski 2013-03-08 6:11 ` Guennadi Liakhovetski 2013-03-09 3:06 ` Viresh Kumar 2013-03-09 3:06 ` Viresh Kumar 2013-03-10 15:58 ` Francesco Lavra 2013-03-10 15:58 ` Francesco Lavra 2013-03-11 0:57 ` Viresh Kumar 2013-03-11 0:57 ` Viresh Kumar 2013-03-11 0:57 ` Viresh Kumar 2013-03-21 23:50 ` Rafael J. Wysocki [this message] 2013-03-21 23:50 ` Rafael J. Wysocki 2013-03-22 2:21 ` Viresh Kumar 2013-03-22 2:21 ` Viresh Kumar 2013-03-26 9:51 Viresh Kumar 2013-03-26 9:51 ` Viresh Kumar 2013-03-26 13:17 ` Rob Herring 2013-03-26 13:17 ` Rob Herring 2013-03-26 14:30 ` Viresh Kumar 2013-03-26 14:30 ` Viresh Kumar 2013-04-13 20:13 ` Francesco Lavra 2013-04-13 20:13 ` Francesco Lavra 2013-04-15 7:02 ` Viresh Kumar 2013-04-15 7:02 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3782512.fC3ZOYy3MV@vostro.rjw.lan \ --to=rjw@sisk.pl \ --cc=Liviu.Dudau@arm.com \ --cc=Steve.Bannister@arm.com \ --cc=charles.garcia-tobin@arm.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=francescolavra.fl@gmail.com \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=mark.hambleton@broadcom.com \ --cc=robin.randhawa@arm.com \ --cc=sudeep.karkadanagesha@arm.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.